Re: [PATCH, rs6000] [V2] Add ppc64_linux_gcc_target_options method

["Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>]

"will schmidt" <will_schmidt@vnet.ibm.com> wrote on 05.08.2021 22:43:02:

> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
> index 826f0266ed8..30230aa41da 100644
> --- a/gdb/rs6000-tdep.c
> +++ b/gdb/rs6000-tdep.c
> @@ -822,10 +822,18 @@ rs6000_stack_frame_destroyed_p (struct gdbarch
> *gdbarch, CORE_ADDR pc)
>  {
>    return rs6000_in_function_epilogue_frame_p (get_current_frame (),
>                       gdbarch, pc);
>  }
>
> +/* Implement the linux_gcc_target_options method.  */
> +
> +static std::string
> +ppc64_linux_gcc_target_options (struct gdbarch *gdbarch)
> +{
> +  return "";
> +}
> +
>  /* Get the ith function argument for the current function.  */
>  static CORE_ADDR
>  rs6000_fetch_pointer_argument (struct frame_info *frame, int argi,
>                  struct type *type)
>  {
> @@ -7129,10 +7137,14 @@ rs6000_gdbarch_init (struct gdbarch_info
> info, struct gdbarch_list *arches)
>    /* Trampoline.  */
>    set_gdbarch_in_solib_return_trampoline
>      (gdbarch, rs6000_in_solib_return_trampoline);
>    set_gdbarch_skip_trampoline_code (gdbarch,
rs6000_skip_trampoline_code);
>
> +  /* Set GCC target options.  */
> +  if (wordsize == 8)
> +    set_gdbarch_gcc_target_options (gdbarch,
ppc64_linux_gcc_target_options);

Linux-specific gdbarch callbacks should live in ppc-linux-tdep.c
and be installed from ppc_linux_init_abi.   Otherwise this looks OK.

Bye,
Ulrich