From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2013.outbound.protection.outlook.com [40.92.99.13]) by sourceware.org (Postfix) with ESMTPS id EE7F5385840A for ; Sun, 24 Jul 2022 04:10:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE7F5385840A ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enrbLZ3NVUO9a4ooBHAJTYlVtvz+GKdCgo19mol59VG86eCht3smb7gwqB44IFdDeTbS4Zvo+29KcIZvQfX8Z4+dvVz/P++rMoJXc3KkbaOLSW6y53/NpB4lNIOaHSw5F8Wbhbwwm9GMT/++xWIBXFauES21B0rc2DWtMe1d8GhRKoAoIBgvDyATxxjTjNq/wammW2tBIRcR0Avhb7PcyBNYRpbJR+2Or3zFaRwbSl3wvg7LvPn2X3y1lewf/2Psdoh7kelAFI5DE48Zp1XAgY2p1WSHcb0Q+Iz1p7E3sMVfyOJNZdrAh5jG9N0DztMFPus4KvWk2zVYspfYNTpv6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+eVdQP2pSUD2ewIojEAl7HWCNeNTH/X8D+OMvvcztug=; b=lTaocLPkFVrfZhvQ1rCFO5S7vteKYzEHCQQWztFaQnuK+5WuErAKBCnFN4mwD8ATPXjdbrB8DvkmzulSp5T01XmK18XQ40/leh+wvsrFbOdG5RKwAW+wWKC6VTh8VMIi7DBsj2z4mwYKqceLtJ0KGNXT3PQlGp9prqU7WsXseT3tfM9nSuf12i2hRldfhxnvyhPS8ZphALrj5RTzWgR41UsvFX7ViX70g5bliyZK+7kPiuZqpE3LUufCeu5yOD89jBjGsHkS94sjcpjEOSO072ubM/rcQb1p9+8MWYLriDHQY8YucD9a0UTlyxQFiMiBHji4wBx7BlbAgJa6VXCSmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYCP286MB1156.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Sun, 24 Jul 2022 04:10:08 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%8]) with mapi id 15.20.5458.021; Sun, 24 Jul 2022 04:10:07 +0000 Message-ID: Subject: Re: [PATCH v2 1/2] gdb/testsuite: rename get_maint_bp_addr and move it to gdb-utils.exp From: Enze Li To: Tom Tromey , Enze Li via Gdb-patches Cc: aburgess@redhat.com, pedro@palves.net, enze.li@gmx.com Date: Sun, 24 Jul 2022 12:10:03 +0800 In-Reply-To: <877d4eqr58.fsf@tromey.com> References: <877d4eqr58.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 X-TMN: [A0CBWrO3vLS7Q1FG0OCYdgxk2FUnMk17] X-ClientProxiedBy: SG2PR01CA0155.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::35) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 042a4e26-3ead-41fa-7ea7-08da6d2a64f6 X-MS-TrafficTypeDiagnostic: TYCP286MB1156:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nzwM6lXmK+xK74jXoXXD+KIKuFST44BmhONaX8MEwK4ToQrRLNHJqRHPY9rKsBecq56fit9Bt6DPEDkIyLgf74ag6NjS/hf4MzlwSMQNwLYf6HN8jyLlpkJzam5wGlNLOvsDVkqPECXJ5XjC7pMj6PI2AZOVvcVYgRKL8msl2LPdwRu5JH8iXjgHyRj8C61PDv4qT3CPgLkIYF1f2Ai01MEMWr0CmfoTNVpN8kUkfq2XugSN8XCI+kviMiexZM4JdXBIgBe0cZAuOdm6ugpNNhwCyIoeenhWqHBZ104Ng/GsuyloxtZNhbLysdtEo4trhqAGGXXJYB59dxW5ZJ1+l2HZhtndzgB06dcivObK4VW/o+WOagtpXC036XbNTfs6a5oZ7FyMOhGLNGwgePdWTLUUNZyAgMibFi55aEiJDGkVMeinZEXpJWYvn5r1qu8hnY5m+xkO9JpZl1dY849GfYOnmD21gvbFuBIM84RMnNeRYGwkbUqIl3wXSLV4bCONxPzvkJzSjZ16f9lhNCejewDkOZtiYVyKZz77ACmW/X0U6BcYKioeUlOdS1OqqjdcBpvCk5e66kVaPG8yPq+2xN6D5s6AEFOdu7AbWzTSMbqQY+Bx2BpFX52HJN0WkQk4DLTY7MsD8iUtYREUgrtzc44ORQcjKzPBOaNyxqa/NHoU4sGltq2yyS2CRsy2PMp5 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dk1hQTl5c3MzVzhzaUZzcHlCQ3ZFREp1UHhoRjhjMDZDK2hPdWJjNHYwWTly?= =?utf-8?B?cjZQMlJOS0Fxb01McW9mcmFwaU9UWlVyV2VseUsrQzN2WWVCVllWMFlkbGF0?= =?utf-8?B?c2hSMCtvaS9XMXplSWtYOXpSOWNJUVdlVGM3V2dIb0ZHL3RHTHlNanNQblBa?= =?utf-8?B?TUdRdU44aEtEWml6MmhNQjIwN29GRlA1Y1FTWGJkMGg4L2QxeE1ZZVFDNDYv?= =?utf-8?B?TWw3ck1lTVhXZTNvUlo3bkxlaHpjUVpsSW1RZ2YvMHVJc0hTMWFZck0vbzBp?= =?utf-8?B?WWY4c2V4ZDIrZ0hMVldNeEcyTTBnc3dOamF2eFBHaHVxUnZRN1k5SUp1V2hN?= =?utf-8?B?UGc1eXB0OEVlSXZQandBRXBkZW43cXdRQzBDdkczbEJOVE91WUNOZUlBY0lC?= =?utf-8?B?S28xbU9HeTM0OEFMY1ZYSEc0UXdhOHBtZUc2d1RNNk5VY1E4L0ZLTDNCVDRz?= =?utf-8?B?SXlzZHNHN0pON1Ezc3hkWGZwb1J5NElVZmE2RTdNWFhRZXpMV3VnKzhoWDA2?= =?utf-8?B?d1BSN3N3eVozNE1YQnZtSjNrY21SZjNHY29JcHVaaWhHZURsNTI4aDh3Vk94?= =?utf-8?B?dTh4NVhYRVpjT25JdFkxRkVOMmVFeHA1Y3Jjd3ErNlJTd0g5VEhKUWpUc3Vj?= =?utf-8?B?ZW9NTWptRjJxd0dOZWVFcndIWXpDNnQyNThySEdmSDRZcUlOcEtrdWt0NE1u?= =?utf-8?B?ZHJ0eFBPVGxtQ0V0YUNuRjgvVEdWVVdBUm03aXZLaVh3NndGVnJXRlhGWDN5?= =?utf-8?B?UVVXNHlzUXdUSzZtN1l6ZVJUb0lKdm1BZk1iNksrZFdrNUpodHRxSWcvVVRN?= =?utf-8?B?S0QwSmFBWWZlRklsY3NvRDljdmpGZm1VUmVua2VMMUx0OGVVQ1EwOGg5bVFj?= =?utf-8?B?bVVNaXdHZXF6NzZTaHJSam96WjJYajQzdnFZVnZzNGl5NlhEMmc4VnZlOURQ?= =?utf-8?B?b3ZoVmdHcnRXZmxJR0dyNC9IakwvRVU3Kzg0Mm05eXNPNU5SUEtFWlJ2U08r?= =?utf-8?B?ckRpbSs0cDREbDhBODFGKzdTQUtlWk9ZYXl0cjJzbENMTFUxMVVVTVBqLzdO?= =?utf-8?B?WklTU2hadUdpK0RqNHFTVW13eG10SmM0R2VoKzQxVkpIL0VDMTJiMng5cE03?= =?utf-8?B?NlgxclFSWTB4UGp0Q2pyakEwY0l4N2d5Zkp6cjJyckpEeEw0VlB4NWt3eTk0?= =?utf-8?B?Q3c5T2pCSzhCMTJTZHA3c0lYT1VVVzJQL1BRemNPZWljNC9tNnRRelpqVGpL?= =?utf-8?B?UW83OUI5UXkxR1FuUkNEWXowbUs0bTZEVkVldUJ0SVlBZUs3RFBEeStWNjZY?= =?utf-8?B?MkxHZ1VJdUlxWVVab1B1U1lIOE5qcEhvUTl3MGxYUlV2Kzh3ZzFwZmYwUFZm?= =?utf-8?B?eE42ajNKdWRyaStwQ2U3cEdTMTROaFdtcmkzdjI2YityNFdOOFhJblFtVmJP?= =?utf-8?B?SXc1VlZiUkFaWUxvbUxCQUVGUUhjUEN1OENvb044ZW1jNkprOG05OWpZVkV6?= =?utf-8?B?TzFnMytDYnRNZnozOC9HVi9WaVNYZVQ0cExhaEh5U0FqMXNreVNzN1A5QXNI?= =?utf-8?B?WENNQ0Q1MFF0bkowdGZJbHJDdWloNnUybUZpMGd1TFlaRUFOYXVtUHlCa3Rp?= =?utf-8?B?MU1zdFU1U2c4b0NVaCtvRVNyb2o5NUxod2MxYjhlRW54cklNTjQvTTZvUWZz?= =?utf-8?B?NU5QMU5YZ2ptTG5ONVczRFliTjJiYlpwME5FeVo1a0xUZXd6TzUxS0lRPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 042a4e26-3ead-41fa-7ea7-08da6d2a64f6 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2022 04:10:07.8307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1156 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jul 2022 04:10:13 -0000 On Fri, 2022-07-15 at 10:25 -0600, Tom Tromey wrote: > > > > > > "Enze" =3D=3D Enze Li via Gdb-patches > > > > > > writes: >=20 > Enze> The get_maint_bp_addr procedure will be shared by other test > suite, so > Enze> move it to gdb-utils.exp. >=20 > Enze> Following Andrew's suggestion, I renamed get_maint_bp_addr to > Enze> gdb_get_bp_addr, since it would have handled normal breakpoints > in > Enze> addition to the internal ones.=C2=A0 Note that there is still room > for > Enze> improvement in this procedure, which I indicated in comments > nearby. >=20 > This looks good to me, thanks. >=20 > Tom Hi Tom, Thanks for your review. I'm checking these in now. Best Regards, Enze