From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2079.outbound.protection.outlook.com [40.92.98.79]) by sourceware.org (Postfix) with ESMTPS id AE74E3858D28 for ; Tue, 12 Jul 2022 03:21:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE74E3858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nO+btvlabJYRNwC8xym7xMV0DQX95mPX0BH038PbfWeWyS+Ed/ULY+j9tN4Iii2XtMA/ihQecMYzFuMroZHF1T6huWPQElGlufYt9SqZgN9VLhfukLIjaTl4DdS2OeUPrpa6ZDAePEdFtxH0c7WStIgl7H5m3Iw5lf1X9QbaA/oz2BkIS+YM+WhVH6xAc8m/39svu2U2IUwIqJO9D4aeIG6Q4M/9rwJtqCo74d5+QnPCGTCOGFZxcRc6lfsZdHqIHNOgYvHJmPN5eXen0h/wyXfAsr8YJY/tkbDtifr4ZrN8UFL2umcxEZyingyN4XY+2VB+TT+pCy5bCTSEzk71Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bm8TDIGJVKpaNvkhWsDWVAsEQdOeVO1uMyMFgrxN2lo=; b=OMrHxtHiA2W+AefbOoSRDtfWCBWQC/7Ip9B8BsA7iftzKxMV55C4EUOmhNeIHxfL4NCNp24u3ZkMii65BbPcKd5qL+F4Yvkzkc8hapwQtM11RSVMSNK+mRNpfBavU1skA6I5iK+nTvYKJcA5Dphcjfb4dOzlmEVXiErtQPsu2w07p42Wj9S5Qlj9xZbvCMY1Li6kaoXkhdIAIJTf3q0MvMIa1z4CUTJOopvq4ScPHOLD3nFanwCfUKVTkZq5eXuyybfmCPy9c8NmYiN4QbV5Lq/mNeSQ6tilxX4iCsUFIj0q2gBKVwUfkkr2UTVtVFY6Fon45F8UdSpU4yBHMtIOeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYCP286MB1007.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:9c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17; Tue, 12 Jul 2022 03:21:34 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 03:21:34 +0000 Message-ID: Subject: Re: [PATCH] gdb/csky modify registers list for general_reggroup From: Enze Li To: Jiangshuai Li , gdb-patches@sourceware.org Date: Tue, 12 Jul 2022 11:21:03 +0800 In-Reply-To: <20220712022352.9640-1-jiangshuai_li@c-sky.com> References: <20220712022352.9640-1-jiangshuai_li@c-sky.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 Content-Transfer-Encoding: 7bit X-TMN: [HGwbpHySiXRNBo9qD6qF8yx6I7vW2NvKzU6qhgFFuY5BqD1CYQUuVx2AEDlMFdIMbhwcDT5U/jo=] X-ClientProxiedBy: SG2PR04CA0160.apcprd04.prod.outlook.com (2603:1096:4::22) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <1a38ccb5047f4155b6f8cce42160d13ca88e5577.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f3ce185-b234-49b6-d98d-08da63b59f49 X-MS-TrafficTypeDiagnostic: TYCP286MB1007:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: co1VkeG4kCk56CiuobZlbouyDmTr5LL5ovy4Fr6VbKjqjcEF7QBzG2Bs83V8f96JsvqrNLffmxv7cauBdbjCFiHQsp5yU+4JkpT6RC3Fq22SrjQgQ0m2p96d4c8Uj5T0k+nFf7UDQG3MEVH/w+RnjBSsyySTkJnmfasTpJ8ZthP2x8Y/1d//rlMxk4hs82qyIvoFl6oytEWjw7yVzmWGht1j+l4F0UBO4vXTmHbBtzxKjc7lEOMxFe3tB/Ot1UL2DAaLlRrB182FvdXJ13fQxWf1kQEYOVYVUVEDpjVSyZaadP8Lh2QwLlD0bkvHOBDBFmEC1f5x1bUiHEXoIaqrvUf+6AEs7n1QzXsWFyo3M0hH5wEIlSMvYSrR5316QhqYizt0N5vGIW54VxpskKpm+d1fO5SPDpZMveJclDfgX0DH4z/U6g2qnrFFsVuSOLDzVQX7wI7LS5sM/LK5J6QarrlH91+2p9mvkzDL6V7cGawoDEs2lnsFv8e50fPBt0k22KAi/OfOMfTg7TRlp14zN/7siKKNUzLOLwsPfKNfcAoVR0DBvy9Wi6HrZFCxVAr6AS35DXIfhw7OfQ+2+NnZTXRISmjCBgPAktLogzgeRQVUZXKYKxc7/ZsVZrTUjqipr+pYv3gNu7i81tCIDF7P3bPR//lSmjXGjgfBUy5uyCijY2jdrDOHYXtzfCg4x0dXu/K3rOujbaE/462OqMJQM5webDcvXj5tb9zL740xmv8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHVGejUyR1FMeGQ2TERaSTdSSy9wYkkzSkpsZm5GeEh6Vno4VHEzOG00ZkxU?= =?utf-8?B?ck44MFRmRVhvNU5QTkkxUjRuRi9XU0EvRkFBcUpNc3VRTW1nZksvVXBlcEVk?= =?utf-8?B?cHhCL2s3cHdlcVRpVjQzc2VhWFM4OWlRVGdTdTFQcnY3WDZGRitldnVRWnFT?= =?utf-8?B?eDVwQnAvdGpSdWxTbC9yMmpSdTRJWlVaNU9obUZhY0hqTUZCUUpRNUVjcXVh?= =?utf-8?B?eUdVVHA3UWNsZm5YM1lBKzg3ZmZqazRsY2cwWFVSZnNZS0RBa0t3Y0x2blQy?= =?utf-8?B?d1BzOHBCemFYUmsvNEllSWp1UllvMDdycWxkTUpMNk5SanovY1F4MGxLcmM5?= =?utf-8?B?Ujh2bHJ0cmJZS01OV1BVNWdPTmZ6V0VRSzdsOStPeTBjYkc2eHV4aUJqMjVT?= =?utf-8?B?c1dXeDlsL1FkOTZINlgwQy9yNlRwRHRTZFVPemJycHF0ajg0bDZiaktGUkFU?= =?utf-8?B?Z3MyTi9NTkVWaEU3TlRLbVJNSVk3bVdSVHJWMU5FZkdXb3kxZG4rY29ZTG01?= =?utf-8?B?MVRkdVVEWjNsOFdQUVhkVU5PdDdTUlF2ZWRLcjhnVGRYV1YwRy9aUWlYZURK?= =?utf-8?B?aHRxSjRnTXFjMk11NnZJSWdHUDRuTWw4dDd0b3M0ZUtyQld3dlJuajVTdzZp?= =?utf-8?B?SDk3UXhJdzhKeVVqdk1CdnlPcDhORVpqRWgxdDJuekx1WHl5dUNmZTZBUjQv?= =?utf-8?B?dlRwZUEvc2dmQTBFeFVNZ2FOcktLdkw5cWQ3RFVXSnNmNERHZW9qckN1ejZO?= =?utf-8?B?UnNLdnhhOFVJY0RDT3VtOFRvTDBDMmhRMXlEQ3JHY2RQTlRMUjhWaitLZVpE?= =?utf-8?B?cXlDSEE5aS9tRFVZaThNY1g3eUhtNW9XQ2NwSXEzM3BuSDJhUW5TL2FpbTN5?= =?utf-8?B?R1p1d00zbzBzeGN3NThVZG54TGxWQk1BdzU5QVhERE1adUpYR2dOb1YyZERO?= =?utf-8?B?MU5EZWd5RmdXdXhvSjd6U2hTcHVqdnZPdG9lY0RSZmptUUtzRjdFZmtzS0ZB?= =?utf-8?B?ZENoM0JLVTFuZVNyOGVkRVNDUlhteWtSRTI2V1krdzh1Yms4cmZHdThVNXFs?= =?utf-8?B?YlEzemRnbm9tajhuSDlCV2NlK084TUsvK201eSsvUm9oWk14NU83QTNKWk1G?= =?utf-8?B?QWY1TndOYVJFZnVYTnF2ZmdnS2pqQ3A3dEhsLzF3U0Fqekd3VzJQdGFzQi9V?= =?utf-8?B?b3pqay9EUzNHTXF6ODZBTnhKRjIrZWJ2ZjNaaWxEaFNpNUtickdGbFBUOUtD?= =?utf-8?B?by9FRlBXN1VzMTRsaEJsdnIrTk1lcUM2L2xuU0RXeHAvRG9sM1UzNm45aEFZ?= =?utf-8?B?QmRwelRQdThkU3B4aS8yV1pLNzBDMlJVNDFKSG50eEF1YnQ4MGFNbTNrRldm?= =?utf-8?B?UkJoYmE1elVack5tVG81MWxKbVhwK3RLdTdSNXJ5YU9LbWIxd3hsUUg3Zldk?= =?utf-8?B?ZjRGMVhuWERGWlFIWW13S0Ric3RsRXBaczAyait5aTVscWVVc1JKNFQwcGFC?= =?utf-8?B?THlKTlJ3dFZnMDJpWktVY1ZENEdWVDBWWDBjNmJvZThtMkVaNFZTNHVDTGFH?= =?utf-8?B?TjMzUEsxcFZLK0Vzc0MvTFh2QzRLdERFZkdESmUwUGJJdU5sR3JuRkMxdFBs?= =?utf-8?B?QTl4WUd5MmVwTFFCSDRKMGtnNFZURTlObTAxVUdvVllBNGxGSXlRVzd3bktV?= =?utf-8?B?M3lOMlVPVERqczA5ZlZTa0cveUxPL1pQUWVadHhSbThLZHVIcStsRkRWd0hi?= =?utf-8?B?UGdyYVNkVHlRTnBscFB6eHJ5azA2cEhoNGRtMitoM2dmdlhEejFmQy94d0dj?= =?utf-8?B?WWVLQXJLZHBRbVFRWndNUT09?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5f3ce185-b234-49b6-d98d-08da63b59f49 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 03:21:34.1649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1007 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 03:21:40 -0000 Hi Jiangshuai, Thanks for doing this. I found some minor nits with the coding style. Pls see below. On Tue, 2022-07-12 at 10:23 +0800, Jiangshuai Li wrote: > there are two modification points here: ^^^^^ there -> There > 1. for the debugging of csky architecture, after executing "info > register", > we hope to print out GPRs, PC and the registers related to > exceptions > 2. with tdesc-xml, users can view the register groups described in > XML > --- > gdb/csky-tdep.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c > index 502b01e33e1..fcdb865eb87 100644 > --- a/gdb/csky-tdep.c > +++ b/gdb/csky-tdep.c > @@ -2518,7 +2518,11 @@ csky_register_reggroup_p (struct gdbarch > *gdbarch, int regnum, > if (reggroup == save_reggroup || reggroup == restore_reggroup) > return raw_p; > > - if (((regnum >= CSKY_R0_REGNUM) && (regnum <= CSKY_R0_REGNUM + > 31)) > + if ((((regnum >= CSKY_R0_REGNUM) && (regnum <= CSKY_R0_REGNUM + > 31)) > + || (regnum == CSKY_PC_REGNUM) > + || (regnum == CSKY_EPC_REGNUM) > + || (regnum == CSKY_CR0_REGNUM) > + || (regnum == CSKY_EPSR_REGNUM)) > && (reggroup == general_reggroup)) > return 1; > > @@ -2548,6 +2552,10 @@ csky_register_reggroup_p (struct gdbarch > *gdbarch, int regnum, > && (reggroup == fr_reggroup)) > return 6; > > + if (tdesc_has_registers (gdbarch_target_desc (gdbarch))) > + if (tdesc_register_in_reggroup_p (gdbarch, regnum, reggroup) > > 0) > + return 7; > + Accounting to the GDB C/C++ coding standards (See here[1]), "Any two or more lines in code should be wrapped in braces". I think this part should be like this: ``` if (tdesc_has_registers (gdbarch_target_desc (gdbarch))) { if (tdesc_register_in_reggroup_p (gdbarch, regnum, reggroup) > 0) return 7; } ``` [1] https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Whitespaces Thanks, Enze > return 0; > } > > @@ -3020,6 +3028,8 @@ csky_gdbarch_init (struct gdbarch_info info, > struct gdbarch_list *arches) > set_gdbarch_num_regs (gdbarch, (num_regs + 1)); > tdesc_use_registers (gdbarch, info.target_desc, std::move > (tdesc_data)); > set_gdbarch_register_type (gdbarch, csky_register_type); > + set_gdbarch_register_reggroup_p (gdbarch, > + csky_register_reggroup_p); > } > > if (tdep->fv_pseudo_registers_count) }