From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2062.outbound.protection.outlook.com [40.92.99.62]) by sourceware.org (Postfix) with ESMTPS id C00C0388B6A1 for ; Wed, 3 Aug 2022 12:31:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C00C0388B6A1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5VJAzPQC4ovcJcLCkDrNp/CGitRH0ciXwsbbqAIvVmHf7eyTnjDsnCRq7FAfz5MZsARbTHvJOu3a1vNYGipm76xcsk7saHD4lWKntQOVhNOoOaMhfuQf1fLmRmAwLBth9sIadtjsd6+piJkpHizI70bHq0B1SCxzOH6C/3PqJ6m5E2pktY+0GDwqlF7V62XQsu5PlM2Tt0nxnJa9lNs4xFpxulXTxlD1hoDMrYx+Mo/qD4lFxASrilBmeb6uISoxiK6NuJ0iT+nzv0hDfep+ZsCO/KbmWvZnnDVPgGKGiKbdhmZgX80I7CdZDPZpX11dEiNmUCewrbD/DT+BnhJOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2kRoYGHqscuL3onrMBgAOwUoF0aKZASeDO66Kmgjl8k=; b=AUYBmiyjBuF5QMAkXLMrTHMG9L0wE8RZsqHq963WYVOgMBHNQO/kHwxlRL46VIFQxtsfO/FEj8JCzDzBUzj6KEqcNxn/yUCX4b9BJrS9vwKedodJ/Eul2MH/a3vVFEWQdZKHTnMC93x/LuLevYcTR+m13IjkViDGj09kSuyt3CA9vmup0Z6alzTHcgo0ukd4qqVax6hviLomNxbRecAx3fauCXhC0zxKmdqhVxJ5x7Uh2OnLd5e4WKg1cFTfAYTq4Sdxy7fFUOxQQfFsS5NslOC3Y07MRP27damjUeto2tPBsH9/ajwooZmYIi1oss4ko7IugM1s/CsTc6wOHUBv9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYWP286MB2970.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.14; Wed, 3 Aug 2022 12:31:04 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5504.014; Wed, 3 Aug 2022 12:31:04 +0000 Message-ID: Subject: Re: [PATCH v2] gdb/amd64: clean up unused variable From: Enze Li To: John Baldwin , gdb-patches@sourceware.org Cc: enze.li@gmx.com Date: Wed, 03 Aug 2022 20:30:59 +0800 In-Reply-To: <2a2ccf3e-503f-96e8-8b8b-18a1b98fb93c@FreeBSD.org> References: <2a2ccf3e-503f-96e8-8b8b-18a1b98fb93c@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 X-TMN: [ioSUmnQQfPP5gEhkec0uU9JpxkObfM6W] X-ClientProxiedBy: SG2PR01CA0148.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::28) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <6b4c1fdc65fd0316bb54a5c07f1e6a91951aaa2a.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c35a291e-cd14-46fd-450f-08da754c0817 X-MS-TrafficTypeDiagnostic: TYWP286MB2970:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g7rzwpPPZBkfh+BHESkDl1T1+CX5Vfo92ovnICz56mpGWGETEzP/0CoYKW+xRHSiwyydpezV5JVzSQB65ThiXI7ZoUE5CSVpz3wtnzITuoQOjAb+KIousgm7KS3JM7J8XiAVYyy2cRRNi9KeusC8sLln3F1l2lBbjxdDeS6TbhjlVaSDYn/ozTvBNPO62wadkE5jUG5KZwV0w/7lr5zkoEM2AAeGaPm1wpEPU8mVJ6bO7eZZWga7we00uJ8+Qc3l/rVt0OjY4Le8WMocWdvxmwVQzb9i9q3d3K9zCxoWFthaFFaheoaMmG0JyVXAUbCJNqFV+06qGRDzTpzAZ86TWRJZBBe7jaxzpv3qj3JF4Oa9B3wIAU+KUfq5g0L0Ly6Cp3KZVa7oQXhN+NzydBSpI85mhNMV5FcgLRFYANzeqr7fKw61wERPl7IcROaLUevu2xxxy31aMm76kL66IXHLXCSQX6H74vlVGHzWy5cUFu3nBiLATnBhGD4MEIEo/hVexIIO94crEw9LcwiEmMqbfOqjHWXsC7o8UXBh5nwSKiHjN3M1veIKSJe96p8SejL2ILMyvf3+55vBBDVJk9BeAAIx+MqvKvx8Jj0y6vmMXHh3NDgXvXf4cNhoBqNMJLhAJARI3IN+C22q4hQQMVcJrhOzCi/wktekZehelmXsCyJCVdsuN9egQX/oA26XGyW2 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnFEaFJlYWhFWHhMK1cvc2RqYjVDVWlzcWN2VGNXWUhtNDJHZkk3WDZkWk9k?= =?utf-8?B?ZHorWVpvYzFYVUJ0YnBWVVVoNkdMOHBSaFBnMHUzREpSUUd1bUU1NWFiUi96?= =?utf-8?B?TkhSMjBtcHhZUllJTjJFM05LZlFwdldicnVvdWRWWVFPRjRmaU1XUm1IUEpq?= =?utf-8?B?RWUxM2JNMnZjSU1hRWRNL2VVdjBMVUZtTnVWVUZEYWtueW10U3N2MGRUbGxr?= =?utf-8?B?QWswSDZrb1N4RDdFYzljMTM4eVl4UG1TOWJaVFJYUDhpQWVzc1BMTUhQendB?= =?utf-8?B?UExTQ1oxOHE5UU9FWlF5N0pNRXY3T21xZTZyODl0aEUvZDJEV1gxRlcvcysz?= =?utf-8?B?T3dVRUN6SGxkcTNVdWlzTlFmWStSUkRYdFB0MXFWNXRMQU5YNTVVc3VXck1C?= =?utf-8?B?V0dHOFNvWldZOWNmMWx0a2tuTURxQStjcnBRb2NERDNYTHJzT3o5N0RxQlFB?= =?utf-8?B?SjZ3MGYrelBLaG1aM056QjBBdHhQU0s2cVBVZXMwRTBYUTdnUXVKMnVvYzJE?= =?utf-8?B?V0daWC9PT3k5T3NYQU9ZS2RibHZtOXNQSnR3MXNhUDE5NWtFLzdLQko1ZXBz?= =?utf-8?B?RERhcjNaK0VGMGMweXJlQTNkUW1ReTdhMzlEMStxdWIvM2JhTm4vcmdvT3ZJ?= =?utf-8?B?NWpuVGlJTzY3YzNXczBRMTV6cWFWK0IxSytVQkExTzE3ZDllbGxqOGdXSkgr?= =?utf-8?B?eFc2UG9qMjFRV1ZoVjRvQld1R3RUZ3V4TW1ZV3Rlb2JUSGJGKzVUVzVQc2VZ?= =?utf-8?B?Y0grU3VpZ1Z4ZDIwQTAwRTgwUWUxZUlWQTcrYXEyM2FaTTh6REU4YXRucHVI?= =?utf-8?B?T1lsamExMU9wZ2JsaGs3L0EvbXAweWZTSTdHLzZLbXhzS205dExYUW1nZVhY?= =?utf-8?B?dFQ3OTU3aDd3ZHMvVGtZRWpuUHBIT2tTclRUMnBYcThVdHVCOGo1UURvU0Zv?= =?utf-8?B?VnA4V1NRWUtGVHNEZHlYQU90aHJ3akRpemZ1UExoc29hbUllNW8xbE1nRUZ0?= =?utf-8?B?T2p1TWdWMkpwa3JTaUo5WkpBSWRhaXEvOUlpTTJ5WkNib2RGK3R3Z0ZuTlNV?= =?utf-8?B?SWltSUpSaWp6SllwREpYLy9ZVnVOcXJ4TmZ2TGl3LzhyVnc2a1hkTG9UODFQ?= =?utf-8?B?eCtYczF1cHRqNU1QRzNpbm1hcnhqREhtUjhuandBMUNQUXdUZkt0RjJUUVRl?= =?utf-8?B?bjY1QU1kRjYvaitFdVpFc2xKVmlXWmFSRVNqeUdSSW5KOEs1bnpnTjArVGhs?= =?utf-8?B?SkdjOFRlVVlmZ1o3ZW5xNmFkanF1ZkU4YXpLckxEeFB3SHhjV3BjUk5ITElk?= =?utf-8?B?Q01pSHRRUVhqU3g0cjBDMExadi9Od0M2WTYwR2dIRDI0SWdNNDF3cW4wUUs0?= =?utf-8?B?WmkrUGJpbytWTUlscWdBVDh3c2tkVVI4UzBralJoSDcvUjJQVlVJSHRrbU95?= =?utf-8?B?VW5ZOFZrY0ROZWZsRDJ2elhUdUluNEhLSlFtMWhpNlQrd21WQzhKWC85V1dI?= =?utf-8?B?MUhoNDJLMGtqaVc0SE1oSW5kOHpJSDFBN3QyWEF4K0xpdElCL0IrTGNob00r?= =?utf-8?B?N2xtNEVVdXJGUkswNi9Sa2p6RGlJQTRJOVFzeTB4MXRoY2d1TklQSm1STnhl?= =?utf-8?B?VllpU3d2WHpmbW9vb1pWR0d2L2lldC9BYkRxaEcwM1FpaDRNNWFQYVcrTkRC?= =?utf-8?B?MUdzVS9PRXFSSmVHVy9CVnBoM1JCQjhhZnBWK1ozSVp5RTBUdHZBYWRBPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: c35a291e-cd14-46fd-450f-08da754c0817 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 12:31:04.3802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2970 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 12:31:14 -0000 On Tue, 2022-08-02 at 08:44 -0700, John Baldwin wrote: > On 8/1/22 3:23 PM, Enze Li wrote: > > When building with clang 15, I got this, > >=20 > > =C2=A0=C2=A0 CXX=C2=A0=C2=A0=C2=A0 amd64-tdep.o > > amd64-tdep.c:1410:13: error: variable 'insn' set but not used[- > > Werror,-Wunused-but-set-variable] > > =C2=A0=C2=A0=C2=A0=C2=A0 gdb_byte *insn =3D insn_details->raw_insn + mo= drm_offset; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > > 1 error generated. > >=20 > > The function that uses this variable has been removed in this > > commit, >=20 > LGTM, and I think this is obvious enough you can push it. >=20 Thanks, John. Pushed. Enze