From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2096.outbound.protection.outlook.com [40.92.98.96]) by sourceware.org (Postfix) with ESMTPS id BA8ED3858280 for ; Sat, 16 Jul 2022 12:38:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA8ED3858280 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAhl38llWq2ZNxP6iXVfPAMEdRNLzR5b3fzRXLHgWYOjuXYCjc9883T5gjTWDjg7BVS/IgzV4s0jWyHWocDEDW+Zgu4E8Q+N49hnHe9pojmBy9QyoH/f2J9IKAQy0woyfXmwpU9VhQMIxbbnb8b0zw2C5mAJLOybOhcN/Mepwhv/zDc21dRAKc3E5Sp99dOGvNvb13alxyuzzjiHLBNJT6N1GUVvoImEOod26JaMWMHOnpBt3A1QDKSwJxOyhvHae5b55Os6EEzCvnA/N/O6ANunJV9ztRrAAsQtauGTBO1tS6+jc849VgznrXMnEsByel8ic8SlO6BgW7a+zgRluA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bGbge80eDcW/f2h+07ZKhCRZB2CVbk2DSI2b7Y/tI7c=; b=WwDmaPJSHYFMBKYZzxypm9ric4T8kBjuIrxIeyEXWZVdMwqv8Hrxnj1VnFmbADFMlH6QnvRsFfjXX68FtiQXH6mmghGFN/z91ukxKmwKuDg24j/B1Wy2X+9xjgBh8gV67j/5O04VC2TeebupUz8YKYQmDHAdurFRLywywcNzbvBzh2wTmNYs+kDR4YmoTHY6d5BDsy9DGt8mMxhlNWgiQaDKVncwtNkpp824Sutzbz3ZBfR9kBqxmXqcNAND3JdoOd8pMaL0zLHjjo9EmOL6xEEycZL/9T0Kge8eTkhz0/kT+j7EegdD4K/oXaSoxSdh1cyaN/G8eu73WTnxBNLlJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OSYP286MB0006.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:86::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Sat, 16 Jul 2022 12:38:51 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%8]) with mapi id 15.20.5438.021; Sat, 16 Jul 2022 12:38:51 +0000 Message-ID: Subject: Re: [PATCH] [PATCH] [gdb] adds `` to list of includes From: Enze Li To: Simon Marchi , Manoj Gupta Cc: Christopher Di Bella , gdb-patches@sourceware.org Date: Sat, 16 Jul 2022 20:38:46 +0800 In-Reply-To: <9d0e7369-7ead-7ad7-c65c-604fe4ea0a57@simark.ca> References: <20220628010427.1856503-1-cjdb@google.com> <9d0e7369-7ead-7ad7-c65c-604fe4ea0a57@simark.ca> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 X-TMN: [/OTAszrHDvGnkbJc4wRSuO/kxmlxVIes] X-ClientProxiedBy: SG2PR03CA0094.apcprd03.prod.outlook.com (2603:1096:4:7c::22) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <36fe8911d72c4416b1295c66e3d2e5884aa3fff6.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb3127d0-d889-4872-361d-08da6728231d X-MS-TrafficTypeDiagnostic: OSYP286MB0006:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P4O1SYRQ87gUjnF+EaJhQDxq+J7Cbtq+SQ18FwFXa9voV50O3IT8pbQiMikHM1eLkLbUOHB92pF8X3OgvOGhD8nxmTSF3oFxaYVF3Uxbsc23hfZIMvIDbkguLRHE3OuOX9E2Oa51qLn5UcfXHNITOFoTq9qhu6pV8rcF/E97z+N4OIwRhsfVRQ5aAyKtsXK0YVm2uRK/mwDVJvw6XpOXGH2Ac+n+cFJecu0f4qQNYBM6b5NnUM1ruK5CuEj9ORLjW9KOAPmt0pAyCARaSFE7hdvUGQrzbD7nPhKWFZLr6GMRZH6DK1gHox9iN2tavBqZUEIDQBBVhcqmIyjQj2xsX3bWAHd7Xx1XjyPZ+HgKxzelnBTBxyZcGY4LuIzN1+if0e1rSz3JwUlt6uooi8neqTi7Je6Sqe36v4RT0ht2K2XptvZZwlZGSHOF0xdATRfFsO25dKSjkAmxu0Sx/wOgy3n26ARdgT2z7RipFm3ttA2CNSfeU0G4duZY6/TsMzR3jZQU/mVQqF1IaKiTYui3SaKWmYOKykrBw4zG9qLaf5VP93bTiD13UT30s+qvSzdcajAE+fdu+/MZ14te08MkyTTp28A2M/UvC2GhH6Nx/rWTw71gHxoUr6hd42PGO7vQ76PcnB9Cw1dQQfNBWnKTOdYdHR+yEs/qC5iggEtJmJ/78lei7CR2HfnpGRfTqtS63/+rRL1bYxlSkYFZ2KOwCg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVp5VDBXMllQdnZacGZhWk5haXE3VTFDcVZzMGFKMU5IZG1iYzVmZ2w1d3FN?= =?utf-8?B?OWNmVkovQkFjeWZyWDh0eXFKTEtJckZBQWxJM2o3VURXa1JBUHpoWmE0a2Yv?= =?utf-8?B?bDJrU21wUVRPSnJCOGttVUtkZnQzRTJhSExlMXZQemx2akVxWm50SU9qTGpG?= =?utf-8?B?T0Z5SDB2Y2ZZcEoxNGh1RkJJdGg5RHFRTnRsbUVmNW9tQnl0OTdxMXh4SWpu?= =?utf-8?B?ZEwzRjJIUWVubmY0c09rUUlaWHJ4Q3pmNisyL2t2aU1TTEFFeTJVZmM1SkhU?= =?utf-8?B?alNpektJbWVDeXhBa0NqSkFRa2lzMUE2ZVA3dzlOeU5WSGV1ME1VaU5pQnhC?= =?utf-8?B?cTh2cEhlRm16UlBqZkVXR3Y4TXF2RXRvQ3RGcWdQRTJKbi9LSVRNWmZ6SXgx?= =?utf-8?B?VjRFejVRUWxzOEtFTXpsVHBxVWgzRWpiZWNJY1pna2ZJd3c2WC9aa3lFclpk?= =?utf-8?B?RDd2dkR5NndqWXJ2U3lwMnBVblZSZzZrYVorSFVEWGs0azdXWVdzV2pJQTV1?= =?utf-8?B?OXA5UkcyQUNaelJIODE1ZWZkWThONzB1R2hRb05LTGdvS0cvV0l1RG00Y2dZ?= =?utf-8?B?UXBnZlZ2MFdtanp3SkJxN0owWUkrR0tYUGhodkdPRTZldTluU05DK2krb0I5?= =?utf-8?B?VlhGQTB3VmthNFk4dFpwejhrZGpwdzdkOGxxWkxBSURvcUJ6a0g5cC9zRzNB?= =?utf-8?B?ZDVPMUJEMzJlVXZ5bEhUZnd4Rm9COXl2SnBUVVAvSzZXdGRpRnBIaHV6amRJ?= =?utf-8?B?Q3o4R2trdEUyMlVkMkphSHZOak45dkMyM2d5NDI0MjhNK0dIblJ1eUZpYUZK?= =?utf-8?B?cURnZVR6STJrelZPTHNsVHdEN0UxY2lZekVyNlhrcHZjYjd6cmxlaTRWWEJR?= =?utf-8?B?TFQ2M0EzMk4yTDlMdElZZ0JHSGM0UmFSZlFiV3E3ZkQ1YTY1WEhYUUx5NFJ4?= =?utf-8?B?MFR0alZJemtkcEttR1FXWDQ3bGZvQkgycCtoTW00K1owMk82VnZNZXVoMVFr?= =?utf-8?B?T1l5aUJLRXVzWkEwZFRVTFBtR1hab3FtdGNEL3NsbUg1KytCblJOTHBwbEli?= =?utf-8?B?RGlxQ3hoVjNUY1YrQWFEN29xMGgvM2VqcGhURmFveFRYNzM0dUJOSHRtMS9B?= =?utf-8?B?MGxLZ051ZFBTRE9kYS90WVk1d2xuTFJvd2FqbEJvanRRMllWZTZqRUYxcnpo?= =?utf-8?B?RlJtRElzQUVONEJIRmk0TG1kaFF0SUVrZTJibjBOeFN0Mnl3Nkt0cFErN1Va?= =?utf-8?B?QUxEK1FNTVBqeVhEZWtIOHZGRzU1eCtleDJzRGhnc0duMkNObXJXQjJOYjFH?= =?utf-8?B?WWV0OHF4UDNVNC8zTFFRZTRmOGtoVWlDejJQMVg1VXhrRFVBSWpreVhCZmxU?= =?utf-8?B?WkkvV1duVFdFQ1VnU1lzVWhJNzV0MnRvZW1tVi9ZNDVQMERWSXhYdHh3UVpZ?= =?utf-8?B?c09BZGhpTGlmS0E4bWx6TnVTYis1T3hyOXJNUkRHVjhwNGd0L0orcE9ZR1o0?= =?utf-8?B?YUtsaWY3SHVna3MrZHAvVnAvZDFNRjJGdlo0QWh3Mm41REtFWWtwLzZRZWxN?= =?utf-8?B?QzBHNVN6ZVZUZkdVdHpWU3hDR0JkcFRpSDNmcjYwd0xjSEIyTnRPNDA3eStG?= =?utf-8?B?SFFFeFBhSlY1RmtzN1lKWDhBNDU4b0pFQUwwdjUrNCtleUpONW4rMllMZzl3?= =?utf-8?B?OTJUbFN0aStSZ1F0L0NXQzdIZEpOS2dJYzdETkFwemZaaUtCNUY2RENRPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: bb3127d0-d889-4872-361d-08da6728231d X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2022 12:38:51.5085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSYP286MB0006 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jul 2022 12:38:57 -0000 On Sun, 2022-07-10 at 14:52 -0400, Simon Marchi wrote: > On 2022-07-09 04:54, Enze Li via Gdb-patches wrote: > > Hi Manoj, > >=20 > > On Fri, 2022-07-08 at 22:57 -0700, Manoj Gupta wrote: > > > I work on ChromeOS and can provide answers to this. > > >=20 > > > does not include provide std::back_inserter as per C++ > > > spec. > > > It is provided by [1]. > > > The fact that it worked so far is just an accident that libc++ > > > and > > > libstdc++ were including this > > > header with . > > > With libc++, it is no longer true. See commit "[libc++] Removes > > > unneeded includes." in libc++ [2]. > > > It is therefore not surprising that gdb fails to build.=20 > >=20 > > Thank you for the detailed explanation.=C2=A0 It seems that we need to > > manually compile and install the libc++ from upstream before we can > > reproduce this issue. >=20 > This is trivial enough that it's not really necessary to reproduce to > get convinced that such a change would be good.=C2=A0 The file uses > back_inserter -> C++ says that back_inserter is provided by > > -> make the file include .=C2=A0 This has no real change of > breaking anything. Indeed, reproduction is not necessary. I was just curious about building gdb with libc++. I hope my interruptions didn't interfere with the progress of reviewing the patch. Best Regards, Enze >=20 > Simon