From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2089.outbound.protection.outlook.com [40.92.99.89]) by sourceware.org (Postfix) with ESMTPS id A52D53858D1E for ; Sat, 9 Sep 2023 13:51:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A52D53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSGilmQ1AkhLkRN0E6w7HbtKBjxeQORxyUBC4nMHQJevwlNPsFYViwJHTf/tSiy+GprLEcLGYvmRnMkoS9kkyFoC2uLYFVOVEUVTiQbl7K3q3T7ef30UVBqlS/pwjrk4S8io6vETDZXqrR9F01yJrFD+fbWCbuEx10ycnlqWsr0LtmH+kmFHfI74y/cQQ9OEOCsg4ycM7fIXiTR7w0sl2Dmp7VYwGus7Di+cbBp6w47BdkFQMtwVoShUrrrM1+QCfNPvgPBcgYnjXoWc+E4v+eAunPSao5RqfLFUpe1y9dSMdukUnr6IBy9iUvavQr1fHnTvb9I4ty/9Z4OxtZtCdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WS42klYxklucwp9TRIK33RYaofdPu99dPs7+lDz2jGg=; b=aUcFIL6ERkQ3e/gKN15OEGubYtR4m5wXqWkY305QXnOawViYWC1QiUSCmBdtLh6o2yj42DwMg0GJZEWgNRmx6MtRpjS5yE1ZpxNS00CLcbjD93PSPVpmxTzq3k6saJ5njipd4+5fkHWseM9nZ7yGdoa0d1VfyGG18NdBGzWeJpU21f4DfTJXVOGcihy23wmWaKkjJ5qDZ7/ZcIbV9039a5r9bEppNlo00HiDhUHQYkJSvf4tvlx4buxjTPLyCFquPkOWP2480v6kZ39HFCikyDLjlqzd4yEO4kzpJyVUT3chDxzMuvH4DAy4d6eBK6QTwutF0Yc7RxMOYO497+9LCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WS42klYxklucwp9TRIK33RYaofdPu99dPs7+lDz2jGg=; b=oLMrnyqVvFlLKTVJyk75DCRohG7n8zStZKFb0cDd3jmsenP97Y3myb+8yPSIkyIlmBXPIFq8nNId8CYzZFh3Frlmig4/sOtV/s7rls2zKB3JvP/0pNMQW5ziwe+j5mcYlCBRF7Gn3pPka4H3QECdtRsIHhHfWQCq8V6KljfFeZBOnUMNXBJo3j3qlCeIHcWabOE3JL7T6mKQ7VzjtTO5Drl8EuIm62jF9d8NH1TvzQ/1ptiARgpOvb1ZOb4WJBPDrYqSWAfkpKSW3o12hMMSXQFqhC7khjXfvCkeAw32iCgobzGqYj2jE1bYmc66v5+iaGQ45ry/qq8Jv5eoAbx6wg== Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OS3P286MB3387.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:214::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.12; Sat, 9 Sep 2023 13:51:27 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::72d7:4747:7f49:f811]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::72d7:4747:7f49:f811%7]) with mapi id 15.20.6792.009; Sat, 9 Sep 2023 13:51:27 +0000 From: Enze Li To: gdb-patches@sourceware.org Cc: jhb@FreeBSD.org, enze.li@gmx.com Subject: [PATCH] fbsd-nat: Pacify gcc with no functional changes Date: Sat, 9 Sep 2023 21:50:51 +0800 Message-ID: X-Mailer: git-send-email 2.42.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [Ey3H5PywoAtVDPOAgNKUsNXhDPjP+XOrMh2n5qiJH+E=] X-ClientProxiedBy: SL2P216CA0208.KORP216.PROD.OUTLOOK.COM (2603:1096:101:19::12) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20230909135051.5494-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|OS3P286MB3387:EE_ X-MS-Office365-Filtering-Correlation-Id: 5880bfca-cf9f-46ba-f3d8-08dbb13bdcbe X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l8s5vEObso1qj7FdsC5XgpIXyua0MQccze0vtMZKjg9lKgJKiKOD3aysFneqnwWyzXdfMwz1f7lyMBPkrnF01nrTHA9wZ8Ss43PYcqRgVIYtuuYdGI+MVkQfNldHlx7TCdwjGk9SLTjob+8bwj0il2D5Op5hci/vwVF69KJVjV/tkNtoVKOaK66gkS+sZ8ybvV538eGGyMG367caHQvKVNikwSdXohCzfUw+PnQTpc8r3aVIyVC8bgSm9Lb8Pk4u9T/dyaUcuzOs+DJ0q5AMxl2Vkb57MSIl1SGK6b9j1IZflBvREEJI43sOgqG8B8tAtAdX7Xt/plLgnzA0CHPMGabxVvi/Al6LXb9vKRRIR/mvZ9CeoMMbqs0PsTp0N+00E1ag/7t1pJof2efSYCIpKs8jTB2y4WAlCfFRoHPV8C9ks6PqrtjXeLSgSSOIHjnNCNyOkUGg3KntacYwxweUE2l61sFANki40esUlb0mHPBBVzvoySukbwR8YiTBxZgeAsRpttTgSJgicrTwac7aBPXeH5r4RuWtUE08kUvNqvtXh7AcGkw2X6SIpGHjOP5j X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f1GOPrcPe5dF/8/krDlxSKwlZaFl49I1awb/mZ+WlXLBuC+UpQhQVKCr/1Lt?= =?us-ascii?Q?aygJv0D0+iwZ746zxvyP0sWzghlO97grt5nJIkhiOfguQjAetfeh4zFSYdT2?= =?us-ascii?Q?rq5rHwIQaGrOu7B/3mf6DEIBQiqR7Ym11o9/4hP2PZQAOTjaVeSi+3Se7Gaq?= =?us-ascii?Q?S6N9spHZK3KKh4ptjHD5+fhRK/uOmoQ2wi8Ne6CwKps6eDkYdc32MYR0bnSU?= =?us-ascii?Q?T6f7CIEGMZgulgEIFXO0Zzx4rA8sUm3OD/yFbu3v26MU8dg/mKslXtjIVRel?= =?us-ascii?Q?PF1h2vCSciBA5gmrMPcHmN2TGL8A0HNURRg1OZYLmQ8bfG1UkE+x6RqM4/nx?= =?us-ascii?Q?ieJD75mTw+OkYYpS+6VNUtLwben9Ri3YqHJE2gcqUrYTt35jxAnPzDkPvbCl?= =?us-ascii?Q?O9m8EPWJYZeSFd3dNxDBa+E5GyhO5WhUPgmbUmwqB5eSQBMgKvfG9RQ2MneH?= =?us-ascii?Q?6XJzzM7OSYFIUjnSaKC4aWDLRXOT5spOU3pQ0fzuc7Vvga5pBY9XRw/NoHQw?= =?us-ascii?Q?rZPeqrkDJ1HMxKG5CT4ncVn8vZ02vmH102fzvRWFxVXJ/3R61reLrgOTIDZy?= =?us-ascii?Q?o+djBddTN2clnCoEQtjSxp4w1vHMZRWHfF+G+lVIpbx6hDr0/V3cQMnV4qAz?= =?us-ascii?Q?6RQmrg89FnH65ykQeY4lu44kgnRewdQ19swsoA/E0VY+fo8z8b+VpPbknzim?= =?us-ascii?Q?D7pbDwpRKhehleM2gTr6guV0ez38VPoHW4Hb7PCAKz2uu+yoUIYGuoeetqGz?= =?us-ascii?Q?Fxf5IXr0lKWEdj7kPWp/1qjEhy6jOZi405ho+n5aH/BeBg0v2noyYW55BCxC?= =?us-ascii?Q?hZp+sixVIenhqLEcPPvbJkObyVb534UMVFceIPqi8UTzl5UrPJJR871Fbq2G?= =?us-ascii?Q?WRy9cK3H4Rp+eHQXnl+tNSvHsd9tY5nyf64SiXbDIInQNmytlo4GbaCMpKfo?= =?us-ascii?Q?2qSdfwRpLH5r50YtCV2FHeRYQWdzpGtdx7oxTavSn7P4o/lec624VTNNk2YN?= =?us-ascii?Q?vW078YUVFGBXQKN+mXtX97HrOkfSBe9OyG9p8QiSJRrDjRGg+ye7qEGf90l8?= =?us-ascii?Q?NeCA5OO5EKGl7gT8oZczj6Pw5T5EAqbOr7+M9A6jMrQiTVGOH4wmqQ+36h89?= =?us-ascii?Q?rZtWvkktO9BwMhsHKfq7JAnU4OfyfJFPkrA1LU40EeQDdRShqxu7YVlFK4KN?= =?us-ascii?Q?CQunipKFcbR9gWMhKWDWwYdKNGm/OLMYPfGzyQ=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5880bfca-cf9f-46ba-f3d8-08dbb13bdcbe X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2023 13:51:27.1378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB3387 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I see these errors on FreeBSD/aarch64 when using gcc 12 without passing --disable-werror. ===================================================================== CXX fbsd-nat.o fbsd-nat.c: In member function 'void fbsd_nat_target::resume_one_process(ptid_t, int, gdb_signal)': fbsd-nat.c:1208:11: error: unused variable 'request' [-Werror=unused-variable] 1208 | int request; | ^~~~~~~ fbsd-nat.c: In member function 'virtual ptid_t fbsd_nat_target::wait(ptid_t, target_waitstatus*, target_wait_flags)': fbsd-nat.c:1726:22: error: declaration of 'inf' shadows a previous local [-Werror=shadow=compatible-local] 1726 | for (inferior *inf : all_non_exited_inferiors (this)) | ^~~ fbsd-nat.c:1697:17: note: shadowed declaration is here 1697 | inferior *inf = find_inferior_ptid (this, wptid); | ^~~ fbsd-nat.c: In member function 'virtual void fbsd_nat_target::detach(inferior*, int)': fbsd-nat.c:2044:18: error: variable 'wptid' set but not used [-Werror=unused-but-set-variable] 2044 | ptid_t wptid = wait_1 (ptid, &ws, 0); | ^~~~~ cc1plus: all warnings being treated as errors ===================================================================== This patch includes the following non-functional changes, 1. Remove unused variable "request". 2. Rename inf to inf_p to avoid shadowed declaration warnings. 3. Set wptid to null_ptid when USE_SIGTRAP_SIGINFO is not defined. Tested on FreeBSD/aarch64 by rebuilding. --- gdb/fbsd-nat.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c index 0ee3bccb5ef..af416557504 100644 --- a/gdb/fbsd-nat.c +++ b/gdb/fbsd-nat.c @@ -1205,8 +1205,6 @@ fbsd_nat_target::resume_one_process (ptid_t ptid, int step, for (thread_info *tp : inf->non_exited_threads ()) { - int request; - /* If ptid is a specific LWP, suspend all other LWPs in the process, otherwise resume all LWPs in the process.. */ if (!ptid.lwp_p() || tp->ptid.lwp () == ptid.lwp ()) @@ -1694,9 +1692,9 @@ fbsd_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus, || ourstatus->kind () == TARGET_WAITKIND_NO_RESUMED) break; - inferior *inf = find_inferior_ptid (this, wptid); - gdb_assert (inf != nullptr); - fbsd_inferior *fbsd_inf = get_fbsd_inferior (inf); + inferior *inf_p = find_inferior_ptid (this, wptid); + gdb_assert (inf_p != nullptr); + fbsd_inferior *fbsd_inf = get_fbsd_inferior (inf_p); gdb_assert (fbsd_inf != nullptr); gdb_assert (fbsd_inf->resumed_lwps != null_ptid); gdb_assert (fbsd_inf->running_lwps > 0); @@ -2094,6 +2092,9 @@ fbsd_nat_target::detach (inferior *inf, int from_tty) } } } +#else + /* pacify gcc */ + wptid = null_ptid; #endif sig = 0; break; base-commit: 38a984fa440c7686c741b7804eae06a528849aa7 -- 2.42.0