From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2075.outbound.protection.outlook.com [40.92.99.75]) by sourceware.org (Postfix) with ESMTPS id E7F363858D37 for ; Sun, 22 Jan 2023 05:54:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7F363858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayczkHm5awQx2XPtHf4P615QzMgb8jKHW1WkqK7JIlPg/l4r9eZ8EO0sKltfzuQm6/d6B6bZHOQmU3eHsK8H4yo1pIVi89+teLxw29qYXi7ldVN0Uxhnhs48EKorHIDl9wUy3aP0KZmnn1qIhwiUTR9kKrfrNoLl7W8+6MZjEvVVZ7ZPm8zsCSotLHLPVLX4MVz1z+bqgodJ0NLji2L4YC6vhaLOHU4NEBTvXg0VeQqysPkNAFOZdyvTiD098PidumUr5LFSCQlJE1a/9Wf6FaVEh1w4BlNIRJNckIQ+WzmfZCxaK/sWKrfgdGGioB8KM0mRi8uEldnemIbf1HU+ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eLLBLNDPCI6AIGLExNSrK2VJE54UIjo88EBAjoT6rgc=; b=ntatW07XO9SYp7nvIPVNLbypUPzpAlWIEF6GeDu8/gvSb5ZXGXfCftqtHIROqyoRUyLxAZz2GF8tmdSXz7jXVPGRw3XY03hvE8/nVCA2K1uigauYFRGK5gbVT9qCWjsOrDUsKAOdzFjBW+HUj44YquhWGPAPWv+J4ADgtr4DzkCuAVHHhwAOBEt+orUkP2TgmZvSdYF2LftKuhxlU946hv8VXoaF/Nu2Bxradfcjlrw/MbS8BWmoXmvbToGj3jDBHApPAz+r3yOS2M1aWNnIrTvTjcRYtg/zV8hXvOeiBFSH/NkVfOr98iTljUmSnpkQ2Ke1O9Ak1H4QX6CllTadJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eLLBLNDPCI6AIGLExNSrK2VJE54UIjo88EBAjoT6rgc=; b=gF0hgGMWAGd4lItdEz+abEifcg05iCWdV0KziPsMPpCFtem5Io7mN+ogPLqsfh8dgm3ers6slNl2pmLmZuxd4dMcHgY3mocQlOX0qNw81PhkowvPAhyqob9zxwUrJ7MdnNB8Uts09rC9CZ771Zl0D9tSpzGsqZq8qmXfChbF+ADav4e3dGUPixm3WLwAvxsQTSFSLE1hgUgqIRiEgFaCUCGVjb/7vV16EGwkPQmxqbSZPoZqFw3GDwViTclVEMCYIk1+RxewYTygXix7aHR+JHT68uYs7fBa0nmLsl4yjxIiLWbL+sgWUy5cfhK23Kv5BKibXNISlxRX00KhR6eXgA== Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYWP286MB3546.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:395::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.28; Sun, 22 Jan 2023 05:54:33 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::c90:199b:e178:3fa4]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::c90:199b:e178:3fa4%5]) with mapi id 15.20.6002.028; Sun, 22 Jan 2023 05:54:33 +0000 From: Enze Li To: gdb-patches@sourceware.org Cc: enze.li@gmx.com Subject: [PATCH v2] gdb: some int to bool conversion Date: Sun, 22 Jan 2023 13:54:20 +0800 Message-ID: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [ycUVmNCsaNUesTmdZHMvfRDWjGv0xMQS] X-ClientProxiedBy: SG2PR01CA0131.apcprd01.prod.exchangelabs.com (2603:1096:4:40::35) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20230122055420.9685-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|TYWP286MB3546:EE_ X-MS-Office365-Filtering-Correlation-Id: 8da8722e-a680-4808-0908-08dafc3d22aa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mEMNpILanyJTbuAexslFQwDrDiHr2Czl17hOp5zuwJ6Q8uNLpqckmJn8u7csb9SgxkJ2W6zL0nQOkAq5l8mN7FtPEF9WXbwuG51gN6fQfJ0AhQtUQt2ApuiLtcheymEsONc0gBoEYr8fomXZveDBCzTWHVvm/dJRWo606qyNrHIbNJFP4yKVlyWEix9k/Qy0uxVIAoryh7n0B+mXGn72zAZoKy2YRnnPYiTSvrYKC5a22bZ7G5Voimtda5aiiT5ZSNTxEGZC0vdmTMvr53xBC3Xx2/npHBZPe9GsvN2rPhs0y1IVT5YbJZHgqyoVH1bTIotPrygYADBKStBIFH1WKACzWoaizPvJgt0KEkUce5zfBMiuhlhpDRZefjZSrQHI9VzJjz25edLNvFPxLKGD21Hy/T+svAvo9b0BYsq7mvou+mFATvGuqEOTAj75VIl6a3QXyIi3+qYrAMYRRSt44hBbH8D17jj3kVfWHMX9Biof5Rrqi0cH2iEu8+0YMylKWmiEQ4x97p3X6r9cBquI2lDgURpad9ZuNUuvt0Y2zagY3ueAjLXxRzR0MrCAqRXuxuzwV2e1PQiqert3rkxUJ9wfVqivkSACMi8Wvzlo80s= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hW/LBJsKjtLJMkAg3bPSVoN83G94XH0wwRlIxInjQbf5I5m2Pe1n4FAluwyc?= =?us-ascii?Q?XVdQj+hPmaGHNXtetDwVVScnwgphruCNzSP4pTtPBdBLzw8ykvPAqGb+P0JV?= =?us-ascii?Q?ikxYPxbXjqWd1ViUCMuiybBVrtkhFGnfeuv4OV+HdSPzQm30QikjCFpSKoZ8?= =?us-ascii?Q?e/5//t+litcqWAVNUCP0fcIuQWHQ6/L2WMeowd6V+WIlrZYZqBWwZEjp85nz?= =?us-ascii?Q?+so+mt9sG9Let2eaMMSej5KXTWME/ePjnZWVUhZRofUalnlVCKLxO8d7k/JM?= =?us-ascii?Q?VKKpbCe16a1WEPsOtsme+UK/OFMg/3sUoBSAs+4C4kz4VRkIhrOt60e/spC6?= =?us-ascii?Q?nwj2fg0FHaNlkONn8idVdPnHXeetGWiRh9/gdt5tG7NBF4oAE4+DIjAWRd4x?= =?us-ascii?Q?UU+wYACsvRhNQRJ6NGceeNmsrqF7Qb9Np44ZkIkYikIeKzyiO73g/Hofxbfx?= =?us-ascii?Q?A4S1YavfYwEiIr50Uak3x4NwrG8y1FIBF7Y+cAhFpCFfed4uNbeHxV37FVPd?= =?us-ascii?Q?n1sO0heoXcfcxRgr+whPCpKtu2blm1tmcU5jsVbL82uetrlqymN9oVbojTPX?= =?us-ascii?Q?lD+yKqQqwhUc2LQfBgZelUBQDG/2Pjx3q772d1rEhGwBKCVNGAS+KAMR/EXX?= =?us-ascii?Q?/kKjqTl923s50s0COALiCE8RKbDLMA7c0bP8xw62Ln+XB3iwrLoyHEONqPZM?= =?us-ascii?Q?+KnlYSiWBSnDvV4+PrP25+eICfwqGwh8j/09XIVYQXwNwR6UcQC2atfdaujy?= =?us-ascii?Q?CHmUsCm3jawfLET2yOFtDEnuJuNxcsqggM+95mlVSI1VAU/agIJaG7Z5ZQ7c?= =?us-ascii?Q?uTZmg7EMkP4HUDs88SmiYx9hRXJIabr6+/K27LkjPYZ2Bvfhvk7CfH3ocFay?= =?us-ascii?Q?fRDrU803TnFA7Wxg0dOdooldMNpMJ1QsYjt+o/duUJIc3d3+/VjWXv3RVpkG?= =?us-ascii?Q?cJAJ87rVYINCLPI2v+CoW/aZaRqLv/gjUpbYHx9nSAFpQVO+oj4rF+WWC/o8?= =?us-ascii?Q?j84khXcy5bkPEUtnjFU1KXCgE9UqBvDccnHcGXY+wk6NCqssJ0GbpRj4QZ3U?= =?us-ascii?Q?Wb5YTEIQdBUpwXdwJq+MvH4MH/vwM9omjlgzyV0Q2+IWJCTsx5fg7z8jqQJK?= =?us-ascii?Q?L0PLygQ6ijDF0j3MfK9lKjP7+Lpt2DyrLenxDbXTf7YAqLvC9JKuErU9pFCS?= =?us-ascii?Q?uSJz31ueRazbdxI2NFqqbuRtoaDGDGuK4nqfY1ZLxw0T9tEV0FuWI8i2V7B4?= =?us-ascii?Q?vk/6bHnxi8QHUiqA3dv+sgRY92XCYJVEfnpBdSauuA=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 8da8722e-a680-4808-0908-08dafc3d22aa X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2023 05:54:33.4712 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB3546 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When building GDB with clang 16, I got this, CXX maint.o maint.c:1045:23: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] m_space_enabled = 1; ^ ~ maint.c:1057:22: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] m_time_enabled = 1; ^ ~ maint.c:1073:24: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] m_symtab_enabled = 1; ^ ~ 3 errors generated. Work around this by using bool bitfields instead. Tested by rebuilding on x86_64-linux with clang 16 and gcc 12. --- gdb/maint.c | 12 ++++++------ gdb/maint.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/maint.c b/gdb/maint.c index 1a226bf75e30..52f91a3246fe 100644 --- a/gdb/maint.c +++ b/gdb/maint.c @@ -1042,11 +1042,11 @@ scoped_command_stats::scoped_command_stats (bool msg_type) #ifdef HAVE_USEFUL_SBRK char *lim = (char *) sbrk (0); m_start_space = lim - lim_at_start; - m_space_enabled = 1; + m_space_enabled = true; #endif } else - m_space_enabled = 0; + m_space_enabled = false; if (msg_type == 0 || per_command_time) { @@ -1054,13 +1054,13 @@ scoped_command_stats::scoped_command_stats (bool msg_type) m_start_cpu_time = run_time_clock::now (); m_start_wall_time = steady_clock::now (); - m_time_enabled = 1; + m_time_enabled = true; if (per_command_time) print_time (_("command started")); } else - m_time_enabled = 0; + m_time_enabled = false; if (msg_type == 0 || per_command_symtab) { @@ -1070,10 +1070,10 @@ scoped_command_stats::scoped_command_stats (bool msg_type) m_start_nr_symtabs = nr_symtabs; m_start_nr_compunit_symtabs = nr_compunit_symtabs; m_start_nr_blocks = nr_blocks; - m_symtab_enabled = 1; + m_symtab_enabled = true; } else - m_symtab_enabled = 0; + m_symtab_enabled = false; /* Initialize timer to keep track of how long we waited for the user. */ reset_prompt_for_continue_wait_time (); diff --git a/gdb/maint.h b/gdb/maint.h index 09a68c17befd..1741d1325677 100644 --- a/gdb/maint.h +++ b/gdb/maint.h @@ -49,9 +49,9 @@ class scoped_command_stats /* Track whether the stat was enabled at the start of the command so that we can avoid printing anything if it gets turned on by the current command. */ - int m_time_enabled : 1; - int m_space_enabled : 1; - int m_symtab_enabled : 1; + bool m_time_enabled : 1; + bool m_space_enabled : 1; + bool m_symtab_enabled : 1; run_time_clock::time_point m_start_cpu_time; std::chrono::steady_clock::time_point m_start_wall_time; long m_start_space; base-commit: 52480b9ef499870c36c8dfb34df31e67df7bb4dd -- 2.39.0