From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2077.outbound.protection.outlook.com [40.92.98.77]) by sourceware.org (Postfix) with ESMTPS id 0FBB83857836 for ; Wed, 13 Jul 2022 12:13:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0FBB83857836 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yz2UNZpkVAOyZauZ7OOJkzxraeb1h8FF/XUiJX473CS1tFIA/+3mCJaUCPIGXYlJY45K/DqVUbl4KFzER/5jpvkTcqjQtkhz+Um3IJJjxZky70puUltnWNi0FphWIugeyWg3vBe5kFE+bcCPsBpzXmH8ju4ytMtfns8gbSVK85y9f4it0VQmu7EA89RhODN66lHgeSnSMusPsOH7q9yuf0zigYUW+k9lc0iOaunnUpK+gVjxhTp94JtQBDrRRdAqyZCPl7x+zsdrlnGmwTMTWrGjtMxzLhElOyqn9soGQO/C3iofucaAPcOPMcqG3+R8WcKG5kbxPI1IvlauY2jK4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ypiho59gkPK1T6G+xt65obG4cuke/NDPhzs4INAjQ5w=; b=izgd8TKnj/AxdKuOFj6l6FOYhb85XkllRazGKfxPPVjt5JG7kLU3BZjCJXnUr9b/hYjvDdW3nQAMUv2vHZt6kaiQIbNBzvjFiMK/X7/+ZcwzMEbEHvJnZitUpReUKGHGLiFhR3ojCSWBt0bjofZIIecKPOGL9RFwF0NWXOBvXsDIMAVcQ1rItVmzFVA/6DKUavZBMSpxeAaBZVkQQbgCHsVfv6YVOffWbSMs5n1Omq1mZxAYqj/wbfm8vBWCFB991W2sevmPXr1cbGjR0/QRYqkoKQECAJAcdG5SWsKKGl3JhfLq7rEyy0nAHtlcLbjiJPvmM8hQbQYO7VpCfF3ACw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OS3P286MB1518.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:17b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Wed, 13 Jul 2022 12:13:32 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 12:13:32 +0000 Message-ID: Subject: Re: [PATCH] gdbserver: remove unused variable From: Enze Li To: Andrew Burgess , luis.machado@arm.com Cc: gdb-patches@sourceware.org Date: Wed, 13 Jul 2022 20:13:27 +0800 In-Reply-To: <87bktvu0ag.fsf@redhat.com> References: <87bktvu0ag.fsf@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 X-TMN: [GkRxH1cV9lw6zEd00CXKg2WCABFyf+Af] X-ClientProxiedBy: SI2PR02CA0012.apcprd02.prod.outlook.com (2603:1096:4:194::7) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b759f26b-a15a-4046-283e-08da64c91a93 X-MS-TrafficTypeDiagnostic: OS3P286MB1518:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VBxUlihrkV2LkicCFexhFpE4gwrxtS43d7AVFF+SdDEuWIJp+oNqgeWeXJoEXBVNlbe0tMP779kJb0U2XAbMZoz0E4cwa3kePxrU7cBNbJGRH2ABmTFpzYbn09+Sz4GoNKjaZkVmjj2YrXQYrc6mYM5GRrWMKQ/2zDBP+i1gK2z+NFneDpRDb8p0ysXUE2ioVPqeg8tuokrs499pAZA97+KakTp0Ku/0Av7MQlQLvIZ+z/L0IJWou2amzel/G+rUddNmVb3yyPX/Iu3ML3fySftrW8JYiilGk+vh49VrKagomZYOkV7CAUwGrOC1fqgWmP+b7OYBk6l6smzymTcB7gXDW7vlUZuYEeWA1RwNaleU4x8ELMqJH/L/AtbFvQ4Yse9ZnManEwtiWkA5/El2/9vYXEGggRRbXb47IfF15Ffnh6tywgD5ZUhlEbUzZCoqKrddTb0GHHSQPz/x+cFc0wsAv/O9nL73kRBFU9jtGw7jUW5FoK8WkwuHNflZ1KoOFaYRuW18h0NDaTe3crra2JW8wqDdceAQd6wMC+XQMAgHjzjoZR9Ti6vbsx/bsZd0GU00E/xrqA6ilC6tC8VSOzFvA3wga965m2M8DLhjVdXh7p2B82+taXmrKAWsU6ZGLRkrCW08wqbr2WW1VWup+l6IVs5cKWyxycEPJqc2vmjlJmNXQ/HuT6lQ6PKXk6YxitWBjXIRYb5rBa/boboq6f9MD4ZYXwjCuFbN1yKyi94= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTdGZHJVUDNlWDF0ODNjUFFSNHNJZ0ZsTC9sVjg2TWdHSkVJZ25QQzhLVnlT?= =?utf-8?B?SE5uN2dOR3RLNldhZkRvdTExWUd2VnFzSUNOd2wyRHVFTklSUHpPYlMvM01B?= =?utf-8?B?SVVnaUJGNS9qcEJnRVFTQXcrYy96V08yZVJlcWtRcE0yOS9UaTVPbERnMWF4?= =?utf-8?B?dUdsUjczaWJXVEp0cld3TTBJYSt2c3dHWXBtZlZDeS80QTNET1lWM3AvM3Rx?= =?utf-8?B?NmlhSkR2ejhobXB3bmRxcWVRK1FpK01oT1JnS2FNb01iTW1leGw1TjdaSDFO?= =?utf-8?B?UCtHaUdHa1pZb2JWOGE4WUxTazFxOFlvOUhjWG10amMzM1lVdzZSQmtmK0pZ?= =?utf-8?B?MzZKUkwyUDAvRFNCR2pqOXo5Ri9ITktGenY2TDBkcVZUb0hWNExQUGRIU0Vn?= =?utf-8?B?WWtJR0ttWVVDeFlpRmhHTFpvdHpwS28xMDJyMlZaeFcwdGNGSDJJSDFhSjhI?= =?utf-8?B?eWVTK0dLRldhWWwxMG54YTdIWmIycm4rU3JSckM3bDJPc1V4cURUU2ROQ2RY?= =?utf-8?B?Uk5FSlhmM21sRWRqVGlpSTV5ckNWZnZYOWN1ZlU3OUpMREd5SHpzZnJtZGhV?= =?utf-8?B?RW5UTU10bFFPNDZPL1ZGVStPczZLR2kzaEYzY1U0eEFERFFpWVhSU3JnUDE1?= =?utf-8?B?TmhTOURWRjR5MjZZNmY1V1NaZ0VQbU9tV20yY3VjR2U1dVc3cUxBSFNTRlRx?= =?utf-8?B?Q2E4bVhhOVkvMmplRGd2NVdJeWJMSzE5T0NXTUYvTUw2SDRkbXJaaW9RM2pw?= =?utf-8?B?c2NyTVZkSVVQTVR1K25GWEQ1WVlWQlFUYzlUdkkxNmp0ODJTVFlFWTVTa1gz?= =?utf-8?B?V1VTQzc3L0cwdlZJai9ZeWEvdjR3bkxCRnAyTm9QN1VSRWVOQW1nUTNmUVJk?= =?utf-8?B?eGRzNDlWcVB3YVFXTjQrNlg3NE9YTDVSdk9EN1hlRTdtL1VFdmZwclJFSXZN?= =?utf-8?B?a1pNb3d0SzZWb2ZWRldnZEJQZ2FuUHI4Yk9ZNVVnTzhjcG0waisvTGh1YUdJ?= =?utf-8?B?K2FJbDlVamxaaFZycFVxcG5FSmljY1hxZlBhdUJEVjFXVHZzZkpIL2ZsZUY5?= =?utf-8?B?S1hNbVJ1Q1ovcWdZZ3hyVVIzVFlsd3VFcW9PTE90blRMYzZ5RFd4YXcrZ3lH?= =?utf-8?B?dGsvblI3R0VzdGdwOEdUd2lWeDdlTkN6NUw3akQyYlNSS3VEclpBOVVGbE1S?= =?utf-8?B?MHFlWGNYalZ5Nk1nQmw1WGovaEllQlhXY1VGSHZVQlU5T3MyR2N0enNFdEFL?= =?utf-8?B?MmovNndyK0hkKzFFRGRMLzlrb09rMEdnalNPcE0vdWljMGtlTnhPd3VzSjI5?= =?utf-8?B?aUVBNEYvVTJsdWpXNDkxNWdzc0J5b0FzMnUwT3A0UHBIa0loYlY4d2xkV3JW?= =?utf-8?B?bVQyTmlBZmRveVBZTktrczR2aDd1V2FVOStTRnlmdGkvY2VZWEc1b0ZkRUV6?= =?utf-8?B?d1p4dnFLNXdFUHc5N3FsNU43b2lYMklLQm9IWmtEVnVRV2N1N1pYNFVYVVkx?= =?utf-8?B?T0N4OTNuV1VFTHpscGdqMDlYL0hLN0luRFgzbjlNdytNWS8ydnZmYnpsemRQ?= =?utf-8?B?VCt5YllYdjVmWkg0OGdaZmZNcDRVOEEya3VUYVBzamdwZ0h2ZXZPN2l6OVVF?= =?utf-8?B?bVAzV3ZtYVlkZjZBSjFPbXlnTFowYnRBME5KdnF3RnQ0SGtpS0FFMVZ5TWEw?= =?utf-8?B?Q3RtcWlBUll5dHFXMFd1c3k3TUZ1V3BQeXErc1M0SThMcnZWdGhjNENBPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: b759f26b-a15a-4046-283e-08da64c91a93 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 12:13:32.5913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB1518 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 12:13:37 -0000 On Mon, 2022-07-11 at 16:38 +0100, Andrew Burgess wrote: > Enze Li via Gdb-patches writes: >=20 > > When building with clang 15, I got this error: > >=20 > > =C2=A0 CXX=C2=A0=C2=A0=C2=A0 server.o > > server.cc:2985:10: error: variable 'new_argc' set but not used [- > > Werror,-Wunused-but-set-variable] > > =C2=A0 int i, new_argc; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ^ > > Remove the unused variable to eliminate the error. >=20 > LGTM.=C2=A0 Please apply it. Okay, I'm checking this in now. Thanks, Enze >=20 > Thanks, > Andrew >=20 > >=20 > > Tested by rebuilding on x86_64-linux with clang 15. > > --- > > =C2=A0gdbserver/server.cc | 8 ++------ > > =C2=A01 file changed, 2 insertions(+), 6 deletions(-) > >=20 > > diff --git a/gdbserver/server.cc b/gdbserver/server.cc > > index f9c02a9c6dac..c619206d5d2d 100644 > > --- a/gdbserver/server.cc > > +++ b/gdbserver/server.cc > > @@ -2982,14 +2982,10 @@ handle_v_run (char *own_buf) > > =C2=A0=C2=A0 char *p, *next_p; > > =C2=A0=C2=A0 std::vector new_argv; > > =C2=A0=C2=A0 char *new_program_name =3D NULL; > > -=C2=A0 int i, new_argc; > > +=C2=A0 int i; > > =C2=A0 > > -=C2=A0 new_argc =3D 0; > > =C2=A0=C2=A0 for (p =3D own_buf + strlen ("vRun;"); p && *p; p =3D strc= hr (p, > > ';')) > > -=C2=A0=C2=A0=C2=A0 { > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p++; > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 new_argc++; > > -=C2=A0=C2=A0=C2=A0 } > > +=C2=A0=C2=A0=C2=A0 p++; > > =C2=A0 > > =C2=A0=C2=A0 for (i =3D 0, p =3D own_buf + strlen ("vRun;"); *p; p =3D = next_p, ++i) > > =C2=A0=C2=A0=C2=A0=C2=A0 { > > --=20 > > 2.30.2 >=20