From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2100.outbound.protection.outlook.com [40.92.99.100]) by sourceware.org (Postfix) with ESMTPS id AD4723858430 for ; Sat, 9 Jul 2022 04:30:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD4723858430 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SXG/l4tPqEgBBvZDpxOLKk5nMqC/79jjONyGVcLOH/QVig4c5iCNp/0yMV3JPtSxwpIoyC7X00qYS17hcrbBTUOGr7bpIhdmpaX8b9Qu66YJEIb4P0MFKKQQCfLOmbZIx+knzvA+7LBypMGjFkA1YcfdwXw+d16fYnUdNXqHdXPrRHlUW6LgvPKwxtk4N5QHgjarhZX4ZpY14Rv36fbjIfrA9EPw7TT9Jrcm0trz7o/Llibi5Vib+NZp6Uo7NDBiVcyJ+HS1W4UbNjUwwzD3LgSW2UVKokwVfsSRvkdV5GVZrgYSxhXV8US4A3GKGG7h7/dCV2RHW1PPo6BDt5Z2ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6gH+OVwbzUndlUBHsTT8KPkkMVsuSJkW3OA7kVXB8c=; b=cKqm47wcNHxRCsQKi7yEgB0YgyFttyn/ZzL3NNPk+kTPELBcbR1rThlkgeqqJScV4huuYE0uHVXywk2zNQtkyjV3qb9IhQf2vflo2YRSmpmC3VM2z1pQJ5A/X2SMgSPRzKLJWYNqL+sBr0hWeLxYcp+AO3pZXLkGUjWr80oy2k3EPM3H2dsFfC+jwcXPR9h7HADdoUpXju3qJKxVga/klAeSIR0Dy/DABACsdk4mWM4l42I494IYFaQM9Gb9oxywJG45Fz04xgsK61JYW+C/V1UeGD7BTkDVtP/eFq9seaGNjtrOLw4Q9OpQrnkSYOp1/nTaZTpbKE+lfciIxHoqLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OS3P286MB2744.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:1f2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Sat, 9 Jul 2022 04:30:15 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5417.023; Sat, 9 Jul 2022 04:30:15 +0000 Message-ID: Subject: Re: [PATCH] [PATCH] [gdb] adds `` to list of includes From: Enze Li To: Christopher Di Bella Cc: gdb-patches@sourceware.org, manojgupta@google.com Date: Sat, 09 Jul 2022 12:30:10 +0800 In-Reply-To: References: <20220628010427.1856503-1-cjdb@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 X-TMN: [m6C0d3zXnNjGNnGEBqc1gqAXlthIVNOy] X-ClientProxiedBy: SI2P153CA0021.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::20) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32e6bac9-06ca-438a-4e46-08da6163b84e X-MS-TrafficTypeDiagnostic: OS3P286MB2744:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R5loLPJqHVzRN/+OuR2SLfJbmysN/ceFlMafIMgkOiSMf7+zoh1/oKjKwuZH+0xIXSauVo27eaZj6AjivfAoItPIx3SbJGLbvjKdBNoY4onErqW9woNjQPmmTH8dg1Hu7VjhPugu3SFrC0oPJSVFOeX1H4KUFj8KD4Kp6EOACS31M8lQL78PeN1zbUCruIV5315Faq7vWBZjbG8dpGdwZA1TfzB4x2YCpMCx82fQW1uL5aSpENvE6JeU/OCCwE1G4J9Bg3KPHbCkdq0187Nd076GD6sPgoEr0dH0mEfLeePWm6rxpQZC1KfDH6wfAm0Z3EGI5bAH2eBDjDDjF2Gxf9Osf559HhyzYnpWIg9oWCmp03B6KiW6PYsbUTmotmkJC8QYqmCULDhQAIRTP/asdwYtz82SJOxwneGjGNqb33hRznBP8SHX6jCfBCXWtt0V30cKlu5eQWrF21nzln7+TUTL7HHloP5XWOt+0y5I9Z0glcT6P6DFzPfuYmtt0OeuW90c0T1ro6L/+/nxaU+dU3wGTD8OnEyq0t2FTsbTlNac7yOyBFDOSXJSdiXp6abrK3t8MrJmJlukrumCcqKStLdrAknvrPO5wZIXqPmiGXymsTh7pCscucOG2/klfdW97W3UAz4IrvocnMV1psUmApf0+lnP9DTMInrpVbxjpgdqYm6x+f/MIYo+ovhdm0R4WMx95B/KfLvokZGBAv7UQ3gkZ+j1Wxe4amwCpvpW044= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUpSOVd1WWFEM2drcERHR1lNd2NrUElHcjhESXhVdUN5azY1MFJBWXRDL0Ry?= =?utf-8?B?bVZBRkJrdEdjbms5Y0FudEFYaURLaElJZjUyTWlEZStyZThERldvcmZIQ0Nh?= =?utf-8?B?OFlNMUtmY2hSUFBFQmpZWjdFMVNjMS9KZWJNTkJtZ1ZTdFEvZGtUeklJTWZk?= =?utf-8?B?MjlzZ2NlRHhYS1VVaE5UNmMxaHcwOG1zeHhNenJ6V1lUUnQvUWpWak12aURx?= =?utf-8?B?RGFHWDVYR0dPR3VOU0ZOZ1ZYU3ZiUGMyaUJnVlg1aDFUZ3lVMjh3Z1BPVS9v?= =?utf-8?B?bjBzU01kUUtra3pERFI3cTh6TWZoY0Y3OWJwMTZMNFZrODFMazdBTDgxQmNF?= =?utf-8?B?Q3F6alRWZEhJeXZqTDhaK3FMS3pLZWFCSGJzNlIzUmp0MmQyUVQ5WmhodjRl?= =?utf-8?B?S3pNalpJdFRUL0ExNVo2QXF0N1VtclRyVUFsSUR6OUs2cVA1WWoxOCtaZFl2?= =?utf-8?B?anhlWHhseERIMkdUM09iK3VUZEZzUVZ6a2tVLysrSFRORnlFZ2Z4SDF4MnYz?= =?utf-8?B?THpxMzhDbWc0cWJ5VjhnOFF0SFhXRWdEMHdROTQ3TitpREhQUWk1ZjBvb2g2?= =?utf-8?B?a0l3UmhuNVViVFRYay9iTkpoZ092NlRJaGlYbFU2M29JZlQ0Q2VmaGdWUFBF?= =?utf-8?B?ZE9ha2VUcWhJZW9oUThITVZoTXVVMUFPUjI3T09DcEJrb1JKSzV3WDN1d3JH?= =?utf-8?B?T2dnaHBaSGxod0ZpUEdqVjVGYjYyb3RIeXlxSDJRMVcvTktMTlVwZFZoQU85?= =?utf-8?B?Z2JIZkdkOUREZ0UwaEVMRzkxRzJkOUxzcDFjUUtHOXRtQ2E4RnNRcFMvck5h?= =?utf-8?B?eFdPMGtITTY0SEI3WStOWmdMbzNuV1UzRHRqbGpmYlo5ZklUZ2ZKdW9lKzUr?= =?utf-8?B?cXRxbVJ5SGwzN0FvZUdQZUk3QS9ST0UvSWJxYnpHczNzV1dURWNaVENseXZC?= =?utf-8?B?ajI0QWEzTERjUnR2VnBnMmJ3NGJLOVJVYjRnbHJoL0dHeCtoeHRTNE1oVVph?= =?utf-8?B?cDhlTDZ1RlMxRXRxUHRNNjNxbWY0ci9UM2RLd0VRYlViMkhXQVVyRFBESU9K?= =?utf-8?B?NmJGcGR0dk92NnJsVFcwTlZnYlRLNEh0MjRWV0d4UDZJNStFSmJYdDI5Q25y?= =?utf-8?B?QytoUURoN2pBd0dLcVlmYVBUaHZkZUlEVGVxQ2RXc2p5YUVVeXBjNVRXdTVX?= =?utf-8?B?VHhqRnhsVE0wYkxESy9kcTQyWEdTcXVjS2t0d1NoRU9ibzJrcDNqUVNXcEwv?= =?utf-8?B?UStXQjh5ekFNOU9JRjFrWFpmUEY5ZDh0dlIzVld2dTZFMzBFY29ZT21URlla?= =?utf-8?B?YXFnZjZyVVlia0l0aVRZa0dublA5MFo1akdITExleUdwZDk1aVpDSklkSDFQ?= =?utf-8?B?YkhzOS9hMTBnOEd2M3RJTmdBUFhFbEpzZU8veVc3dmNtUEdQZVFUZmUvYVgr?= =?utf-8?B?SmN3dFZCMHp5ZjZDUU1RZUpZUC84V1JGYmlpdHMvbzhmRks0bWx2WDBoR1NX?= =?utf-8?B?YWxrTC9CaElBRFp4Mkx3Wk41bWVLUWxtcVJSKzZnOEc2aWkrWFk0SWZpTXhP?= =?utf-8?B?ZVd4K3pEd2UvTEQrTmdLVnBXNnlGQldTUjQ5T2gzcmpnaXQwdm93SnIySUpE?= =?utf-8?B?NndJazJZZytlS1lWTSs3TmpEY3hWTTBiVmJtQjViMVlSOFpUbHByYnR5V20y?= =?utf-8?B?SW9sU0c3ZGQ2R2hwZUEwSnVGYnZEKzF4aFNEcDVhellqSldaZTF5VmdRPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 32e6bac9-06ca-438a-4e46-08da6163b84e X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2022 04:30:15.0798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB2744 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2022 04:30:20 -0000 Hi Christopher, Unfortunately, since I don't have a ChromeBook, I can not reproduce the problem you encountered. I tried to reproduce your problem on a x86_64-linux device and still did not reproduce it with the trunk. After digging into this deeply, I found that 'gdb/value.c' has already includes the 'vector' header file after preprocessing. Here's what I got, value.c |--defs.h |--common-defs.h |--common-utils.h (#include ) Finally, I noticed that you were compiling gdb-9.2. I know nothing about the maintenance of closed branch. You may want to keep PING and maintainers would show up to look at this. Thanks, Enze On Fri, 2022-07-01 at 14:50 -0700, Christopher Di Bella wrote: > Hi Enze, >=20 > `std::back_inserter` is defined in , which isn't included > in `gdb/value.c`. Because the C preprocessor imports headers by > copy/pasting the contents at the `#include` site, this means that > another standard library header is exposing it (presumably > ``). >=20 > We experienced this on ChromeOS, which uses Clang and libc++ to build > things. >=20 > ``` > /tmp/portage/sys-devel/gdb-9.2.20200923-r7/work/gdb- > 9.2/gdb/value.c:1648:52: error: no member named 'back_inserter' in > namespace 'std' > =C2=A0 =C2=A0 =C2=A0 =C2=A0std::move (iter + 1, all_values.end (), std::b= ack_inserter > (result)); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0~~~~~^ > =C2=A01 error generated. > ``` >=20 > On Fri, 1 Jul 2022 at 06:45, Enze Li wrote: > > On Tue, 2022-06-28 at 01:04 +0000, Christopher Di Bella via Gdb- > > patches > > wrote: > > > `std::back_inserter` is defined in ``, which is > > > currently > > > being transitively included by one of the other headers. This is > > > causing > > > gdb to fail to build on certain platforms, which is fixed by > > > explicitly > > > including it. > >=20 > > Hi Christopher, > >=20 > > I didn't get your point through the commit message.=C2=A0 Can you > > clarify > > exactly on which platforms, and what build error you encountered?=C2=A0 > > So > > that I can reproduce the issue. > >=20 > > Thanks, > > Enze > >=20 > >=20 > > > --- > > > =C2=A0gdb/value.c | 1 + > > > =C2=A01 file changed, 1 insertion(+) > > >=20 > > > diff --git a/gdb/value.c b/gdb/value.c > > > index 022fca91a42..ba7ae1a0e18 100644 > > > --- a/gdb/value.c > > > +++ b/gdb/value.c > > > @@ -40,6 +40,7 @@ > > > =C2=A0#include "cp-abi.h" > > > =C2=A0#include "user-regs.h" > > > =C2=A0#include > > > +#include > > > =C2=A0#include "completer.h" > > > =C2=A0#include "gdbsupport/selftest.h" > > > =C2=A0#include "gdbsupport/array-view.h" > >=20 >=20 >=20