From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2032.outbound.protection.outlook.com [40.92.99.32]) by sourceware.org (Postfix) with ESMTPS id BB5C7382BA1E for ; Sun, 18 Sep 2022 04:58:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB5C7382BA1E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MV4lckQBshiSyUiQ2Y8P9ABrt2cYdoqc7GfIIizWG+bNwBeHeQRC27grgoaWRi0UUYCa4zD6bNZrikR6g3LIoZDxZARJe0bwFHQ48i5qNmFNuiGju5na3cqKRTDLZTcflbE6XxZwVFO5HS7wXYJYIdjpv217wj5IrqZlHYfv58RRA85mng8NqOvZ0GfclyvAwFNG/aIJJb84+sm5Aw8foxggxMkeaq5Oj5aryfm0cqoKP5iRBCi9vJ2Luvr3CJbBsO+8ogADtujFPvfOZyu4kI7gt85pRXnuOX3OMeykqV5Z51C3pjd26xDdYRhf5+ev+4UZiMkxhD2EI9VBiK3nOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qtvc9m8tOnUZytlUVBMmQ3AawiASMBil5bz7rhnwZ50=; b=gGgVO5ywycRnbYL8Me7g1wqfJrfLd+bjPTemsWXmLOpPgCQShoYc8tADzLintn3TA6wdBIAiCY68Ly6/LC3eontVCzRzmoRULDbFHfRXadIvq03jQZKTdQMHp7rVDAnvWlTZammFFPAykkdFBYGDHbhqsWUa47HVrEmMnoYeNG/Nl8C9UFzOHDIut+iiQsheOE8VQLmDV0tGCkZuhBgYSBz7AZHWRbDJQtthKV/rCTHJL7fpJhZ2wbkPjllhxcH9TlHeF+qPhn5KQ8eXBF3q4Tj5/XhKEb7WyN3VE2LDLG3iGKTwCwqPXeo/J28TqqC8UEp4jaG/cmoxDZBQ8IUrUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYWP286MB2072.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:177::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Sun, 18 Sep 2022 04:58:36 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::e442:a4b4:201c:8097]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::e442:a4b4:201c:8097%4]) with mapi id 15.20.5632.019; Sun, 18 Sep 2022 04:58:36 +0000 From: Enze Li To: gdb-patches@sourceware.org Cc: enze.li@gmx.com Subject: [PATCH] gdb: add ATTRIBUTE_PRINTF to gdb_bfd_error_handler Date: Sun, 18 Sep 2022 12:58:20 +0800 Message-ID: X-Mailer: git-send-email 2.37.3 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [0rKvdae6rfVbJqGTjcNbADNyus3VM+80] X-ClientProxiedBy: SG2PR01CA0162.apcprd01.prod.exchangelabs.com (2603:1096:4:28::18) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20220918045820.6737-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|TYWP286MB2072:EE_ X-MS-Office365-Filtering-Correlation-Id: cf099002-48ec-4da6-79db-08da993271cd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aVu4+p1r41ei4tK9jYF+W2DDVN19MKuaJk899GxpQEHxid+R2K9hVrUYVaECrai0DqZN6b9mKjIZIlZfx69rvcH41O8YhDXuKzNWROlhirg+xuCUzYF5dQ9Cik0ao2ZzC5RftC9GDpXShUiy8JeDR4gBRN+kTcsteqmW74VWIp9LWstOE0GpVzcN8+QHVvNoPK9kGWcD57tDpYU2rLsDsUezBtAqfX+6tUIOSnzcFsVOdpcy9NwPCDJPxP6DPiBcOuITPY1IoX1vvT8d0KD0SVv+N0yDwZ5BRlScJQdHwonl0+YOsZy0Plh36B8o3zG+5TW3a08lLeQy3vvvaAZx6+rmogZ1S3ggQeOSIG63Pdo69jrVFY+2FU6DD0ud8kpSVo5ifMmnfs1IjRfdHmbogKp9dsw0cOjkHqnOLdXWw2/cJ50TTvVlmTaT63iriMnTTe2ec10kdUBkyI+8DFfoMhDRbPikwxilXwXdXv7DkQKb4dZaommThYcHALQcwMqCrSjyzEwHWHe820fe7xxmJm6FjmzxBxAQg7nQCMUPghyUTeuWF0sMCmsfDgYtu6UuOs8+KGDX4006aD95m0WUK0rbB1piH6rjhT020QAo1gDuOktYBaOE5oUyiaC5f6j3YojBWlSpZNu6NCAHzptnag== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jQ71jhNKV3VDDtr4jJEIcojYhNosETIUJcc8u8OrKRtZuq2TAra7DFXy988V?= =?us-ascii?Q?PaoiQaXVwQagn4R6MNPhYT5t+2kOGrJ2EiAuoCm/pcs+3owIAKBXGGTT6rzn?= =?us-ascii?Q?bxv2Tfli4KWTFh+5mV1K5f3H4mu7stdOHKxGYjVQPZeeEf1Zrt6kqvL2qZTp?= =?us-ascii?Q?u60Yh4HIP5LEKodHvoputUe/W5SlCJfJn5OEvVP2tDseeGfkwDrAdCUtcGZs?= =?us-ascii?Q?ui7VlRb5ptFaYf/3/FfGBtYdyjBdtiFsl/XORdN1oLHCMWDqdB6JfRbwrRSl?= =?us-ascii?Q?dcd/P+bCQo1KaztXt4oqDmn2q/bVZHVqzJlzsifuFrcnRVjzXqdrJhhFLCNK?= =?us-ascii?Q?xDDpktYq+ID5fllQjhSPQx9/ooBcEq4mFAH5itSbcDHWp0Gs8GtipC4puEOx?= =?us-ascii?Q?/RTepQ6dPvXk7hvJwZS0mxeVZ9MrvYYwNmW6t1EYeodQ5Cqocg0MepA8Dlhl?= =?us-ascii?Q?OeCfIBPDnG2dOVuo3hTCBCvx7gImwCLEMZQNv2X/ox/T5WR0myq0+RLvsu1Y?= =?us-ascii?Q?jH0TXDs5EKDyLBOykXXagl+Adm5zDRj+jdRC4KCezznjZs7ugbn2S6ZREhvq?= =?us-ascii?Q?p1/njdipxgrCy6TwA7nLBqelXoS/XckkZWksIs+4pvhIagnA6AZESqihvb63?= =?us-ascii?Q?hq4i8VIRpw/ftSbVUjMuI3WIKpIcSK0VXp/+zw0siNOdw54ItMHAo7YFwezs?= =?us-ascii?Q?w0fIzmo0t6M6GT39Beo8zYVNHMYysnHA+Z+TQG/n/nb1KGx8HDuL+VOJ/+JL?= =?us-ascii?Q?SWadmzbwPvqWdCMgRmoRlmxK51XWe9+ZktaeJNmeJ/6TQEZcrdhjw/HcmoMi?= =?us-ascii?Q?24udUMeadobxvsbgXF3lDylVXfsp9R31bulqFvhvOGuBWNrUqwzLeT5cG4X8?= =?us-ascii?Q?2Lx+R0+Nfh1brsHlUTeVGd5szbYOwuN7hzi9jcTgb6ExXNFnihfDpxu6fwkv?= =?us-ascii?Q?qE793AYyY4TdYPKCbI21imKUZ2VvqAUOyz0LIx+5x54BWc8UfamSHWBHvIAe?= =?us-ascii?Q?DKkc4Pb2TXpl2+Eve8U6bsSieeBCX9afgWGKaQZjFY0YyZulYXsNdiOa8/UB?= =?us-ascii?Q?GXWf5VHrMMFp3P4JtF5VzSwPMqcpZrkj+NqsV2jLeptgB/vnTVOTS5JH9j6O?= =?us-ascii?Q?LW95VOnTck5QzehXRk9eD/pZfeuEslwPuBMXaMLoH1hMuKxE5ZYzhRrBCHeD?= =?us-ascii?Q?g7JPPhEIW9uNhFDxMf0+/plv7Y3OEJQ1hNfk/BAj1flz+Eoi3xK2b/wGkEvq?= =?us-ascii?Q?8j3G5QXCswFnlytjoUBYIVMkCapWZUawpXJ0cFavTg=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: cf099002-48ec-4da6-79db-08da993271cd X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2022 04:58:36.5864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2072 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Sep 2022 04:58:42 -0000 I see this error when building with clang, CXX gdb_bfd.o gdb_bfd.c:1180:43: error: format string is not a string literal [-Werror,-Wformat-nonliteral] const std::string str = string_vprintf (fmt, ap_copy); ^~~ 1 error generated. This patch adds missing ATTRIBUTE_PRINTF to fix the error. Tested on x86_64-linux with gcc 12 and clang 14. --- gdb/gdb_bfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c index 6299148d419..c5a5ed95e8e 100644 --- a/gdb/gdb_bfd.c +++ b/gdb/gdb_bfd.c @@ -1170,7 +1170,7 @@ static bfd_error_handler_type default_bfd_error_handler; messages which have been printed once already. This is done on a per-inferior basis. */ -static void +static void ATTRIBUTE_PRINTF (1, 0) gdb_bfd_error_handler (const char *fmt, va_list ap) { va_list ap_copy; -- 2.37.3