From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2067.outbound.protection.outlook.com [40.92.98.67]) by sourceware.org (Postfix) with ESMTPS id E74773858424 for ; Sun, 24 Jul 2022 03:40:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E74773858424 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z8NpdzT8n6Pb1L9yz+b7AymMh7mO1byp8KOjJa78T0VMjQ6iflV+IFzwV3UV/f0xw3TIUxIAE1VaOsRVxlfe1Jz+PT4xfq60HrkSBt+lWKHUzFaD/MbeUu3fzD7bJMMjT7tZPUMppg29e4XWREIkoVLWl9rgBz3nFJULW2g7JzwetU0Pmn/XV48loJDGrG3YJYujz6n2YnZK9LMIjDoJ2IZOh4e1Zw5T9rLzZDCv4ZNHYLvlwbNXrZSp4ng1wPiLTcDXjhQPNbivD12xmhSoosaS8e30Haa3l1X3nTUhB+DdL+SJi21yiZiAFD3GwzFkHcZqXcd+G2fxxbbJgLww9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7iOmEG3no3rSpq0BC4yJ3Id7Jbn5/FEWPt2kIVchO4=; b=aQ5NA6WxF5OYmNPn+O/g2wybkJYT/qENmpB8QYbDWW/LRlq0V3R/3GYojNGvLs/boJp84PjQfK8kHlOXgJcM9PIHxef5tU0Gs86HyGLkbQMQ2pIZ0fwOs3t9uAINx03HNUrPoJ7gz7jKtd7hgNJcvD+2Xvw9k6FS9k6KZ2KqOzE1k138/J7fhztRocmn0AM2y4NSf6QcXthy5YHeEQj3kL1IKf9d7SM+DHzVtL4C0VpgECJ29nt/skp/6ubnLTuYttk6Tnvq3ZphIhDcR7Uw43ZVzk5IQ7EjePA3XCd2Hf7caz8RRDm3JbsSispyUS4kpw8rBEFSxlW/nItWhfqehQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OS3P286MB1253.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:12c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Sun, 24 Jul 2022 03:40:42 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%8]) with mapi id 15.20.5458.021; Sun, 24 Jul 2022 03:40:42 +0000 From: Enze Li To: gdb-patches@sourceware.org Cc: enze.li@gmx.com, luis.machado@arm.com, jhb@FreeBSD.org Subject: [PATCH v2] gdb/hurd: pass memory_tagged as false to find_memory_region_ftype Date: Sun, 24 Jul 2022 11:40:28 +0800 Message-ID: X-Mailer: git-send-email 2.37.1 In-Reply-To: References: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TMN: [WEDtyBeVUnpxNfCVvmpa/5KN4SMxmvLj] X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20220724034028.14306-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 028f4d3e-1996-403f-6b5c-08da6d26487a X-MS-TrafficTypeDiagnostic: OS3P286MB1253:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GiGS3sBcOyaBWrJNYFL97RxHTRTzPAEjowz1jchdbL8aZPwwZmXkzN+AShobtLUnLVCLh3LGNaoWInmCWlINYzoTou8ve4b0fWaVhoFo0rT5pMNIZScCdPn8u0nL9vJWfK6SC+NTgbtLFXi00KfaDbgSlz6DV5qEDm1PgIx7FxGQPGOJeeInYOXRdN8edte6ne2TgLsxr9qjxTaFjNb9N35xIqC/W5YK+NF+US88jZYr8KALu9FPqgtaIA1uR96JmIHLXD0gNyxFDEokrVD3j6TnD3yQMnGqe+E+IHmfQPZXyT+LcpYc5MrHr3K55/qRW+m717/PbS42jZnPUlOHry8oeGIuu+SvFTQiecmu6+LD9MLro5+NDhBvBoiqFfma4SgIWeeJ0FOAKR8+18xpU5CiJeMdCMaBcVnryt8uPqFGuX5V7/NOcHAdOkN7U6spmZPQej3z6SgXFTsFlDOfO85yLWK5VCbPsfrlJ/q1ZRd7LD8qri2d4UImQCfMsJ8EpvkqB4QwJ0oGRYs+CjLMszvVGFm43phhch6jqzmgvox/wk/gtd4Owr6jZ++ZMXxlOu43UiBtgvCAtr7Ibkg2UyzDkXIcRgGCGSciu9koeZWMY+fmYpHeTHSdi7jrnGXAZlIvGakmVxKIUtcghZ3Tow== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZE40OWYweVllOEFCanBReEdqR0lhRmJXNUsrVjQvSmpyMWN4Y0c5Y1F4Q1dq?= =?utf-8?B?ekRJYkdxNWJORzZHV1NlRU5vZ3RLaVZRNmJSOXNlSHAzbVhhK2l5RWtkZDI0?= =?utf-8?B?cDdmbVdLYnVFWWZBS2Q1UG9zZitTdlZ6Q2RJM3RIczVXSnh2anNqdWZDTVI1?= =?utf-8?B?NEs2MDBtSlFNQm9PaVl5SXdRRzcrZGZUZHE0Z1JiWmRRSWd4LzhxVG9qR3M5?= =?utf-8?B?eGFjMVQzM0VkckdzSnZqa1N4RXFON0NPYkd5bFBVOXlIMW54Wm56dHp4eUxZ?= =?utf-8?B?QVdCSGFCY01YclBxUjVoNVhFZStwVXNBTkt0blBtS05teWdvK0sycXBESkQ2?= =?utf-8?B?SjFXYVlOcGZCVkxTQlVjYUFPWVFrR2dCS05hR0RqTjZXemNydSt5RVpzeGZ2?= =?utf-8?B?dStLbTU5Y0tCVGZrVVFqT055cVVLaGk0UTUrK2pSMFFRVEhiZXdHUG42Yk1r?= =?utf-8?B?d3RqK3d4Kzg3UHVjTjNpNE8vbGhoQXowNDZZSHZIWWNyeGtVQlJVQjdUWFV5?= =?utf-8?B?YUZydG5RaE5pSldYb1IyQjk2a3JIZDYvT1dZazY2ZVI0WGtVbTNSYjNjTkhY?= =?utf-8?B?SlJkcmZCbGdJdkZWOGxaV2oxNnVWa01GZUZWcVJtMC9kanlKMXZZMW14ZHda?= =?utf-8?B?RWZxOXI0QTRreUhaQ3hNUGUzRUNxUWhyWE1wUmdkbXY4V0l3MEhDMmhSMlYw?= =?utf-8?B?RXhWanlxRkdPaE5oYjF5VWQwU28xTDJzUnZOMkQvdGdNMjhJMGVVb1BRWXJy?= =?utf-8?B?RjNVSFRZb1h4eHk0MTdTaE04QUg3emRRWlhFdDg3ZkdrTDVPMHRPdzZhTnZs?= =?utf-8?B?Sk5hSHNOSmdid21lUkxTZDZndktNa041V1hUQ1kzT3BldDBLRzdOLzZldWI0?= =?utf-8?B?VG1oV2ZNS0NTVUFsZ0cvcWV0V1YyYVVVOHRhQ2V1VDN2TDlmWkNsS3dmL3NU?= =?utf-8?B?UGtDdU5uVGVGcnd5d1pFWDMwS1JBc1ZDR0pFNTNLYWUzZ1BhV1pLTm1uSjMw?= =?utf-8?B?V2twdmI2SG4vLzR2ZThOM3B5NzFiYzUrSkdvbElOQnRUNEpESFJ2Sit5YmIx?= =?utf-8?B?UkJrUWJhbXVqejQ0NU9rUzdBNytITmVZTWZrWW9CS1lmb2NaZHpCUDJTZC9L?= =?utf-8?B?VWJLY2lnWSs3UlhyY1hYVno5VDROTlUwM0Q0QjcrZGVVeFRON3FWUWlJWUdB?= =?utf-8?B?eko1NU0yL2RKT3F2Q2JoZm42UjI2cVBXamFSdzA4SkpTRGIxUXBySlBaUThM?= =?utf-8?B?eWkvN2NncmI0SFpTeGxQOWhkYUJvV3ladTV0Q0h1azI5WnBLQ2tkS05WQVBv?= =?utf-8?B?Vi8zNFp3R1pDV1RRUGxzVUlTVTJLK2ROelJJYnNtOWQ3OUt2TENEcFFnSVdw?= =?utf-8?B?ZkZObFJFRmo0QmQrWHp1ajdhODYrejJvWEpvdXFrdi9WU0VUSmdnUlAzM3RG?= =?utf-8?B?dEVOR0xvVyt4T3ZhUUlQR3BqUzJQV3VsdW1mRzhOaW5uQUVUaGVhTXc4bnpN?= =?utf-8?B?bk1IRFk2cmZOZWFJbmxHeG5HOTQwUmlrUkJuVjd5Y2I4NnNVcm9jdnU1Z0xS?= =?utf-8?B?RHhrdjZjanRjMmdKWjV2cVJIVUlVN05XSlR3bDVWajdIS1FGamVIYTd2dFI0?= =?utf-8?B?a1hoMkV5VUxBcUltWUJOOVZ5Rno4UFllZWZCVmMxTE1teE9lM3EwaHF2cUxE?= =?utf-8?B?WFNvWXlQSlRNTUtyanQvdTFiQWdURHpzWGVSQ0IxSHBxTEtQOTFQMnp3PT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 028f4d3e-1996-403f-6b5c-08da6d26487a X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2022 03:40:42.2419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB1253 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jul 2022 03:40:47 -0000 I tried building GDB on GNU/Hurd, and ran into this error: CXX gnu-nat.o gnu-nat.c: In member function ‘virtual int gnu_nat_target::find_memory_regions(find_memory_region_ftype, void*)’: gnu-nat.c:2620:21: error: too few arguments to function 2620 | (*func) (last_region_address, | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ 2621 | last_region_end - last_region_address, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2622 | last_protection & VM_PROT_READ, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2623 | last_protection & VM_PROT_WRITE, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2624 | last_protection & VM_PROT_EXECUTE, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2625 | 1, /* MODIFIED is unknown, pass it as true. */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2626 | data); | ~~~~~ gnu-nat.c:2635:13: error: too few arguments to function 2635 | (*func) (last_region_address, last_region_end - last_region_address, | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2636 | last_protection & VM_PROT_READ, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2637 | last_protection & VM_PROT_WRITE, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2638 | last_protection & VM_PROT_EXECUTE, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2639 | 1, /* MODIFIED is unknown, pass it as true. */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2640 | data); | ~~~~~ make[2]: *** [Makefile:1926: gnu-nat.o] Error 1 This is because in this commit: commit 68cffbbd4406b4efe1aa6e18460b1d7ca02549f1 Date: Thu Mar 31 11:42:35 2022 +0100 [AArch64] MTE corefile support Added a new argument to find_memory_region_ftype, but did not pass it to the function in gnu-nat.c. Fix this by passing memory_tagged as false. As Luis pointed out, similar bugs may also appear on FreeBSD and NetBSD, and I have reproduced them on both systems. This patch fixes them incidentally. Tested by rebuilding on GNU/Hurd, FreeBSD/amd64 and NetBSD/amd64. --- gdb/fbsd-nat.c | 2 +- gdb/gnu-nat.c | 2 ++ gdb/netbsd-nat.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c index 398f1c18b33..a4ca4a53415 100644 --- a/gdb/fbsd-nat.c +++ b/gdb/fbsd-nat.c @@ -125,7 +125,7 @@ fbsd_nat_target::find_memory_regions (find_memory_region_ftype func, Pass MODIFIED as true, we do not know the real modification state. */ func (kve->kve_start, size, kve->kve_protection & KVME_PROT_READ, kve->kve_protection & KVME_PROT_WRITE, - kve->kve_protection & KVME_PROT_EXEC, 1, data); + kve->kve_protection & KVME_PROT_EXEC, 1, false, data); } return 0; } diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index 72314824278..5dd4d148c76 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -2623,6 +2623,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func, last_protection & VM_PROT_WRITE, last_protection & VM_PROT_EXECUTE, 1, /* MODIFIED is unknown, pass it as true. */ + false, /* No memory tags in the object file. */ data); last_region_address = region_address; last_region_end = region_address += region_length; @@ -2637,6 +2638,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func, last_protection & VM_PROT_WRITE, last_protection & VM_PROT_EXECUTE, 1, /* MODIFIED is unknown, pass it as true. */ + false, /* No memory tags in the object file. */ data); return 0; diff --git a/gdb/netbsd-nat.c b/gdb/netbsd-nat.c index c45df391afc..d3bf83d35f5 100644 --- a/gdb/netbsd-nat.c +++ b/gdb/netbsd-nat.c @@ -259,7 +259,7 @@ nbsd_nat_target::find_memory_regions (find_memory_region_ftype func, Pass MODIFIED as true, we do not know the real modification state. */ func (kve->kve_start, size, kve->kve_protection & KVME_PROT_READ, kve->kve_protection & KVME_PROT_WRITE, - kve->kve_protection & KVME_PROT_EXEC, 1, data); + kve->kve_protection & KVME_PROT_EXEC, 1, false, data); } return 0; } -- 2.37.1