From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2108.outbound.protection.outlook.com [40.92.98.108]) by sourceware.org (Postfix) with ESMTPS id 409BE3858D32 for ; Sun, 22 Jan 2023 06:47:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 409BE3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a3Lcr2As4LbRQg/S8DRqd2fnb8xxY4Jh5vXHqp9hagw8zvnisnGTHak426aOdSWcfEjpdkQD3Dl4fb+LYbJE61vMVWNq/ht9IsefuKP7RMsXL/YDyGpBWcx2c22pNzLPS/B9iU2knRfAoCHvMVFW1g7LfBSLDMVk1H+IHxCXT3fNOBYYrvKYspX32MjmwY6SP6+S03AdqwVUX4bPuv+vK0ZRR6/SgFYWOy4m0yGsYrWzGCTn2UFAaBZFDh+IVSaWowOGxI1JEGZ/z7vRQGR4MiYUzVGRxUr5hbhifrBgN0ikQU9ecekal7Tz/t7PSNgx6uHWpI5jCIotldgRoBEAbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P9++QEmGEh1ScUylvb0tV0VsZgMibGYlIk6CmOvNr1g=; b=DA6Rvz9uGHPWxDYwl99leHEKSkTTgQ/7+gs96/xgB32vdKWTdLIGTz/ok+FrICEJbiR9dSvDLKM/KrP9M1HJzcGAzB+PRXL9U7frntVCka648V0zNPlZ1dT9VN0wuMX/EscwlZ1mwI0vaqftllLxlot5pIdw6Sc2lHSgaU8s1avHdynW8k2NbEqmJFjTj8wqkcnRtF+BNQT6WXzV4oAhI+3Pkvl8xAFCvSVx16UOCBSeXT5zKnOZFPt1fXlKZm20LoD1YAJZU6DWyjtlfQAeDlCf8bkwXHPWr+7Z9aKkSRa6RPJdK9A4KaguuZ8xBRVsH07cJdSeh1cAZxW661XHTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P9++QEmGEh1ScUylvb0tV0VsZgMibGYlIk6CmOvNr1g=; b=Qk58YgKk/Af/aRLh+FMGcjqzYD/shZLtQOg84qM2sZZxngWo8bD7zghB/FcA/a4fsoKYNyXTW/oTX0WAwZVfs4ph8uj0qYmin9wRLwTvHinZYr0aNB90o961aie6fSsROOrmiANr3ZuK7RhliYV3o3eb2QXYF9DjWSiFxXCOCOM53PVpHyjJX2AhABCJ75Jn/4oH7FW7Ytzmrv2MQnqVQp1LTQLuA6AmVmGXoF+xwF/oBWOmwUdpBXotCylRtEnXb9csKa+Knm+ZrHyD0/ipv5KeJ1M0NNsUYydlnPk2SwxmvHtH2YoybG4sWBo9nQ2Yr4W05l0YIcPETI18b8I5Hw== Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYVP286MB3150.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.28; Sun, 22 Jan 2023 06:47:07 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::c90:199b:e178:3fa4]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::c90:199b:e178:3fa4%5]) with mapi id 15.20.6002.028; Sun, 22 Jan 2023 06:47:07 +0000 From: Enze Li To: Tom Tromey Cc: Enze Li via Gdb-patches , enze.li@gmx.com Subject: Re: [PATCH] gdb: some int to unsigned int conversion In-Reply-To: <87edrnlsq2.fsf@tromey.com> (Tom Tromey's message of "Sat, 21 Jan 2023 10:09:41 -0700") References: <87edrnlsq2.fsf@tromey.com> Date: Sun, 22 Jan 2023 14:47:02 +0800 Message-ID: Content-Type: text/plain X-TMN: [VmvkPEH/63fMDMsjVl0mYp2O9z5GC8Ka] X-ClientProxiedBy: SG2PR06CA0181.apcprd06.prod.outlook.com (2603:1096:4:1::13) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <877cxfoyl5.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|TYVP286MB3150:EE_ X-MS-Office365-Filtering-Correlation-Id: faf908d3-3ef6-4e28-983a-08dafc447a73 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /ZCgishsXeB8Ho1W6iVdqeWYlO0jKMD6zrcofd3/qQyrxIGNiwGBKAxUosUGrwIFivXLNCbYhl8ZXK/qeBiXQ/E6D+PwEg4pdLmK+4SrPye7atSbLMBsdKDW/A5DUKnsxl0dlcIXhVmym7w1zdYbZoFRdtpPfpBHcjGmMB1rS32D2VwPhUZWUunkiCKEaD6NqdDsS41QQA02xLHIE+1irHAZ3vuCU3y0Kgs8BvVpbre3uwjlXniEgDLkPyXKh4MNt0K69ri9B81zTKPBf6IBlnXx8Ow936khoxikWd4mtdddKwXdVax7WAUn39syrpa3oveH9RGqxlA4rGSt6idL2AzAGVbRjcCUBJkcnLcb0zv7UltSFTK+AHqXYaHi0tsT07TwaPKR3RPpB2lM+Wpz/w5RlSL50+mJ0pbu6apdyeVWyUs9hzUg/R+DbM513eSDJlvvd8vfC0gXM3nFNf1McFnjp1z/a8Ua2qV7+Z4jITfWClsg0cqDd9Lnl0epie/v8jbO84mMhmiKvhshbugwMgQAll7F9hPRS6Hig2zZcpc8VtKk7iKimY3QFB7k9OayihNX/mIaBBF4S0q8Af3Pj7XY8NjGWP6NoNa8kMP3p7uSjYQsAhj6scEKSCdVB6XEcg7oSM40ZhqPaTz8Kwe9Tt6MwuclR3LUG3FZoEtZoDQ= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BGRzCaz4rv0zIhUYxIa3lEL+oswhqio4ukHR5EvaHBts8E0xG4UWfqzhN4eX?= =?us-ascii?Q?WzirV8fo9+RjiX2f4WOINMwScNlV7UF0919XMoskKHeUHNzUHo2cyQgd9JEq?= =?us-ascii?Q?LmY7KL3H2DjTp9AXpGn/pfm1PxtYGMsoIwlBwHKpa/Tig5qSoE/tRgfwHZzV?= =?us-ascii?Q?47YyWDOPDV1/YUWvDba8D4JOMmKZIeTGDsaDIjCCDdhi7SlABenOgeBsqp4s?= =?us-ascii?Q?9TWNyg4+bWi19WJtpqegbX9mIgCrlKJA51NNBwK8hHF4wI+yCaM8M8JsETi6?= =?us-ascii?Q?vrx7FZJ9hmmFHFpwx0sk40N9oXAqcP98jLshX1Q9vwgc4AgGLoNo2Tim08LB?= =?us-ascii?Q?wdWcosqAXUpk63Q/I/uDL1oI9Z43EaKX+H5k9h2Jfi6eSgVPeZXHgRuvB+nI?= =?us-ascii?Q?rr6W3rX+I2spFaUdtYI0aYsYoye/4jURCMqbM7grvWgRSizxQckflsmOYnne?= =?us-ascii?Q?FH44DymuITKHALF171gttSNaRPLgXj/sNIUGkK428xOXWunMCXMwmSYk/HBi?= =?us-ascii?Q?IuCmO+Qp7439p2ef7ACJ5o2+quBZWU6GiNKeGV9nmh+ZnppjoTfglhSj61+f?= =?us-ascii?Q?+Niondil+pnkqCoB6VLLuP/7Jk38RKKpiK65Q1+zVTcFdcSUZvdOgZeCD9BX?= =?us-ascii?Q?4fLJy/erqNafyCTam6fipgVVlq+2bY6a2IK3vZIjt/JJhw8fGyqstQIZmpTM?= =?us-ascii?Q?JCRJYa9/1PZiBQhKJ61AJ2R1Q66cADovcRWpMHw0EC4BIRD4kWw7IkEQPrwD?= =?us-ascii?Q?CxkM7pRYcUHJdRjVCG8uKctVgrmYJE3pvA6psQiWHX0UxIaG1ht166UMPxuC?= =?us-ascii?Q?LLcWg3E3F0S15AswZOn86umQ74ml6DERXQstq+nqGR8xcWrwg1OA7ZNHftfr?= =?us-ascii?Q?lckvVDbmmrjqPKD4zoK0UGNFe+QMSaJDRXJrqq7ioXNcPx+o/5dckQxtIVZg?= =?us-ascii?Q?O9jnHy7wSTg1cJbRcJCA8xjVtXUhcezCoc/hl13YO/LznOLgwMHYf+tCFvmc?= =?us-ascii?Q?btM1yc9Ad2gUivmsgx8GmdMofoUeDQvPuJfFwLst2raYwhbw5FhddwBXyzvM?= =?us-ascii?Q?ccF+r7jw5b1z5ynNidyiWVQbvpwY0VnFMBtl+V1QDYxrB0nlqJdKCyw4FBlQ?= =?us-ascii?Q?fzjNUa9np1NEgqAMz//J+CTRyxWXgTPWxBz7OpK9lAWM1YNKlXyIt3aouOvY?= =?us-ascii?Q?NEz3GTmc5i9d+crJA0IlK/gh9q/7AYO5IIbTcy7lJMiWhYG3ae/IWGRKjOII?= =?us-ascii?Q?htXzHuyQrKHGezwV7NC9iX1mdWehG3bjxFG0nHz5pg=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: faf908d3-3ef6-4e28-983a-08dafc447a73 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2023 06:47:07.1061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYVP286MB3150 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Jan 21 2023 at 10:09:41 AM -0700, Tom Tromey wrote: >>>>>> "Enze" == Enze Li via Gdb-patches writes: > > Enze> Work around this by using unsigned int instead. > > Thank you, this is ok. > Hi Tom, Thanks for your review. I sent v2 of this patch to the @gdb-patches list. Sorry for forgetting to Cc you with your email address. Maybe you could see it in this thread. Best Regards, Enze > I tend to think we should switch to bool bitfields here instead (and > other spots avoiding bool), so if you want to do that, consider it > pre-approved. For this sort of change we like to also change the > assignments to use true/false rather than 1/0. > > Tom