From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2059.outbound.protection.outlook.com [40.92.98.59]) by sourceware.org (Postfix) with ESMTPS id B1BBE383F0B8 for ; Tue, 13 Dec 2022 14:29:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1BBE383F0B8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=icKgiNxq959mVRuUKLqgsMW7RYFR4DEveF7+4SP3YFCyE7NW5tr7bSDO5kGdQW8bg6edC8DtAg/qD8RlaNxW4ZQV5Rl7wqaDUnPwDZ74PcVfEd5KtSwzRQ25tv3bp/CABdlWYh9iJFmNTAOjNqLobtZKCZHDVR+F8psaT/aJt5TNekhQhi5NR+vf/J6+60ywEHVqTElLZ5+aJ9dna6wISY5KcRsw8GY0Ls1UfD3sH79OL9HaNO59Yb5+lC3omzJjdqzjavacipJXJy6gQG/4uHebKIFvWoQlBRxShKjaZZrae0P9wcKMyvuuqqMWxzTZwcvMdJ8HHzm7LKfy65KkzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qoDgSZND4LZRq8qAjLPFHFdjKnaLxlLWYIwxA4GK1hs=; b=DvOo+bNDS14oJJc0Fk9n8lR793QGQiYPxvIAMLJt8a9MYfXoOeMr0G0ua/+278uhPE7AiSEDqToG1hdbN2Vkp5bxZYlqNNj0KyZc/yCpVVs1QrvZU2PUMvl1LXb2B6qNC5tLHdW5fLb5F8PQcU+ZonjmObyZmGnCilCuOCXbr0QiIMkMHfTDAFg2xRH/Ym4mB4fFjYzUDTuxxXDMZERCm+8Tp4CfNqgiN2HUK9TOWE4Qxwr0n/hbKENLLLtlqEkL7fxhhbV/0Afj18TbRCMz//gZ67n+DuTBaRGgFg1Hvl2qfx5uxpILZc8VCc8oHEs2xUDDyYNahGawgTpnu1lFrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qoDgSZND4LZRq8qAjLPFHFdjKnaLxlLWYIwxA4GK1hs=; b=i1OZzS0fdQ3wmyZRZ8TGMXoWwONjMwzg2eZ1X0tLXZSIcVJujYOhHa6ijberZ2tq+EwGsVlfB7TkdsEshW4hgc1SEod7boVCJP+uS7FFSnyXhMiXqFGIrEnmlyJVJ/dsx/ppGrF9FBt/j7kqurKc7LqXDFV211HNFQdtdzcdAp2QvEa3fRVrjJ4/8J2MmVkqMhOzCqXSlbeRiJnKLPjwEOE3H5zJaGxfzedLviQWITdE/X8Q7EX0S7oeFFblimjLuAZSdkMYKFJdOrficpQ4j2LqB+VHfDuir6Hf4p0GiuX/YFWHIgJm/g8YykIcN1lXZZlcpvZ4teejl+TC43yP1Q== Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TY1P286MB3215.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2e3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Tue, 13 Dec 2022 14:29:14 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::c90:199b:e178:3fa4]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::c90:199b:e178:3fa4%7]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 14:29:14 +0000 From: Enze Li To: Tom Tromey Cc: Enze Li via Gdb-patches , enze.li@gmx.com Subject: Re: [PATCH] gdb/testsuite: update a pattern in gdb_file_cmd In-Reply-To: <87tu24h3n1.fsf@tromey.com> (Tom Tromey's message of "Fri, 09 Dec 2022 10:45:54 -0700") References: <87tu24h3n1.fsf@tromey.com> Date: Tue, 13 Dec 2022 22:28:27 +0800 Message-ID: Content-Type: text/plain X-TMN: [+JzrbEJgzDSiBXMswEQGcxqddm1cS7Z/] X-ClientProxiedBy: SG2PR04CA0194.apcprd04.prod.outlook.com (2603:1096:4:14::32) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|TY1P286MB3215:EE_ X-MS-Office365-Filtering-Correlation-Id: aef9938b-b2d3-42b9-8709-08dadd166758 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PHnVphXAHoHyqvIj0JlOPUPcNK3M4CbiMo5v9Ck7cvIWXLgOZjldTaYDzWRFPuU06rF3+WY9TVLycShGNY80YTvtturSAuurqIoyhgbzcv8HnhErZ9TBGwTNuvkJDXhFwEwVWx7PfiZMPRlWVqiqvnjNgNqpIbRAey1sGCui9CfU5yKJmoASX/aBN0zEiRNpviDy/5Elg8ka8JtfsxAKVm0Hkztp4jZhLe1eQSNbHTB2C3Qm3DEdm+d6X1dWVwK/HabLzzVCWpnEMfWBMRVvMazLQfcZB6RyeZZ9rzqLWepRDsfJWyA/t1jcN6cxbXPJ10CHlPVPWFszzsAmRdWd0H4Xi2HJaKt3oRHfwyasC8P0YHdNvzbtLxIvkaiiSyk8JQ10PRjhI9XdTOnu6StA8i8yVG9BZVdQf2eGMYJE0f9dI87q7OJbHwgHVDpjqjg2xM5BG3I9Pm80ndC6GYS/cE5z37GvONX2XXUuYPqrJPEc2apNklNhX74ceRwpvDwOobFxPKrxqZfD8lMIhmsID/rsY4BL243rX2VM8vK2W+dCoYZB5NBKfX4PTWuwGZV90c10qSZYqgBdV8FDYT5+qM48T5H8uP6bkeUOJEnYP75ENDUNofGaFG/zy4/HkS/R3pJRG3bKakDU6SaC7rqi4g== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BaHK5PSZ2OYXcfOIG8bZeyX6A/OvFmn4pOORe4PwdtBtP3v9TS2Fe9E70jhF?= =?us-ascii?Q?JkHzz3AK3NXwPQG4kB2gvE5pgvivUOe6U2TvUSmYPrVVTgHV5J37BOq+feHt?= =?us-ascii?Q?iiVvflnCiWDCwZr7Dg2i5bogt1pBzauFBPxIRkM8ZxhEUnAGYTcB31d1gHvY?= =?us-ascii?Q?lrrpAB6XjJBJE7U/bmAyCdq4oGX9X4kcekscEY1RY1VOqrMeFvNz07gil69d?= =?us-ascii?Q?ux5YcR3SK7eZ41rbXVbML6iiUWaWeT3cRHC0UdITatdbeHx/P8QaGTriMI0R?= =?us-ascii?Q?SC4nuhAWVmDnB8KeXl3foLiQXM2XiR1i4MypIsmN/2EOT2NMAQBCr99eKnlS?= =?us-ascii?Q?H8Fzv9h3HofKIl9oVnTDaUk2snRLvw/wymNzQW3FCGyQ29WH5CtfVH0Ua5gt?= =?us-ascii?Q?vOMzTnwyXQf2XVexVz5S51tmC2VSDQz1nxPteIpHGr6AQqKEO2I/3cqzYHq/?= =?us-ascii?Q?8tYqLeJJuO+9ELQqvjxyJvJKFmM0/6N9ZFu6ZNVG6vpunN3+s7VUJQ9YFVgK?= =?us-ascii?Q?9sssuZ5tiwg6nI+gqmBDaYiq8zheICxMXbkUTWOTlPe/dRAcnDjUawRAC9SK?= =?us-ascii?Q?oZD+wQdGmrhZjvnOorHB+X553ToI6/O7vWliS5mcGgiWCBkbQP4q8538hvI3?= =?us-ascii?Q?covivI9TY+kDd1zAnPtRkYe3cKwl/tOwrbhcN4C+GN2vPeRamO97pyIVqQLn?= =?us-ascii?Q?Irfck3vzfpjsxPs5rxWN6zaB3rpeeaWTESXzPHks7DqQCRXB3HLLDB9SGqV7?= =?us-ascii?Q?9meWqQdEb87sJFEy9XWwF6UavQjFOvVAhSIahC0iwpEZpgP3H095i898QwWx?= =?us-ascii?Q?9/ebQBas1FQpRYpiTWXhMZjItJ7atZ6YD8P48K6By7/4E5YrW7ziQODcuDc/?= =?us-ascii?Q?Vwh9rH3U6e6618b/iKWLVAEpaJvQPo567sYyWv0EqsqVEcwJRLTv8MqSfxxU?= =?us-ascii?Q?KZ5mFBKbX+1myjqYKAFeh2ZM8bPhVW7a7Q8vzIVltpljXuVO3RZ0cJw8IR8G?= =?us-ascii?Q?EmLeMyu/rZCJrKn56HZzbZ6NEoQRcLqgeLcDo/2Mt/AhSLC0rtjT3x5Lbqrh?= =?us-ascii?Q?8SLV9lkvWLceQ8txnEyIPd2CZ46KE3ARj8hZUA3lfFQ4sDT2UtgoDyZCpFHG?= =?us-ascii?Q?HiyFmeOKiQHu1Il1bqNBNdIeyPthXtmo04mkfpG4SUgzfvPp/CK6F8PNP9Ns?= =?us-ascii?Q?dEXjtjDFZwiirZMJ1yTohhJFpOjjKJLCVlk2ECMopAkNWYj1l/fdujIXyIN1?= =?us-ascii?Q?fxLuv2vuhkx0JpQjiMkkWL9z2cBGV2ajC0hIz+TYYQ=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: aef9938b-b2d3-42b9-8709-08dadd166758 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 14:29:14.0159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1P286MB3215 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Dec 09 2022 at 10:45:54 AM -0700, Tom Tromey wrote: > Enze> Then run the selftest.exp, I see: > > Thanks for doing this. > > Not your problem really, but these self-tests have been difficult for a > long time. In the long run I hope we can get rid of them entirely and > replace them with unit tests where possible. > > Tom Hi Tom, How about we document this idea in the TODO list? This will make it easier for others to know about the requirement. --- a/gdb/testsuite/TODO +++ b/gdb/testsuite/TODO @@ -195,6 +195,8 @@ prologues will need to look different. For sparc, the immediate field is 13 bits (signed), so I believe the threshold would be 4K bytes in a frame). +Whenever possible, replace self-tests with unit tests. + ^L (this is for editing this file with GNU emacs) Local Variables: I dunno if this file still makes sense, and since it exists, I guess it would be appropriate to document it here. WDYT? Best Regards, Enze