From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2058.outbound.protection.outlook.com [40.92.98.58]) by sourceware.org (Postfix) with ESMTPS id 2052E3856DF1 for ; Sat, 28 May 2022 15:09:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2052E3856DF1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bLwEtD22VasFig6Od7HLjzGx7KN9puMSqt5LpY7nyFQFaZbZ0wDF3TEWwdePhvepfU88jRDHWiVUgvoGwc1d5xmG2VxU9l8VOXDxC+NeGYmjQBfcxvnkRb+rmVoS+XHduq/CwkE4FHyRN2MBlSNMTzpxt1nFPzWzntut8LGw1vO5bkjoZoRypEKXfD5vYKOPrU6grTr6SUMffsWdmDb7ORi9sfPqBRu5+YWja2BFcmZY4C0IeJE30PzUFoko7uL9TmBUY0dhi2vdkA4AN6f9QvVgZw2TW/p+uedJHlh2GzzaIZ05bpElfZ6xCFO3vBkfvwSGH6VyyvbwKYx42IKG8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RLEMyNY5tuj2yY5XGDNJ9OVGAJIWhl9x7N9pAtSmDo8=; b=ltEcPoedio2HuGNnF8SKfe8ZYilOSbQsOlYChbd0xoYxiwKWQuu4cCmrZtvQbX7CGI7hIP6nycG5VLcu1JnYOTK6Mfce7T/80cJujVPoygePzrVSMI/mOHg1vMTTl/SHkNVF8SGtyHqBPtq8f0V6ELQo54qPdOh0wfCc15fQm3GjjKUYvKW5vhwfu45l6PsT45IhGokxD6wLiudJQSax9ERgYNOPWEVDApmclXl3WfFMW7/f8U7Pn4dl+9rHOS2KY94IeRQZ+dDTHwphWGjGS+ROVzwBcInK6wn2NE6ooQvf9oAG9nzf3jK//EYOZI4mJIU+65ZxFqldMlKZXRyyJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYYP286MB1196.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:d3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Sat, 28 May 2022 15:09:19 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd8b:c4b8:61a8:3d0]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd8b:c4b8:61a8:3d0%7]) with mapi id 15.20.5293.017; Sat, 28 May 2022 15:09:18 +0000 Message-ID: Subject: Re: [PATCH] Add gdb.current_language function From: Enze Li To: Tom Tromey , gdb-patches@sourceware.org Date: Sat, 28 May 2022 23:09:14 +0800 In-Reply-To: <20220527173642.1180218-1-tromey@adacore.com> References: <20220527173642.1180218-1-tromey@adacore.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 Content-Transfer-Encoding: 7bit X-TMN: [/2IpV5E9UJ+lpa/IE9cf0qcDQwLEOAti] X-ClientProxiedBy: HK0PR01CA0069.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::33) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <7a0f46cbed2acf5d18b571cb0caa1a1dca3ba80d.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dedd5f52-38a8-4f17-3754-08da40bc09aa X-MS-TrafficTypeDiagnostic: TYYP286MB1196:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e44KsU87fQb+Ra2Om923ymmORJSxDnoLwhHMFXforgbPUSrqepVyfuN947kN0MEi6l6/IgJIHw+n6fs8c50oUR20cmaONO2jq5X85ToDHD9/NjRHmtzeQtPVhWg7TP/JT18Vz8EprFPJ0Tjht6HLYx7ZtspTCaO1azonW8cc3AH/N73bsepuFecsyqwHW39nEAHkftciq3iosUg14CZNzAvWbmYyrBezbw3oqc8OIFaan/7vAst79lvfqbLymj7DEW/YunPH3E1U3tSv51GtsLkiOK005lXYLOKKf+nn11gcLxhs8sLRX/oIB78ghKGFe1UqP3a+gJJ4Y10V5X514+KX/+7zL7WVI0uDkaRgKvoXz1rjwu343eXRdiKxhQXfKO4UDLHCCFa/LqawVfA3hZICMB+V80S2uWp/Xx7vHVcS8gy1DnGQDy3AzT5wT57lvvfFi+ljIf9tBlxiNURt9MbAd/BAp9IISlX8m4V0bFxRQ0w9Y7AYWHGeucotqdJrvQ/1O+hJHRML9v9RozLRHoj4uiu40SQD/L07cKIRY56RzoZOo2jwBYd5errJUKabiACBUpc+6H9A0dJ/MuUy1g== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3F6d3FmdmtNVXlTZjVTdHhxV29MdW14RjFnOHlJb1pDcDlxSHZkcFpRdlJH?= =?utf-8?B?SnJXN3pyTW9ySHdUTWw5Wmloazh4aVJCYWUyVVlFUHFWR1dJSStMTnF1dFRj?= =?utf-8?B?ZkZ1K0VkeWx5Q3FRNUs4ZXh5Q1VLMUtwWCtMQ2NkYjlXbDVETUg4QkhVMmFC?= =?utf-8?B?d05SODYvMGRCTklXa1ZRb3hGOEVnSVlwWFo1UThSWEpTRHd2Ykc3eFUwNkhl?= =?utf-8?B?bGJBWXpkUzR4MnN4RXBraEp1aTJBLzRyVDVsLzc5N2FLMUtSd2NESFdNc0t2?= =?utf-8?B?UW9yVUVZazlyQzg2UE1PazFqQmhwV2xBMnBvR0NsSnk3bExKYjVoc3o4NFJx?= =?utf-8?B?d2Z0UW9xWWU3aDNJdmlFUEQzekRFUHhzWHd1aHpGaS9iM1B3RVlwWmp2U3Rw?= =?utf-8?B?SGhmVjdZNE5jc3Q3VFpZMkhiOFF1Mm5FWi9LWEczUUNhb2NVOGNmK1F3alp6?= =?utf-8?B?bzFXelpybzFMMzg0ZXJyeVVBdTZzVjRua0RWUk5PTGRPUS9rK3UvVTV2VXU3?= =?utf-8?B?ODdVNE5NTW0zYWhrbW5hbk5wLzdWUmZSVmlXR0ltZTVTOWtiTlZpalI2NzJn?= =?utf-8?B?YnZTK04wWXB2aDBKY1pLVXZHWFNteE1tdFlVL3RSNWh6SUFMK2RyNEZoWlN3?= =?utf-8?B?VWxQZWh3dHpIam9lZnR2cXJ4YjA1NHlFQWI0a3doSS83S2k2UTdDaWZsSSs0?= =?utf-8?B?VmNoMmU1eVpqajJzNDM1MXFVdHc2Y0JaWTBUaVdkN2VBcXJMN21PUGxFWDcr?= =?utf-8?B?NTA4M0pZS0x0TW12dmxkZlZzWS8xOWgwNlRNcTZINEVOSzlCRW5GTVk1dFlP?= =?utf-8?B?eUdrdjlYZ0RlYzMzQW0xc0orZ0xUN2ZDMmJiYmZJOEhWcGJxdU5HZzZaTEkr?= =?utf-8?B?dndHTVNCdW5nN04xTDBBU2VMblpEWHFKTnlSdUNWckxHSmNCOUtVVC9Vbm5m?= =?utf-8?B?ellnYlpTZ042c0Z3K3VReFplQytpa3A4RkNPb2tpamdlMFROdTRPNG5UZ0hG?= =?utf-8?B?bnlVcWMwbUxjNE1IaitWSFY4WkZndWw1MUtkZm1XUG9DdlEzQnNiZTJIaGRE?= =?utf-8?B?MXMrQ29Tb2hKam5vaENMbjFtVmI0M2ZxRnJuTzJESWJtdTgxdHVNNGMwaERk?= =?utf-8?B?enNLZFBGaGpnVjB5Sk5IaU9kdmVXQVRKMDNHcUV6ZXlTdFZMbjRqM1VSWUNm?= =?utf-8?B?ZXpBOFJ6NzRvRTV2enU1aWxEcFlJVDFDeDVMTGQwcDBjOWpQYWtIUU1WQk9w?= =?utf-8?B?NEg5RmZXU0hPaExQNTZFOE1xVUJCQW94QVlZYTVZUmJlU3B4SHk1UDdlMk5I?= =?utf-8?B?dFczUTV5ZGIzS2FQRzBlVS83MHo2MHVuSkdtaG41b1Y1anVmMzhkMXlvVHBo?= =?utf-8?B?Vll3R2RTZG96alZYdWhpZHJyS2FXajNnUHJVK0g2QVFBTWZFVW9HK3Z6SmZD?= =?utf-8?B?WW84Q1h5ZFZwaVROYTVneVJsd29NT0pmUUVKUzIxVU1wMWVQenFQUHhQSGNk?= =?utf-8?B?MXQyMmJHVEVScG54N3VGd3JCSGJoZEl1NmVsMk5KT1JzR0pTN0tQQXlBNzJD?= =?utf-8?B?NndDUExzNDJTc0JXTzRhQmg2ekdNZUNCWEt4UmdBUFl6bVAwSjY3OHF1cmVa?= =?utf-8?B?MklEdnRWMFplWlJmS0pvUHVpMlNVZE1pL3JGYTRsVWxaZEh5N1grU2FqYnlF?= =?utf-8?B?b2QrNHhZdXEwdW14aDlDdmNrc01kTkZYaGtzTHM2cXNNcktuYWVac1N1QjdN?= =?utf-8?B?R0pBTmhsRGEyUkU4a1ZiOFdBV2RGK1BraHFEbHZQb2VwTWxYc2VvWDBvR0FK?= =?utf-8?B?bFRIU2grRzR6Y3dlTHJ0TjBCQmYrTlFVd0Y3aG9tQ0ZOLzlwMngxOGtxYmxj?= =?utf-8?B?elgyMG55ZDkrUjdJQ0srZWF3MG9Hdmt1dGRjQkl5QXRJOVZ4eHd3NnMrRmR1?= =?utf-8?Q?DW5x3nMOMSw=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: dedd5f52-38a8-4f17-3754-08da40bc09aa X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2022 15:09:18.8400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB1196 X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 May 2022 15:09:23 -0000 On Fri, 2022-05-27 at 11:36 -0600, Tom Tromey via Gdb-patches wrote: > This adds the gdb.current_language function, which can be used to > find > the current language without (1) ever having the value "auto" or (2) > having to parse the output of "show language". > <...> > > +proc_with_prefix test_language {} { > + gdb_test "python print(gdb.parameter('language'))" "auto" \ > + "print language parameter" > + gdb_test "python print(gdb.current_language())" "c" \ > + "print current language" > + gdb_test_no_output "set lang rust" > + gdb_test "python print(gdb.parameter('language'))" "rust" \ > + "print language parameter for rust" > + gdb_test "python print(gdb.current_language())" "rust" \ > + "print current language for rust" > + gdb_test_no_output "set lang auto" > +} > + > Hi Tom, I see this patch and don't quite understand why a test case is defined here but not called. Do we need to execute this newly defined test case? If not, please ignore my annoying interruptions. Thanks, Enze