From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2067.outbound.protection.outlook.com [40.92.98.67]) by sourceware.org (Postfix) with ESMTPS id C897E3835690 for ; Fri, 22 Jul 2022 14:11:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C897E3835690 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZywbWU+nWWcM93TWAGXgSbM3Wul23mu2EAGQda/C/JUuoooqbd9lWfAWx5eby7onNgWBt9OALdlH7mwgnj6hTBPXdK1oXQ/trA02OrQ4g3zlWVIj56uTuuU2c6EftyzOFNaRABigfzKfRYBOCgl4W0pMm0sOeKudd/vevy5dAKiG6U3UhntuTWt1NqNj3LKuHyxQ4wjFGYSG6gsNY0btE3IHSCeUVhOw3dqcizaUxsslxRiD+DmtAziEocETd2DdbJC7nzDH9Br0plHlfr+xmz8drhOdbRS2Z3G3ZY/8zSL2zCoL/53SekMn0Mkk7ybkVqG7PJb8cZZNK3NlAxf1HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4UuMVTlLlGRAZ+7x6UlkUJ1VMv17bDNus2bIBAKOHEw=; b=lJdTQFjbnm1tV77OJGq8sVhIOZ48fX4zBby5hieO1xIOiKpRny0R9muYzevP1l94fmTLjVTIA7V4iV8aRsGSV0pQyXZushdztrMKdE9altFvW8U6mqV9ifFl5ahgulDYuGYhvyjmThtrFCQrXkIWBRzf/Sy/zSbj5KB2WPb+DKmO3Ubvgfn3mWAzjbwTltZfs/3sCGvIr6yJSzvYqK/MPk187KaoKj4SxUzbAXPJzFGUS1uMZ9tuyHZiUfd6drVhE+Q/G6sXwY48eRKBCE0iakSUmlqJ/KDFuhniEDbJrPKd3E2Nf15cylXBsjpJjjVyRUD4R++klyGCLEM+7VpxOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYCP286MB0576.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:4b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 14:11:48 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%8]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 14:11:48 +0000 From: Enze Li To: gdb-patches@sourceware.org Cc: enze.li@gmx.com Subject: [PATCH] gdb/hurd: pass memory_tagged as false to find_memory_region_ftype Date: Fri, 22 Jul 2022 22:11:15 +0800 Message-ID: X-Mailer: git-send-email 2.37.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TMN: [n7Estd5EVoT/dUAXCLUSgQf/hlYP4ItE] X-ClientProxiedBy: SG2PR02CA0112.apcprd02.prod.outlook.com (2603:1096:4:92::28) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20220722141115.8328-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0786798a-1e77-4d35-92d5-08da6bec1dd1 X-MS-TrafficTypeDiagnostic: TYCP286MB0576:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jbQcItxpSgiAgn35grh647pHdi9/U6LV382nW97FQQB5MNmlOZ/MPzyDiu8F7j0iPYSh4jDa6IcrTeaGrx97eh8+aSo9wKngG4fne3rtqrhybEo/cPM9ACWmyqPL294FojmKzK4XM7oTYKmiu0wMkF1IBIYGIgoHI3FRDTXa07kpFz0pAZV64itdBX50emSONyXYoKsyA4w+QPIqxzhQ2IdUNrLPld+CDhoQf/Xo9twhbjdIVXlJRhsLB6AU29g29/MQFKO9s9qBJUIxfuoACOsZEbi5MZ8EEdUDC+5KjO+Ye3mJlTd67D1qQEsE1kn6OlLnbntO6IeSTL9VJ/yeh/M4rMHE3T1qLL4ao+iAFhMAF1q5Mfw9a2lYzxGTEQARWZgn7MFkUBH2pxHKnoUOzSgggInMbNqeIDmY7zUj3A5GB1oggZCXAfpuj1hAM128hJLtVPeIgGrh6wyhHzkiI8wP349hp92SOr+q4vmZIVHszY+QkMUksib/Y1aZ2aLc14yp0d5ieP4+QOepJLPgaXTviNDhYFbT+BfpBUVuIWvhI/pE4cejx7xwiP9AM5QvCRzwu11Dg/RHkljWlF547OHH/YMbtn3kNc2oB7dEQ1JMpnGYwOaaMgGZI+MTasXdnBQtfR6l1EiBJrgVJ+05KQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkU4c0cwVmxLbVRhL1VaZkp6djlDWlROR2REUXVLNXpWTmhxeC92dGlhdFkw?= =?utf-8?B?Yk5mTjgrcC9UNUFEMmdJL3pHckhTRVo2UEh3dzdjOXRzRXNtV3dmcGpCcnk1?= =?utf-8?B?UG1XMzBUUHJhN2JRNmVRbldhc1ZZYkI4T3BaZTBsWjJQUHl3aVhhVG0xcFRa?= =?utf-8?B?bllDVmdwSGs5ZFBzcVJDTmtEc0RtM1lnbzhmKzZTQkI4ZjBRZUdFcHYwUXFh?= =?utf-8?B?d2N4SnBGTFdYMWtzbzcwYjhIdDV0aURGOUtZYzRuQU1rcFVSOXJvZ0kwcHZ6?= =?utf-8?B?WlZjREVMVVpURThjODZIYXl3Tk9GNVV1TlhqYit1N2xPZXk0NCtLSmMyZEhz?= =?utf-8?B?ZlhTOVFxdGNCKzF5dURrSFQyTnB4YkdUc2VrUnRSRDJzcVhPcE11Z2paWmZ1?= =?utf-8?B?Z0pNaDBmNGN3VWJuUGdaMFVPdkJlRUlwVm50MlRNMUxlbjhyYTgxc1NIdFhz?= =?utf-8?B?WmsvRnBMNHlQaS82SGNINEU3MlpLdS94ZUVIMEVOcVhDQUJoV0c0UXBYR21Y?= =?utf-8?B?TFpWbng1OU51S1dMZmUxOUxJaDhCVHFlaWpuRHNqVysvS09raFJEZFJvaVRI?= =?utf-8?B?cCtZbUFteW1zOXpmdndyZFYyOHhXaTZZTExhVStibDRac0JhMHZRK2cyUFdp?= =?utf-8?B?K0NQWU1RSG83SGF4M1c4Y3JHZk1sd2VPd1RnVXdoblJLd3IySHVoSVdMMnBk?= =?utf-8?B?bmFBanVQY1BKdXd6d080NmVlWUNHMmJ3ZnZvOTM4dmF2bXdJYUtTSmtOcWQ5?= =?utf-8?B?eTRNL0NQRUs2V3BqL2c2NmpRK09RdkI3U0VNYTVlL08zVHRaMmY0VVhxNmIv?= =?utf-8?B?c001d3c5dnNOYnM4bkF0VVBHcVdJN0dLOHRqeVoyeEFzem1OYzNUbE81dXF6?= =?utf-8?B?MWtIYU01UXFsTmtTbDN0bGFnd01xUEZuaTVRTlRjUFpDOWlWaHNUZTUyVnBm?= =?utf-8?B?YnNKZ3pXbUJLNkVaMVVNZU44bzUyYW9OSG9EN1hISmF0RFd1QzF2RzBNVUpG?= =?utf-8?B?dUxWcW5OZTdCSlB0QjF4ZmtYbDh5RDdnMEY2UEhrRS90YktBWWNBNkFtRCtJ?= =?utf-8?B?MFpkRGlOakxaUDMyTng0ZjltK0RvY1k5VXJneC9FRTF2QUxrMFRabnNacXl4?= =?utf-8?B?S2hjOTVTeTdUUEtId1VoSy9UbWtYUmJEMGl3ZFI0R1Q4bGtJVk9SaUVrdVcz?= =?utf-8?B?NTlrdFMrdFg3RGMwdW5vaHZCTGJWUS9PaUFSbkszU0k0a1gzVkFsWEpaN2pW?= =?utf-8?B?YUV5VEx1dndEN1RrOVRBYWk3NTNaSzkwbVJ1Tm5xRzdWVXhqRUE4V1pQQUpt?= =?utf-8?B?NW5tUlN3NEN6dDgxYWhjdUVXOElwSWtWOUMrRGsyMEJWWVlLTFBoL0lnYUFN?= =?utf-8?B?SmNFYXdlU1RrSm96d1RTSCtEaGh0cnlJTzhqeXN6Q0xsOG16dU9QMDVYb1RU?= =?utf-8?B?V2M2UjdWRGl6bjZkZ0NxMDl1UllRazdrcGFhU0ZBMEtCUTJ5Ums1WHVNbEI5?= =?utf-8?B?a01kVTl6NzYyUitIUUQ1Zm9CMWlyMXJTclFkWndJeDBhZS9zbC9XQTJ4bEtx?= =?utf-8?B?L0RBa1h6cVJJT2NQOERRT3Nxc2RnR1BZTkdmUjUwQ1R3aURMMjVHZFJFUlJY?= =?utf-8?B?Z0lNZ1RxMnRLb3R4cmxpVlVUaXRLMk5GQkxFdnZZcUd1R2dibEhCM1EzdmRX?= =?utf-8?B?akZ4dU45WXBqTVhQRWQwck9YUVBXdlV6bHJvbGFvVG5LazFnRFIvUGd3PT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 0786798a-1e77-4d35-92d5-08da6bec1dd1 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 14:11:48.5729 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB0576 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 14:11:53 -0000 I tried building GDB on GNU/Hurd, and ran into this error: CXX gnu-nat.o gnu-nat.c: In member function ‘virtual int gnu_nat_target::find_memory_regions(find_memory_region_ftype, void*)’: gnu-nat.c:2620:21: error: too few arguments to function 2620 | (*func) (last_region_address, | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ 2621 | last_region_end - last_region_address, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2622 | last_protection & VM_PROT_READ, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2623 | last_protection & VM_PROT_WRITE, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2624 | last_protection & VM_PROT_EXECUTE, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2625 | 1, /* MODIFIED is unknown, pass it as true. */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2626 | data); | ~~~~~ gnu-nat.c:2635:13: error: too few arguments to function 2635 | (*func) (last_region_address, last_region_end - last_region_address, | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2636 | last_protection & VM_PROT_READ, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2637 | last_protection & VM_PROT_WRITE, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2638 | last_protection & VM_PROT_EXECUTE, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2639 | 1, /* MODIFIED is unknown, pass it as true. */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2640 | data); | ~~~~~ make[2]: *** [Makefile:1926: gnu-nat.o] Error 1 This is because in this commit: commit 68cffbbd4406b4efe1aa6e18460b1d7ca02549f1 Date: Thu Mar 31 11:42:35 2022 +0100 [AArch64] MTE corefile support Added a new argument to find_memory_region_ftype, but did not pass it to the function in gnu-nat.c. Fix this by passing memory_tagged as false. Tested by rebuilding on GNU/Hurd. --- gdb/gnu-nat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index 72314824278..5dd4d148c76 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -2623,6 +2623,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func, last_protection & VM_PROT_WRITE, last_protection & VM_PROT_EXECUTE, 1, /* MODIFIED is unknown, pass it as true. */ + false, /* No memory tags in the object file. */ data); last_region_address = region_address; last_region_end = region_address += region_length; @@ -2637,6 +2638,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func, last_protection & VM_PROT_WRITE, last_protection & VM_PROT_EXECUTE, 1, /* MODIFIED is unknown, pass it as true. */ + false, /* No memory tags in the object file. */ data); return 0; -- 2.37.1