From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2039.outbound.protection.outlook.com [40.92.98.39]) by sourceware.org (Postfix) with ESMTPS id 8181A3858C56 for ; Sat, 6 Aug 2022 07:39:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8181A3858C56 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P49ZR47QxMqYaj+yGScCB+UHprPIWRJlCEKUFtSa8n90PX6epRvasCUuBJl8R3ZQimXsL+sD1VEBm/3gLt4KCDx3wFX2KiV/t6Y0UcnxIKHtkM/yEIg66m+3kvCxbbUZ8EwinZmjBrBaHbw1/ZaSeJEwg9ctXY0fnPy0PsxwaYu7Uj6cA72QbeRuOEFy32bviHw/OWLfCtFOOTenLz4QKDyl6HFKLkjsWE9APi+XmncSxHzkMSLg7IaLHq0YITtxxSip1QepG/9WBOolX9EfWcGoMAT0PQZu7+wdX+DzE5V3tKErIUJ7Eflmi4e1gu6IMLDHLhuC3NC92g4MNbDffQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LFjuypCN/ghRcGEOUy+LcLlQ6xGLJaqELz9bfKis/d0=; b=ZIr7i7xK/NtBXzKGS3wq/0xDVGrTn+HpPL1rwcHAdNpL/Nit/LFlUm/XrA+OpHewMyH+O/BxoGsaX5WC1rXlBusFN+pb2uIlbQYuR84cZSNbeUmtNyR7d9b/GRPcgcePyb3h5X1gLGeLaUaxDl1qR8QGicNBtQrnfTY3xNFoulgughAfjNe9S1fueji9eOyNmfZs2vTX96YKQzMTji+I3B6cAz9ZA0eBqOIQOCMb3yUxnVejjkzbaCtPwHM02uWEOFqCiSqBKvu1r/WtrCtjQFvvOsspUQUt6Y0VFyuYY+bajFx2AyjxQ2tkDvNDdKzKBy2qOE5UtYdBQCtZVHNcmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYWP286MB2665.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:24c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Sat, 6 Aug 2022 07:39:25 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5504.017; Sat, 6 Aug 2022 07:39:25 +0000 Message-ID: Subject: Re: [PATCH,obv] [AArch64] Remove unused struct From: Enze Li To: Luis Machado , gdb-patches@sourceware.org Date: Sat, 06 Aug 2022 15:39:20 +0800 In-Reply-To: <20220805154800.48136-1-luis.machado@arm.com> References: <20220805154800.48136-1-luis.machado@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 X-TMN: [i42WBR9NaEI5qua5cLwRf6j7QxwOXnrd] X-ClientProxiedBy: SG2PR02CA0042.apcprd02.prod.outlook.com (2603:1096:3:18::30) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88a224fb-14bb-4167-115b-08da777ec906 X-MS-TrafficTypeDiagnostic: TYWP286MB2665:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /LtER/K93dm+yzNI1LnB80flRpYv9AJ9KNLl7J9SPJT8QUq05qWHl33PyhSPJ7QZfNgz/Ee6Wrh2WxDahIlKYAlTIvVfRgqVO8gv4jRtwe3SswEr5jgHkGBE1Q9y8WE86rApHeqPMz5KJb4dYgCG49mQ+paxM/b4WeRJF3cmfm/Y7DV5d5RMzLYHIJ10QwW680kDHzCgBhgJg7RvwczHQ3VzsW9Effh8vQ5+OPOxaYSOyOB1T6ZdZGyua6mAw1VyUVW3ftqACNLHkGVWhfNGaemkjZ3Cko0hj/3yVYqYEvqR1wLc9c7Wmd0ezlCyFzSy7vCkmz0Yx8GQ5KdUF0e2TOh/kvSAHF+s1US/ThJM/2ggPh+SFS5DB/bbcPv5/NIi09Hc/gtAaLjH6wznKxLE4KnE1kvWe1yU3fdGseibd7v/mHzzZfOJGQA7se62AqOBgYo2P1jOfZw0yWJyZTFQ6qhBzBC3YZj9KthssH2zBWQP65rLDpmKlEk8Flu3XXaIzxKk64zXBIyT5t/K2ac+FOmPxemT8nZGmTwoMjFmy5+S736rXNc7E14LdtdY5da00TEGS7hiox5SKuDGZWsvRPbhVcKvSsQYKgVoz0+26jAiu6SBEW0Kx9OuZBMBAwACu8GHeE32qVSoqExdMauyqA/R7idMxzGXrIC0d1NBzJLYeVYrcBloSt0JbH9Hypkh X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXlxQ3hpYXl1SDlISjBrYkoyTWJCN2UySDkwUVhoaUVqSjd4OVZtRXhpUGxm?= =?utf-8?B?T2NSWFRFQStoZEczK3BDLzgzT2FxM2Nvdm9Ua1ZocG9VeDkxZU1NOG1pQ3Jq?= =?utf-8?B?QkdpRnNiQ09jNHh3a1pPZzArcmJReVlzQ2NvSFZMWEM5VG9vRXNkM1dGWjhx?= =?utf-8?B?NkszcDVJM1gxK09RczZnSjlVWlB1SVlaNnhDanhsbXZJQWFaRGtjalVVS3Jr?= =?utf-8?B?N3hrUU5DanFrMEhidk1zRlg0TWRhTUJHN0ZBNXlnVkR5WCtaNWlDdEhHK3dO?= =?utf-8?B?aHduMUFIYVAwK2xVckM3Z050bzBZalh1ai9vOEltY3BlRXdTZWdSNlprazBM?= =?utf-8?B?bmw1dVdpdTYyOHZ2OEZ6bUFoZ3I0RkpqZmJMQ3RXYTZnRXlmUlloQVMvZ3pS?= =?utf-8?B?WG1Cd0NtUGFyeGVJb29wSGZGc3VRczRlZXY0UTBZODhEN2ZZaEdwNk16dUtN?= =?utf-8?B?RW50cjI2dzR3RmNacm55bG9ua0h2cHg1aEJBWG11L0tndVhTTFFpWlVOaEJn?= =?utf-8?B?WkdqK0pIS3RJdmtTbDlINEpyb3VWalBmY3BiaHBFbUtHSlZTaElGZkFKOVlO?= =?utf-8?B?emdiMWpTQllodExseXBaWFFrRkxuVkl5Qm42MEY3UTI2aFZwZ0Z3Q3VGL2cv?= =?utf-8?B?MjVJN3V6YkxBNFhpYy9FN2R4eWFNM2RYTk1KbHVEK3dQME4wdnA3aDFKcVZZ?= =?utf-8?B?SUpOUjc4cDRDWWVFSkF5WTl4YTBHcGdJODd5UGcxZytmV25wQ1BqaEN4dVJW?= =?utf-8?B?S1JTSTcwUyszaDhpVEIvNHAvWWdEME81YkdFUW8xemZjTFJSa3VuaWwzMFcz?= =?utf-8?B?clVFbEVNOG04TkZlcmgxc3hBRGxiQjZYSFh1bWlSK1NUTGk0bk1IR1ZIM3lW?= =?utf-8?B?VGNKZGlheUlLRDhoZGhwODBtak1xcEo0eEY4VGZ0Z290MlVjWklpNzBmVEhx?= =?utf-8?B?WTJwZ3Rpb3dOZWJlNHhwU2JSODVEa01sd1BaUnhjc29qOGlvTEFrOElFRXhC?= =?utf-8?B?UGhWdk02d25jMzJqTjBlMVFmTXpxM05Tc3p3ZUwwMDFOeFdZV1RDdWVnczh2?= =?utf-8?B?WE9EVnF3OGk3cVNkeFhXZjdWVHE0TkE1MW84QUhGd1hodFN6TXRnMkxZczhz?= =?utf-8?B?RFhSTTlaeHZNcnRzOFZkS1BONTRDenpyL3BJdXFZTkN1S0Y5STZ2b0dSKzJ6?= =?utf-8?B?aExHWWwwejM2eXFWUDN0RGRyb1NVSWl4V2ZWc3h5cmY4RERQWkptcFV2M2Vz?= =?utf-8?B?dkxBRlViMkd1bmYyNndkTWV2QU5tM25KTG53R0RYQWZRMkRjMUY0N3p2amxa?= =?utf-8?B?SU12c0NOZ214NWMrN3Y1WVNTUmlCSlVBdEUvenlOdGFxbW5HNmliczAwblNT?= =?utf-8?B?WkJkb1F5cmU2dzd0dFlIRGpDNlpwQWFSRktWQ284NTc5cGMwUWtjTmxrQVZG?= =?utf-8?B?LzRLWVdWTFJEczE0WXdrc3d1WjBiZkcrUUNDOGFrS2s0aENQaTNHd0x1aFZR?= =?utf-8?B?QVdieFlCNS9tOE9NaHlkK1NCbldmSEVZbzJHUjBqREpkclN0TXlZUTUxOVRX?= =?utf-8?B?dlplOXRMVmJkd0NqN0ZzM1hTbnExdXNxaVFyOXpzTFptNUhrZFZTYjFpRmgw?= =?utf-8?B?SzlBY09nTnoydEdLbW01Tkg2Skd3UmFjam4vZS9oTUdsUDM2ZEhQcHBRNVF2?= =?utf-8?B?bEV0MDNEQ0c1cnlLMG5zd2gwWVNQK3FVYmxsZ2xQUHVLZ01ndVVsMnFRPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 88a224fb-14bb-4167-115b-08da777ec906 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2022 07:39:25.1361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2665 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Aug 2022 07:39:30 -0000 On Fri, 2022-08-05 at 16:48 +0100, Luis Machado via Gdb-patches wrote: > While doing something else, I noticed struct sve_context is not used > anywhere. >=20 > Remove it then. > --- > =C2=A0gdb/nat/aarch64-sve-linux-sigcontext.h | 6 ------ > =C2=A01 file changed, 6 deletions(-) >=20 > diff --git a/gdb/nat/aarch64-sve-linux-sigcontext.h > b/gdb/nat/aarch64-sve-linux-sigcontext.h > index 1b40ffa8ee9..a166fbda7da 100644 > --- a/gdb/nat/aarch64-sve-linux-sigcontext.h > +++ b/gdb/nat/aarch64-sve-linux-sigcontext.h > @@ -21,12 +21,6 @@ > =C2=A0 > =C2=A0#define SVE_MAGIC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00x53564501 > =C2=A0 > -struct sve_context { > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct _aarch64_ctx head; > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__u16 vl; > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__u16 __reserved[3]; > -}; > - > =C2=A0/* > =C2=A0 * The SVE architecture leaves space for future expansion of the > =C2=A0 * vector length beyond its initial architectural limit of 2048 bit= s Hi Luis, With this patch applied, I use the following command to check, $ grep -rn --exclude=3D'ChangeLog*' 'sve_context' . ./gdb/nat/aarch64-sve-linux-sigcontext.h:48: * sve_context.head.size >=3D ./gdb/nat/aarch64-sve-linux-sigcontext.h:49: * SVE_SIG_CONTEXT_SIZE(sve_vq_from_vl(sve_context.vl)) ./gdb/nat/aarch64-sve-linux-sigcontext.h:52: * If sve_context.head.size < ./gdb/nat/aarch64-sve-linux-sigcontext.h:53: * SVE_SIG_CONTEXT_SIZE(sve_vq_from_vl(sve_context.vl)), ./gdb/nat/aarch64-sve-linux-sigcontext.h:59: * will need to remove or resize the sve_context block if it wants to ./gdb/nat/aarch64-sve-linux-sigcontext.h:65: * sve_context.vl must equal the thread's current vector length when ./gdb/nat/aarch64-sve-linux-sigcontext.h:74: * guaranteed for a struct sve_context written by the kernel. ./gdb/nat/aarch64-sve-linux-sigcontext.h:79: * the start of struct sve_context, and SVE_SIG_x_SIZE(args) is the ./gdb/nat/aarch64-sve-linux-sigcontext.h:102:=09 ((sizeof(struct sve_context) + (SVE_VQ_BYTES - 1)) ^^^^^^^^^^^ I noticed that struct sve_context is used here, which is eventually used by SVE_SIG_CONTEXT_SIZE. Although SVE_SIG_CONTEXT_SIZE is not currently in use, it could cause a lot of unnecessary trouble once someone uses it. Other than that, there are still some comments that refer to struct sve_context, please see above. Maybe it's overkill, it would be nice if you could deal with it. Thanks, Enze