From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2014.outbound.protection.outlook.com [40.92.99.14]) by sourceware.org (Postfix) with ESMTPS id BE8423814FEF for ; Tue, 7 Jun 2022 13:45:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE8423814FEF ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WaNgV+S6ml8uk31GB8/blD11hVCpXLhl4jlg5SqMwjZI7mUi3SLyDdmHwbl54npXFC2xTVXbThGTUWPWUV8GHCcgBXWuCgxHQQev/J543TLzvzKooQs4qiK8sMT8UtqsIfGE7EFqhP2L4L7vcI+O1uU07JivHmqkuUFox6/uxgGYC/o1nmK03lcJHh0KpOKRvoYfcIAVjF5MCNcqFKOvpf1+zfYpHlEON7Rnj1qHd0xt/Eyuyhq4QJ4hGSLszMJ5vK0Bq+u3TF4fj4N3xJSXbpeEHdZUozxs4S5gYfVj0yEebWi/WJv0GtO7TF2Y5C/yQo9dCDYXbGF0fVSL3uu/MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RSqEeqim174+qlnkTBh1ehWciyI+UCqt8wqq+k0XXbY=; b=BSjDrJTowTsnX3sk8rsIY65p1TCSDwHwDtg40ShrJJ06XXLA0WP5iTRYCgSHIsGISxR7YZiMNcb2sGzQTn0LEBx0T3V24Z3steYaormuLpSjFQA3WJ/4cG4FemT+sFFgLrJcXBqGkgWNd3/AI/4k7COmKxeGVF2L/lHDxF+6eGiWsffK7yLsMvl7NbfKbidUjBBYNQD9DeUzOkI3ihT2iXkGjVo+kw2z9RsalfY25hO9ttaAYfnqLqSILtPzKA3phqEYXspaCauZUC8howdDY6t5YefojptKMZ/W1064nqfaCZjdVgrrQZfxhiJYs/zvsViLSuGwmn3HqTEg0jY25g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYBP286MB0462.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:801f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 7 Jun 2022 13:45:01 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd8b:c4b8:61a8:3d0]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd8b:c4b8:61a8:3d0%9]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 13:45:01 +0000 Message-ID: Subject: Re: [PATCH v8 3/3] gdb/python: Export nibbles to python layer From: Enze Li To: Eli Zaretskii Cc: tom@tromey.com, gdb-patches@sourceware.org, pedro@palves.net Date: Tue, 07 Jun 2022 21:44:57 +0800 In-Reply-To: <834k2kp31l.fsf@gnu.org> References: <834k2kp31l.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 X-TMN: [Hs8jyV6k3X3DyQw4p+SqbWYhZX07WUhV] X-ClientProxiedBy: SG2PR03CA0089.apcprd03.prod.outlook.com (2603:1096:4:7c::17) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <7a44834a86fa1f030c6ae01b703426bb13d0b96c.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19a8ceaf-8193-4d7f-d876-08da488beb92 X-MS-TrafficTypeDiagnostic: TYBP286MB0462:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4ZMfsEGu/nsmN+rxeOHmtFnfEyPUObAtrqrB2/og/GJBLewyc14asxLAzzmiIBjmrTOXvJQymgO/cFLek/7TN7Ac6FIv2rbn0fqg76mBNrtF91n8jEKjZ8JaCKcGtOT2ah+7gSLmUeTiR24/Bfs9aTkgIfEmlfhjSxe/uFvsHB/gjd0zTvZIbpjODr3+FFzTu2/+HSph5T5+uanOEVeq4tRzM16weEWe9M/DNMs3Ul4viqDqbpiYTK03vQGpumIqjQZcKk1HfuUy6lR2+6tpQN8Q2oxllnDMCYUsgDfttbkXEcH9cryq5LuPrGqZEAgaIUK+aKdiR5Tu+WUVHd8h8QAq+Ajw58Cscm64ChekDTKcdmkmtB9IfjFCNdY4tpFoKlLBe4J0EkaNhsK3xk8uHyLt2mokowNn2ZzwhhZzmEPNg/+OWmTEpcKe3N37DXxlvsL+ERvioZ+xrG/GeqJ/zERv95F9mGuY95gIwIAZs+0QOGt1eUem+kR2hG6EOJC5mN8IiQj7pLL3iHEF2PO8BEK7CsqH5nKo/l9SsAjQ1j9GXQZ0RQMcng1dYtmmj5fD4Z5m//R43igI+vTWC03x9Q== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjlnVjhhMEdsd1JUZzdFQ2NUNlJhZnBEVUdwVk9Ob0c0UXFSK0s1VnVmMWRt?= =?utf-8?B?TWsyOEFlS3M3YWVPM1ljR2RobUd2b3hRUGIyRzZVNnR0SDZyUHVmMXNCTHRU?= =?utf-8?B?azNiZVBQNURLZWI5bnFoRlBnbDB5NC9zZ3VqNENGaHR4R3MxVWFUREx3eENq?= =?utf-8?B?dTRUZTUzbGhjMGcxd0VSeCtNcHlsQWxwajZQTXM4VUJST3Q1RkNDR3RZOTZr?= =?utf-8?B?blRhMGFaR1Zadjcxb3VSQ1JzU0U3ckRibW1xaUhzQjZHa1ZEeWxDWlpHQjhv?= =?utf-8?B?YmRmdCtqNFpMNUNlUnpIUGxZK29OcjdlY1dadmh6REg1NGRmdUFiNUNWYUND?= =?utf-8?B?cHdBVm5DdW8yaW1SL1ZxTEVhRmpFU0c4U25Fbk11dThscnlydU03MkljUFNV?= =?utf-8?B?WHVPdUxEVFBleVFhK3I4TmNYYzY0NmJTNzF3RnRqTHdmZTFlYWs4Q0ZjM3Q3?= =?utf-8?B?SnEyWXFtdW8wOFZnUUpkVFIzeXljUXB2Yk81R3JUQ3BoWVFlbitzZnhrYzdt?= =?utf-8?B?ZFRaa29xditxT1g4RUJFOHdPRXMrd05BeEJKSy9OaGdJcjZMZVVDUTk3cnRQ?= =?utf-8?B?NG5DQ0h4U0lBME1IN1JsOXhLZU1iSGNFbnJOTm42czliTS9iUG0wbG5OK0Ji?= =?utf-8?B?ZncrS1pXR0FRcFJYRkU2bm1oeWFyUTNnQUtnaGlybzFiM3NBOE1Nd1lCeWNJ?= =?utf-8?B?azlkb0hjOHVGbVNBRDQrZFEzOTdvd0hLdFFkZ0ZKN2hwVUdYbmNZVW9LTFFs?= =?utf-8?B?cThIbTQ3WWpDNm43bnNScUNBeFc5ZFRMUlUwTmZ6d01LTGVsbmlrNVZreUVu?= =?utf-8?B?K2xXeUR1cyttYldoZkZjb1Uwb0p5ejhDNzlWd0F1bmpxQ1QvWUxINFJDL3NO?= =?utf-8?B?RGJxOElxRWVnZzdUdWdYNzZ5aXBxVmVPNEU3SUF2bnFMNHJQZkpYb0EwQjNz?= =?utf-8?B?cmo3K0pKeUt5NlNaVU04dzBkM0ZTaUFCTExSN2JkbkZuRHRRd0pBNHlhcHZE?= =?utf-8?B?a2s4ZzZoMS94dm5ldDNQLzBtQ0huVGRjVFZpTzlrdXZySEhWV2ZGK2swd1pH?= =?utf-8?B?UWNQZjNSUzBmaDdlcnUxRWFoK0ZoM3QxWEtlV0xLTTZnRi8zL0pRdW9tU25U?= =?utf-8?B?aFd1dkJMeVQyQ282cU02dTNuVDlCUHVtbzlwb1pLQVhoNzVRL1FwOUwvdVFp?= =?utf-8?B?TnRqVVgxVVY4blJXSmxsVXVPZ0J0cWtiWUd2ZGRNVVZBcDFSN3hIZHhGT2NO?= =?utf-8?B?QkR0RXZJaTdncDNIVVVRaCtFa2ZSNytSMXZ3bnRORUtwbzlKMzExOVBqaHBR?= =?utf-8?B?SmtDTzNCb05TOVBsU1lRREIxOG0yY2VKMWJkZWI0c3A3UE1JMVFCNXlJWnkz?= =?utf-8?B?WUdTSXgzZWdhQ0RmREwycVVRY2VxMXhRODZPbXpRV2RsaW1wSU9Lb0taUzg2?= =?utf-8?B?YTlEOU1uQkY3dlRMOU9vekFCTXlYTVZYQ1IxWEdEb3I5RVRkRHNMTlpadXFn?= =?utf-8?B?QmNDY1UvUTF4bUd1aFBpMmMweWhXUW5UUGFXSzJyMlBta0tCV2JnLy9mY0sy?= =?utf-8?B?V0M5RjA4b3Zoa29jMTQvQm9FVTJ1WDhENkk0Z2tQMVNHaGtOcFBodGV4YTg5?= =?utf-8?B?bWdDMXhtN0ZEVXVXQ2JBS1FRdWE4QUh2YW1RR1BhSGVZSG84VkJmVlE0SGtD?= =?utf-8?B?SVZlZjRCWkxVeWNmemFiWmJGWVJ2dk9WVldGc1FuVG0yQWVrTkUvZjkxNldq?= =?utf-8?B?VFgvc3lNZll2UENQVDd1K3NuWkd1UmpFKzhLdVMwcEgwanpDa0hnbW1FQmV4?= =?utf-8?B?RXR2NmNCa3hzQk8wL0tMeWxOSWgrMzlOa0NPZzF3Rng5RUljdHEwQjVJN0Zn?= =?utf-8?B?eWpiRGhSL1NXQnJhejkvVExFNlZaWWwybkZpTERRNjM5cjdWUzFBejhabmNz?= =?utf-8?Q?MWhxG9Z3pSI=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 19a8ceaf-8193-4d7f-d876-08da488beb92 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 13:45:01.8300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYBP286MB0462 X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 13:45:07 -0000 On Sat, 2022-04-23 at 12:22 +0300, Eli Zaretskii via Gdb-patches wrote: > > Date: Sat, 23 Apr 2022 17:16:55 +0800 > > From: Enze Li via Gdb-patches > > Cc: gdb-patches@sourceware.org > >=20 > > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > > index cb5283e03c0..5fd757d4891 100644 > > --- a/gdb/doc/python.texi > > +++ b/gdb/doc/python.texi > > @@ -1094,6 +1094,11 @@ union} in @ref{Print Settings}). > > =C2=A0address, @code{False} if it shouldn't (see @code{set print > > address} in > > =C2=A0@ref{Print Settings}). > > =C2=A0 > > +@item nibbles > > +@code{True} if binary values should be displayed in groups of four > > bits, > > +known as nibbles. @code{False} if it shouldn't (see @code{set > > print > > +nibbles} in @ref{Print Settings}). >=20 > The part in parentheses will produce better output if you use @pxref: >=20 > =C2=A0 @code{False} if it shouldn't (@pxref{Print Settings, set print > nibbles}). >=20 > Also, please leave two spaces between sentences, not one. >=20 > OK with these nits fixed. >=20 > Thanks. Hi Eli, I was looking through my drafts, and I realized I never sent this email. Thanks for your review. I have made the changes locally as you pointed out. Best Regards, Enze