From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2018.outbound.protection.outlook.com [40.92.98.18]) by sourceware.org (Postfix) with ESMTPS id 91E883858D28 for ; Tue, 12 Jul 2022 03:31:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 91E883858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cg9652KvAaVa3DYjOGEwGnSOZLTH1uyS8CuKcOWZjP6ExdOmeRTNj5BXnjxbnaUTsQljIOl2yvMimSgum2yLWo1w/7aBLPK6Pg02EUdeTX2v+0GhiPFW8d9Fj3rJASuDbYyhs6rGIZsG6xIApg0m21jee9Y08g9udE5PebKhlRC5ELwKuuCdwfE4pDoB1yBT2DOmseH1XlLz5EVEv5bVD+LT2v0cQa2WqLpC6A12ZCnWg+b5uE6nkXgscAu2urQGIBdwHQCrmmoC56wAC6HoR2eJ25Gw50OVqSZUMpp6qBfHg8j69KcDxe+9J8V8oG5tc1P+x+AyLUtCi468YUaRdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YWhqWhIhlExnBXo5i2WiF6/TUdvdu+6pd8+Inf6VuAg=; b=Ztohb1o9F45xuNmlClF2ktJ0G/k1ztuHz88rZU7TnFhOJ52D3ZWTEOL9eCqeYZucjpPke8OSIV4e5bEOPBBpqdEB/7xO/SYqdoyaftUeWG7MwBAtjQqj+Gga9n9isVs7r3Fk71EYGEEF8FVCgygHa4xIg89hA83ghQG049Nib4Yf3M3qemmEhGPdB20T81psWfSE5CBX3hW3Or204ea04H8e8Ud8e2qcpnJeHQdffepagrE9FQVkx2bLSccmSV3BaT2u4Ex/OYTOwq4zM00ItUamwp3YweDuYevliik2/tPsbz2aWGwfSTBcCAV0viul2Ln/ajht0ZrqZ2JoUAaaZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYCP286MB1658.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:183::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Tue, 12 Jul 2022 03:31:54 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 03:31:54 +0000 Message-ID: Subject: Re: [PATCH] gdb/csky modify registers list for general_reggroup From: Enze Li To: Jiangshuai Li , gdb-patches@sourceware.org Date: Tue, 12 Jul 2022 11:31:34 +0800 In-Reply-To: References: <20220712022352.9640-1-jiangshuai_li@c-sky.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 Content-Transfer-Encoding: 7bit X-TMN: [RmkFsjL4IKmD3Xh7Z0EVUbAjdyUgiIvI5z+m8Ff9c4CnG39hYnfhuWpcmAv0XWfnnhsd+36bqZk=] X-ClientProxiedBy: SGBP274CA0011.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::23) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f259dde2-3169-42c3-b3f7-08da63b710f4 X-MS-TrafficTypeDiagnostic: TYCP286MB1658:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: thyz9pI/sTv3J7oTmnIH8Tl4AVuSAuj/4fnO0hKGetSxoin7uX6SRVzzu14Ib4DewHKE2+WJkMhMpHRM1ECgLfoqfpgazhwmbQk0yXxJ98703XD0SVJ9YlJkJDZruqt+QDWtd/9l/M0H/2LffWYDSmpxk1hf8rcq367kAOxhX3oQ301oNabFmgooS8T8u/EzpHo2hllZppU5AbH6e4C5pd/gEnymJAPRJk5SGyvZZTe68r0kig8A7Ig1eZKqRZrgkl0aOA2xOL5Lr4LG07EQwzhty7D10StbYAfCLl+AsSbrYmP/bvTdKXe2o7pxFquKyTVDRO55CboKK4LnBog7IrAlNAcWfCOMKJ1ilX6vEuZhHQk0B+pVq8jxW2gpsgTImEUl+hAvlbmPSVwN7IzbPRkDtquCnza9dBfrIOs2V19m1hmj5JCb7r7ntaBesvUVHxrfFEBXDkSsUJJbwKjom26R3q8FVnoOnIzm2wYGlUFaSEGQzwoSIawvQWNgt4nr5sz1jQGSqzos27JhGHR62EUVLozOEKuGLSGu7GAXQydthy5yP4luCIllPOK2S5xjKyI5WVmYG1+WDtaZdYLg9d/sq9LJGfXlsdzGdeKmck3q+2Fi4oC10yzAq3TTWk/PRleW77A0QNmM3TnVTVZv7c8zXQ+8vEbQh72fZO/gjx75Ow0S2DlOTIXyUbAbrKLubwtgm6z4qhOcyghzpdmPSulafflJqjqeo8uBUjohql4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUQwdGRVeC8vYkFMeE9wbHBBTkJ6MFJNb0tFSkFWRDI2V1JxWk1nUHI2M3Rn?= =?utf-8?B?SmRtTlpUb3pGYnFISjArVWVDT3I0UkRadlV1Vno5cm0vZldXWDdRSno4N2tB?= =?utf-8?B?QzFwSkpJSlpnQzd5aGp5Y2wxN3hhbnFRVXVSUUUvWktwSUh5dm1Bd0l1OVNy?= =?utf-8?B?ejI0ay91aDhablBLeGRSK3J5U2FlSWlxb2R3QkhoSnNVN2JIUXRGeHRmVWdW?= =?utf-8?B?Wit6dWlFK3ZUQ3AvbTlHWGk2MTZYamY5dkppSVVaOVJEbjlYdmlGdm90VHJy?= =?utf-8?B?cXloL1lZTzJZTGNndmErNzVRRVJiZWIxZzBoOWNLVHFtb095SDdrYUNpSFdy?= =?utf-8?B?bGo2R0p4ckVINXk5d3pNQ0RaZ0NaSFJFclRIaEVlaWZ1dzM1czFSZXBoYXN3?= =?utf-8?B?aDR5aHZqeDg5UnkxWkZCbmRiczh3UVV3cWJjbG9uaXcwQkNmTENOWjJVUlEx?= =?utf-8?B?TjZTb3JKdysyRjRDaVE2QkhCN3NqQmtuTTZBeWh2RlpZV0g5M2c0U1JETS9u?= =?utf-8?B?cTQ2VHFreDVVVk9EUXBjd0IxT2ZuZk02ejBrZEcwampEL2lCTUdGYzRta0pO?= =?utf-8?B?K3FzRXdISjlNbW9kOWNCUzR3TWhmL0l6OCtuRFM4UFo1dTVyRlhIc21uY1Ni?= =?utf-8?B?MGx6cmFqdm9IdWlKY2Fkd0ZFbXZaR2Nqb1ZreG90V2JzN0o5WVpVT3dObWRM?= =?utf-8?B?RU53RkczdHNtYWZqRW1wZk42dS9KM2FuZ3cxWTZjU3NEbzJ1eFVyTG4zalZw?= =?utf-8?B?OTdPNjFTcVV6VW1CR3lXNlBDWVh5RThyTnRXYUtOdVBFWHczbjUwYVNPVzk2?= =?utf-8?B?N0ZqeEZqSlBuYW1vbDBYMDl2aWhUZ3MyY1AyYWZFbjlUbnc5b0U4QTVjaU9G?= =?utf-8?B?aVJRTXc5cnlsSFk1WktIUW9Eay9SbDhCcm5QQ0pkYW5PaXdDMGdHSXNZMkJ5?= =?utf-8?B?eGk4cWRieHBMbjNxNFZ0elFCWDE0M1hNOE9xRXRCZi9TTFk1dWsvYUN3U1py?= =?utf-8?B?V1V2ZUJpZ3NLUEpnTHdPNGUxWTFpVVVQSDdQN1BoUlFDNUNIZFhqRndScTZx?= =?utf-8?B?OUxJbStKUjF2SGYrT0xqUjdpTWlSa1huTC9QUktsUlRUNnZoZnJ0YkF1SWd5?= =?utf-8?B?M0NyUWdRKzFnVHMyTHJqRmJCVzNSTFRFSDFCZHdIZzY0RUMzMVo0dFNURGxz?= =?utf-8?B?NFoxaCtYMjNjUXBWb1NsblliUHZGMzdocWJyM0xHK0I1MkxmRGdKeDZ1djJy?= =?utf-8?B?S1FjOTEwQTFPdzZRWkxwc1dPNHRxNXZJR1pDQlJTTWs1Y2MvY1QzTHpyQnJP?= =?utf-8?B?M2RWY1hyZVNiT2Z2eG5QWEVqcjd1Zk10ckhjNWtIM0oyUm9aTCtXMXBVQTl1?= =?utf-8?B?Tzl2NXIzVEJSejFWdVZ3V2tTVWtjK3g1eWJlZ2FXTzhOZWp2M29YVGw3MXNH?= =?utf-8?B?YWJDWnBiODJSS1R2d245SWsvR3crdHFPTVhrb1V3M1ZGNENzQ1Rhd0R0YVJr?= =?utf-8?B?cXRVQlZSVDNBRnVFMjNKMVZ2UG9BOFN3WEo2VFlvbUhjemNRQS9BamRhOElV?= =?utf-8?B?bnJ6dFM3M0JaR3lnMnZqTzVYVTdRSy9kSGJxcFF5eUlLMTJBRmRNSFIzZ1M0?= =?utf-8?B?SWw0bC9ORXNwOSs2a3VtakFwTkZOd2hHRTltZ0V2SVhzTXUyNjFkYjBaOUM2?= =?utf-8?B?dEh0ZVFSS2JRMkxER3ErOHBZRGF4bVExQjNtbXEwSkhEOGwvaTFqTlZiWDM3?= =?utf-8?B?K2NnQXFZYThtRUF1d2F4R3V0Z3R5WlpnVW8xQ1JXVFJPZlY4aGZlT2c2Y3Bo?= =?utf-8?B?b1BqS21ZdHlwQXJmOWhBZz09?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: f259dde2-3169-42c3-b3f7-08da63b710f4 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 03:31:54.3170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1658 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 03:31:59 -0000 On Tue, 2022-07-12 at 11:21 +0800, Enze Li via Gdb-patches wrote: > Hi Jiangshuai, > > Thanks for doing this. I found some minor nits with the coding > style. > Pls see below. > > On Tue, 2022-07-12 at 10:23 +0800, Jiangshuai Li wrote: > > there are two modification points here: > ^^^^^ > there -> There > > > 1. for the debugging of csky architecture, after executing "info > > register", > > we hope to print out GPRs, PC and the registers related to > > exceptions > > 2. with tdesc-xml, users can view the register groups described in > > XML > > --- > > gdb/csky-tdep.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c > > index 502b01e33e1..fcdb865eb87 100644 > > --- a/gdb/csky-tdep.c > > +++ b/gdb/csky-tdep.c > > @@ -2518,7 +2518,11 @@ csky_register_reggroup_p (struct gdbarch > > *gdbarch, int regnum, > > if (reggroup == save_reggroup || reggroup == restore_reggroup) > > return raw_p; > > > > - if (((regnum >= CSKY_R0_REGNUM) && (regnum <= CSKY_R0_REGNUM + > > 31)) > > + if ((((regnum >= CSKY_R0_REGNUM) && (regnum <= CSKY_R0_REGNUM + > > 31)) > > + || (regnum == CSKY_PC_REGNUM) > > + || (regnum == CSKY_EPC_REGNUM) > > + || (regnum == CSKY_CR0_REGNUM) > > + || (regnum == CSKY_EPSR_REGNUM)) > > && (reggroup == general_reggroup)) > > return 1; > > > > @@ -2548,6 +2552,10 @@ csky_register_reggroup_p (struct gdbarch > > *gdbarch, int regnum, > > && (reggroup == fr_reggroup)) > > return 6; > > > > + if (tdesc_has_registers (gdbarch_target_desc (gdbarch))) > > + if (tdesc_register_in_reggroup_p (gdbarch, regnum, reggroup) > > > 0) > > + return 7; > > + > > Accounting to the GDB C/C++ coding standards (See here[1]), "Any two > or > more lines in code should be wrapped in braces". > > I think this part should be like this: > > ``` > if (tdesc_has_registers (gdbarch_target_desc (gdbarch))) { > if (tdesc_register_in_reggroup_p (gdbarch, regnum, reggroup) > 0) > return 7; > } > ``` Correction: if (tdesc_has_registers (gdbarch_target_desc (gdbarch))) { if (tdesc_register_in_reggroup_p (gdbarch, regnum, reggroup) > 0) return 7; } > > [1] > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Whitespaces > > Thanks, > Enze > > > return 0; > > } > > > > @@ -3020,6 +3028,8 @@ csky_gdbarch_init (struct gdbarch_info info, > > struct gdbarch_list *arches) > > set_gdbarch_num_regs (gdbarch, (num_regs + 1)); > > tdesc_use_registers (gdbarch, info.target_desc, std::move > > (tdesc_data)); > > set_gdbarch_register_type (gdbarch, csky_register_type); > > + set_gdbarch_register_reggroup_p (gdbarch, > > + csky_register_reggroup_p); > > } > > > > if (tdep->fv_pseudo_registers_count) > } >