From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2042.outbound.protection.outlook.com [40.92.99.42]) by sourceware.org (Postfix) with ESMTPS id B2D683858D32 for ; Tue, 26 Jul 2022 12:25:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2D683858D32 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KInSrUXe7tdZRPClaKN4PMlTeWIE3i7Du5PVBOb1VPVSHw++dw/2u2j38cu558z5ZKkiFbHbRfDuPXbVlQDgJUAabyATt0RXtHsE6sOVaEPWV5zRruuhtKeRBN5dRlz7TISl769Qr9fKSSBkq9fxNqkLPYnP8s0iqcTNwGvIuVnIJAIzxRtZjlnoYqNx7RyuV80ttu1CRJCp4ovtSHLKbwOZqyUo0CaAiTUSJKSTgFWoDnk7zlNmG2Mezkcr3M1EiDLqxv+Q02dM7VfkFvQWfNamHnxLpYx+wy3qZIkaT8vBnRqt4bUXfQSqgNQJ4MFqK6loS+N87Jpez70RnbnWvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ULcXrpnTH7e3w8dgLjTNQrk1pHf6GHhXJK1KVWVTNDM=; b=BGDGLdi+G6UFMEb/gJTL47vxXfc2mt9PfYcUy7Hrg01DEdA/3EsHLvnroVOPbywmvRpBpnHsPE6Y/tL8Ap3v2GTWBNZuse5quN13JXCeD2Ym7Z5AOfY77H6mKObrlnokGmOhczW3avkU16V5ieuzi5uwm0n4/x4Mf6aPAqzazp9Ub02WQoFRhSOq17MH4f84BXR1o2Nx9F3gxoDRO5NFsetqOGTabJ3Us4Iv/4/6STRMRs6nNoJlCMnVYhdBJ2w/a1IYov7mh5dC388OzxJ+NMywz7ohVIeUZQ9hsz5cblF/vQJXG6Oniz3Z+lAmD0D19u7wJqIGdWYTYlkmmttTiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYAP286MB0218.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8036::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 12:25:34 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%8]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 12:25:34 +0000 Message-ID: Subject: Re: [PATCH] gdb/netbsd: add missing header file From: Enze Li To: Simon Marchi , gdb-patches@sourceware.org Cc: enze.li@gmx.com Date: Tue, 26 Jul 2022 20:25:28 +0800 In-Reply-To: <96a2fc09-113a-887c-c458-72568967b78a@simark.ca> References: <96a2fc09-113a-887c-c458-72568967b78a@simark.ca> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 X-TMN: [ElPjnEClJTK5TRTIR/jPxQiUMZjEee1p] X-ClientProxiedBy: SG2P153CA0002.APCP153.PROD.OUTLOOK.COM (2603:1096::12) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 03df9e06-4f9e-482b-8665-08da6f01f009 X-MS-TrafficTypeDiagnostic: TYAP286MB0218:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X/+gaZ75V2VDSGUrfMNw2oXHScjVUs4zLKe6TlM3ktjL6Rb29/6mjoGYuYsuNWMRHvPmOwncul10ZEOrAWHHYK1UxViyScseH/5ZZqMaUVNIZtp+CP0YaDKeoykcgL/p4F9NUs+0JLgRi89uFymi/dSMwBEpKqqb3XEMrwPNzn5cOYBZ6mYWKdAHC5glWmsAKqwgFEX0LttIa5QbcAl5Tn4sYVD7K4PXbZb4v4opTiwjvXnEoNM88NFX4N5w6cIAeaKEPEs+HmOzDaqgmOGjdoFH0lZTix79bpTVKIOsLK/8nsBCxCxLinWgOQ3XHgsIdQZNlk/anH9l+2DDDQCmw0EIBaxpr2tWxUtP0zCt5IsOSyPWSQlcaji5TI7YJApCHkRq8fti3bFXVHcVD/KxkN+2aQ/8waY4Y1DsECwLgfoPCEf83QXK5pEmJxXPhNbTq+G3pml2WHWKmO+1g1jyCjvcb2k1lbuQ2f+nXWq1Re7NtQWVjW+6eHfR+ZB1czEPtOqqbajGENnewtq+qCn4IplIGI5vTe9PkJ70I2Dz5hHaDt9GkWIekVML0S6Fcgd5Digp7HcH0VlTQcMSNN8uzfNGoQrpcHWJMZ2jQ4ACalfpZiAOrXMJ5AjRyJbZ61TsAgYZE+ydIw/E93cZcHKIc4IYOrbwV6XUcs/5rTQe/xc8xPRt8qoJNzYaDymsyr3g X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QU1objI2K0hicGU4c0ZrM2JsQzFpblhDcHJEcytMaVFMcEt3cE1LM3RzN3ZX?= =?utf-8?B?YXBNWTFLenRTMHJkNVQzcFcvNS9jNXNIcEVBV1dHeC8rbHhZOXFFV1gvYTEw?= =?utf-8?B?TlBSYkEwSHpvMXlBdHArWEpBOGc2U1hWQWY0U1FUZEU2Q3kvOGwvTGNqWHhj?= =?utf-8?B?bSsvWnhtNWlTTC9MMHZ5dG5VT1B1WTd4ekhOeDQvUzdybGcrMnBuZXlPQ0lx?= =?utf-8?B?cVZpcmxGTk9BTlQ0UVZzNWs5L3VqVGNMVnQvTXlvdFBTVklOKzBMWXBONW9x?= =?utf-8?B?V2FRUkJ2ajdwT3JJd2R6UEx0bWFmZW1ISXdmWEpkbDZuOVFmeXJ0QW1NZVkx?= =?utf-8?B?M1lhQXU5V0N6Sk0yS21mRUVaOW51SllMNTUwNkZha3puTzFlNVJqOFUvS2M1?= =?utf-8?B?YUdEUnhQK0p1VzFMUHUvY1hkWHFXeWliZ01SaXhiWmhKR0hSUCs4OEYxMU5K?= =?utf-8?B?ekxoRURNMG1oUmpTbDZoaXl1cGl6UDA5c3JsSGsyVDFtT2dDTlZsSVZ2bSti?= =?utf-8?B?eFpEZWx1RTdIV2NsWFpKK2dmOVhNTjlKYStPeEF0aFU1UVRDblVra2FDdWJN?= =?utf-8?B?OFl5OW1wYmJNZjdHT092TTFnVmtXQldZbGU5d0JENjRpQlM2N2JRQWhOSDNs?= =?utf-8?B?VEo5RnZWcHZoYktqQ2NYN1FKekxIRHJmZExGMmNrQXVTaGZBNkdISEJwZnZh?= =?utf-8?B?L3dNaWYvYisyRUNTTHMxWDk4azhNUk9tQVBxUEx2cGJ0dTRzQlBpYU5RZUkr?= =?utf-8?B?U1BwcHdzejVEQXBYeXR4bGttTkU4VExLL1dsMDkrS2NTajA1aTZGc2sxbnVH?= =?utf-8?B?dm1iQ3Q5WkJ0eTRtdjNWekcvNCttS0pCK2VvZXVMMDJ2N2lrY2dRNURzbnRw?= =?utf-8?B?Rk5BblI3WHVMZGNuN3h5TlNuTndYUlkvbTcyS3dzaVZsejdUYitndzVOaTl6?= =?utf-8?B?SDhjTG4wZGFjNks1d1dJaGlySmNOREpCOVY4VU5wdlZBb1ByK1BGaXJpNC84?= =?utf-8?B?RCt3K0tYR3YvVFZlTlpqZFdmWGw3dDNXcUlYenhxVnBGeFJ0OVZSS0kzZjdW?= =?utf-8?B?Y3BreUVxTERCb1JhL0tUcU1RcUdEbFdPVzdYak9tclZMVTZ3YkJ3cStXQk9z?= =?utf-8?B?WGxoYVBTLzI1a0p3aWIyMFVPbkxvQzg5TWl0a1hlMG5sSkplZ2lDekVOcEVu?= =?utf-8?B?SDNlL0FWNHdpSFYzdXYxclhRcytNWStZdFRNWDhNZzlLaTUxc01wVFk2S0dp?= =?utf-8?B?eEpmWnFkV0xJTE5scWliY2h6NFcxYmo5VTBPNW5aaThWZWpVRHUwMmF0MnRI?= =?utf-8?B?YWFmbmF1eWpPeVlwTjJqUDNsN0Z2WmpsbXkyVitQSU5EbSsvbXBqNkRZZHpC?= =?utf-8?B?T3pOVnJRTm9wUXc4VTFoQnNuU3ZMTUszeHNLVm5SbHU3R1dlTWF6cGtkeUlP?= =?utf-8?B?V01rRFJqelNQTThucEZ5NWZKWWJOUzZSdXJJYWZDeGU5VzRRcmZIWDg4K21q?= =?utf-8?B?L3hhR0NyN0NDYnRjZDVtTnlIbWlQNXB6Uy9BUFhCejVpeFgvUGc1aWNvcUU1?= =?utf-8?B?K0VaMWRSMzk0UEdCVmtzOEhLa01NOXpNNXA5K0hobGlid3kzMU8yNnZsRFBq?= =?utf-8?B?Y1liZU1OSGtXQ1M1TFBGUDc0U3JYQXpNbC9pWjZxK25lSEVlUG1zaTdQNk45?= =?utf-8?B?WlBwbXZLU1JUSFhRY2pMOGdkekRDa0g1MnRTWm9MbU90NU8vRkJ4cjFRPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 03df9e06-4f9e-482b-8665-08da6f01f009 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 12:25:34.1979 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAP286MB0218 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2022 12:25:39 -0000 On Sun, 2022-07-24 at 21:01 -0400, Simon Marchi wrote: >=20 >=20 > On 2022-07-23 22:55, Enze Li via Gdb-patches wrote: > > I ran into this error when building GDB on NetBSD: > >=20 > > =C2=A0 CXX=C2=A0=C2=A0=C2=A0 netbsd-nat.o > > netbsd-nat.c: In member function 'virtual bool > > nbsd_nat_target::info_proc(const char*, info_proc_what)': > > netbsd-nat.c:314:3: error: 'gdb_argv' was not declared in this > > scope > > =C2=A0=C2=A0 gdb_argv built_argv (args); > > =C2=A0=C2=A0 ^~~~~~~~ > > netbsd-nat.c:314:3: note: suggested alternative: 'gdbarch' > > =C2=A0=C2=A0 gdb_argv built_argv (args); > > =C2=A0=C2=A0 ^~~~~~~~ > > =C2=A0=C2=A0 gdbarch > > netbsd-nat.c:315:7: error: 'built_argv' was not declared in this > > scope > > =C2=A0=C2=A0 if (built_argv.count () =3D=3D 0) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~ > > netbsd-nat.c:315:7: note: suggested alternative: 'buildargv' > > =C2=A0=C2=A0 if (built_argv.count () =3D=3D 0) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 buildargv > > gmake[2]: *** [Makefile:1893: netbsd-nat.o] Error 1 > >=20 > > Fix this by adding the missing header file, as it is obvious. > >=20 > > Tested by rebuilding on NetBSD/amd64. > > --- > > =C2=A0gdb/netbsd-nat.c | 1 + > > =C2=A01 file changed, 1 insertion(+) > >=20 > > diff --git a/gdb/netbsd-nat.c b/gdb/netbsd-nat.c > > index c45df391afc..8a4a43270d6 100644 > > --- a/gdb/netbsd-nat.c > > +++ b/gdb/netbsd-nat.c > > @@ -25,6 +25,7 @@ > > =C2=A0#include "netbsd-tdep.h" > > =C2=A0#include "inferior.h" > > =C2=A0#include "gdbarch.h" > > +#include "gdbsupport/buildargv.h" > > =C2=A0 > > =C2=A0#include > > =C2=A0#include >=20 > LGTM. >=20 > Simon Thanks, Simon. Pushed. Enze