From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2010.outbound.protection.outlook.com [40.92.98.10]) by sourceware.org (Postfix) with ESMTPS id AC8723858D28 for ; Fri, 1 Jul 2022 13:45:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC8723858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OlFl+SjRBkLTtGqoUOaMwNoyqaHkTlMiu8TYoL3qX6JC1eB26JnJef9xKytLLvHk9W0A/gz4NSb++XWFWZMa5qINgsldjYZ2I0V29txfnzJyAOILCUPxMMGhj0YxQFW4z5ujU2reT+M/YXthza3SPGhsCQ/keKwffLA/geeK5jiE8rDeg+Oh7HcJqLVeHUwmJfWo+rvW/9T92HMpModkakj7deksf+TeJgjN92opTppQXR3/0MyK9LmPUxrxlseGghnbWJqrW6mXFPZn6Ew2QOV62QSlF6tQGySlNwvo0SLqH6sLlAJR2bHQuS3tfOmcFGUNWsA3P8tHRBWyXj2YEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XdT+1BuvLlFQUPTuHyImAnZ0QzJRVHMAOTCmh91m9qE=; b=ba5q0CC61PsmJ3jTzSWP8s45rage+q8sMfn2P/5wDM7ei03zZbW5tMBpFn4urJG6iTM9jnLVXgWIDzQUBs8kzkcySrN010F3oMtdKwWQ0RCCF1ZmzWgpigf/N7C8rnlAZqVWFkjVtvJh9bT/XcBXorH9asrHHWOWNyjIZtBo0asgZ2aMwR4PSvtJkOwq6kL7tEeV7DXlHaXkcQAGry8x5ruq0bFS+ndxImRxy1CAyO1FzXdWaMumerumxQW4etAZ3YOWcJb6He+vQOzug9DLSVe9dcdNV8aimLHw3A7iJMkbnA4bp8Gd4KlEwY6oNhCOnY3j7hwmJiAn2r2SQFONDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYAP286MB0748.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:87::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Fri, 1 Jul 2022 13:45:06 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%7]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 13:45:06 +0000 Message-ID: Subject: Re: [PATCH] [PATCH] [gdb] adds `` to list of includes From: Enze Li To: Christopher Di Bella , gdb-patches@sourceware.org Cc: manojgupta@google.com Date: Fri, 01 Jul 2022 21:45:00 +0800 In-Reply-To: <20220628010427.1856503-1-cjdb@google.com> References: <20220628010427.1856503-1-cjdb@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 X-TMN: [AnT6BhCQaxyFfhyLHD8B/RDOdupdzJDd] X-ClientProxiedBy: SG2PR03CA0093.apcprd03.prod.outlook.com (2603:1096:4:7c::21) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba3fd33f-4d10-4bcc-4a81-08da5b67e7dc X-MS-TrafficTypeDiagnostic: TYAP286MB0748:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kh8mh8akV3Wv5V4oFqAz1UF5eiF7o+7OGV7C/xtA7qlStdRqgH/ujadwF95jTmTHAHxHnLoQ25HL5u/YfzYKb2Fh4Y4DkSroqp3XMS/Q1/BN70fkvCM5gR+kZ2St4+vD97mO7OZBB6Sytf9uTxf3uZr/mjFy26cYVYnnMq946fFnFqe3e+LAJ6VlbBIVLoYz4oyTZuF9M/nqH0reGlsoaK0kPvkRxQ1qVu803UDridFE7jkJ4UDMeYk3I9GWJ8qMuiZh9m8xjLw9EK+AI28tG2MhYSyzpkA6oOkz8RSN1hCS7SANKlhFEGssT0JPnsqCbybjm8K8cfRtCU+neWypExkSy5UWc0JfO1bDQr09EWsNkNUszIZLmFO7ay5nq/s3NApO4a1s+yK7D1LkbpmPRhjDazG9H3NBmsN7/A8h3rrECbWr6tD7UgaqffdK8nMD3rhQE4QTWkvXV4pKnbaa8XLEQ2gN9MknI7UK4T0p3u/+2q1/hPwspRtkaEmoKo2ElbsnsqG71d6/kKuPOA+ar3Rkj5TBFWbcF2qufM/hDy79hY8Sa3sTkn5lPn4wjRIvaN9zXZlyMKOVyKel6f7/d8lBcyiNp8YcpI4MRAla7x9Wm3jky/AqPsvhvufho5PcC9gQttOS6czpRDkYn85Qfg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0FUcEZKazdBRi9jU1JzVm5zTVI3dlhrTlhtKzE5VkhhdkIvQ01HRnlTOEVR?= =?utf-8?B?bHlYOEVVei94a1dTK29xb1l4UHBSbGNTcm1naEZHcmVFOGpQTkZ5TVAzYy9h?= =?utf-8?B?OE9EQU1iQ0pPSExYd1hCNStRY3VTMEt5d2U2ekxZWGdjelRFdnkvZm5obWhH?= =?utf-8?B?Q0lVU2UwMDN4Q0lmSERPRmZqN21ub2NFM0UxeUVRZU94OFMvUDRjbGoyNk1V?= =?utf-8?B?RGFtOWNjSWZURzJNUTdlb1FCa3I2aS9acGkvaHh0RXU5SUszKzBFMENaWUUw?= =?utf-8?B?OGdyR0VrN3ZUalNwc3oySklPVEFpeVNwSFRjMTc0aDRIM2ZMWENjUDUxNXNl?= =?utf-8?B?VnhDMkhFbG4zeVEya1pkbWtHZ2VLT3lUc3FqeDJJazZ1ZnVCUy9YNU1UZVZW?= =?utf-8?B?Nzlib0VLbDBiZTVGQ3NOM25hYnl0b2FHd1hsNURheTRjZk0vTmdBTFJVWWxz?= =?utf-8?B?bWpjUE5PS2JnT0NWL3lPbUJxOFJUa1BPMXFTUWxMYVVjSDg0RWR1eEovRXk1?= =?utf-8?B?NzdUUzJUQ3VCbnNHS3NDM2RYemlHblQyV085RzZhR0pzYU1BeG56WmUyS1dZ?= =?utf-8?B?R3BCb2pCNmtYUEZiYWVhZzJRYjEwNkJMSTVKQUphM1M3V2hBbHFvVkE4ekdC?= =?utf-8?B?cXNWOExJU05xWmNhbFMybjM3bmVaMUZ3ZE11YXJEeHY1M2QwMDVvK3dmdWRW?= =?utf-8?B?Zy9neUg5RlZXSHpRblJWcmZpbklxa3lQQlAwMHFPK0ZKcUZJSzNXQVh1MGRB?= =?utf-8?B?QlJvbTVpbnJZeEtKZk1zVVVNNExsSFlaS3hzdTYxdG1ubXlEcDMrSko1ZG1h?= =?utf-8?B?eHdsVDVjZ1Zob1BRbjdCSnFBVU1mSlpiQ0owaHJuZnFWTU1rVnVWSEttZkxX?= =?utf-8?B?dnB2N0UyR3hkRDAwN3BJeWhaeHFSelNwSVVwSkYvQWVTQ21GcnVTZ2ZTSjRE?= =?utf-8?B?UEZlYTE1NUhsa1dPaXNZS1BYRk1GeWludHNXejRsYnJLcGdRSzkzTHgxUlNi?= =?utf-8?B?WlU3TFZ0SEV2NjZvd0U2alUwQUUrTDlrNVVpZlY1bVpjVnpOQmtXTDNTQmU5?= =?utf-8?B?cnZpTm5QVDN4R2kvelM0Qng2K2l5aG5ybHY4Y0VwK0lDaHN0aE9tTlVXS2ZZ?= =?utf-8?B?Q3JJM01oSEtCZXJGeHBRZjA5SGdrb1hyT25sb0JKK29JTjZnQm9xckdoTzdY?= =?utf-8?B?RXdaSWJkUzVDWTNycFB5bWVma1p2YnNWZTVzeEhHSzZOWnVLbytpMVJabEN5?= =?utf-8?B?dVc5NWcxMXRmZ2FNQitwaHZQU25WT21qTlU5Y3FHMVZwSFd5RXlLSGdhRmZr?= =?utf-8?B?cVZFdHRHenFTS0llekc0TEFOOWZTZlQxa3R2eVM1NmM1SlhWUXZodnM2SEFE?= =?utf-8?B?UlpDZi9IOEtWRndhTFJ4UXhyY1pRVFBnZXhMV21hS1diVXpmVStmazdyMVBC?= =?utf-8?B?Q2grWm5YMW1NUjVZUEdkYnBNV0NmOUkzNlZJTlJYbVlkM1RkRURwK2Voazdv?= =?utf-8?B?aE8zQ1JpK3RoQTJXNklOSU4xVTlCMytTSnB4a1BNakdDWmx6d0p6NllkRXMz?= =?utf-8?B?V01tSG1tOFpIN2RTc3FJSWs4YjJZV0s1NUV6UjJiLzdjemlTdnZ1SUhlTGJ4?= =?utf-8?B?enBNSnBqaC9oL2YyTERORjE3VmtIbGFkODNiV2xPSGgvN3ZONC9HUStDeE1O?= =?utf-8?B?cDhnS1A1U3VhRnRpWHZjeUpNSlRrV1NqSmZ4Zko2SHdVTUoyQ3NQOG1RPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: ba3fd33f-4d10-4bcc-4a81-08da5b67e7dc X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 13:45:06.0454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAP286MB0748 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 13:45:11 -0000 On Tue, 2022-06-28 at 01:04 +0000, Christopher Di Bella via Gdb-patches wrote: > `std::back_inserter` is defined in ``, which is currently > being transitively included by one of the other headers. This is > causing > gdb to fail to build on certain platforms, which is fixed by > explicitly > including it. Hi Christopher, I didn't get your point through the commit message. Can you clarify exactly on which platforms, and what build error you encountered? So that I can reproduce the issue. Thanks, Enze > --- > =C2=A0gdb/value.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/gdb/value.c b/gdb/value.c > index 022fca91a42..ba7ae1a0e18 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -40,6 +40,7 @@ > =C2=A0#include "cp-abi.h" > =C2=A0#include "user-regs.h" > =C2=A0#include > +#include > =C2=A0#include "completer.h" > =C2=A0#include "gdbsupport/selftest.h" > =C2=A0#include "gdbsupport/array-view.h"