From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2025.outbound.protection.outlook.com [40.92.98.25]) by sourceware.org (Postfix) with ESMTPS id D22B03858C5E for ; Mon, 11 Sep 2023 14:20:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D22B03858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jcz3oik1N5ztpqe/2sQ5gWZI7+pFvI27+5k3Oz0Kc6+AKPodPLBUrBAYS9oPwBfSbf5e3LAMC6XxnT5NcHJ9CVhfYUP4XmpOWUrhM+e/SIT24nIikjH+Dmf7I/MPWYXVYSHjdzSlqW0WO1Zu0+N+uXDa87pNvCn+VykQr2g85AcY4gN0YxIGpDz0p8lWj3AbojhTMAVcjVO7BXwSNIsAOjPtr6/nHON1wjw3HiAgB4rZA0kfx1SzHgoGYsjONX/2D+/Rc6yPnfacW1FZPpmZEk2YBOQSKd678dQkFsr2t/hI5xwaUao0nSxHouUbtGSrkL62PUA7Mx2hvKCdr3Bv2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=87vBBHcu2ZpbNKVTcTzbN9aWzdn7uuejYZTggU9ZlBI=; b=ZIzn7A8AB8yBS+JvalF7R9uDYdbnKwRPh48icFRnCqdLy8CIgNNXVOQUFN65v1xjk6VJ2gkXrtpLOC6r3eTE1wWZ/5KNzLeswAiqaqjrAlIo9brQ2AJvmlMH15QFdfMpTAq0xAdwyqobI/4jJuQVHulLAjXmZUT3YNaNDhCX0qjy0s3E0b/YjK3J7WTStP0b2kTwLOecjgmS1z20MLXHWhGAbKqzjKHDFeFeCxJfM7i1uBr2O2mkxfrcduKUl5oIjtpnVICmt3oiPtHXZjIcEfIWVFHK8XZqCpe1BK7zAJdF7xXvbhJaW9AnVi3ROkWDrtaKT5j9sxLAlhX8NXQ41w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=87vBBHcu2ZpbNKVTcTzbN9aWzdn7uuejYZTggU9ZlBI=; b=oII/TpMEr9VDq3JB0d9rJwp7m+NZ/5hTIhK+wHGSaceOjuokLuxZHBl4e0byvNkOpdCmW4DAhQEJf/fUWcgJBO9UkJ2Wg8qu98XdmKPiI2qHt793cdoksWWeND/3NHPuGWcnegFksfhRDi9G1PsNXFPR66t1BR4cji1L5oRsOdJD53aOZUAlo9mZVv0L8zbSmr2/4GS+ZDTOzzf7yxz56M1fHsVga1geV7bAiYiX/w3tuXefuKbRABB3cFuyt8U5JB6DMpZ57zXtzrzZBHOpPFrxSoiC6AMvJmx1TJGSXY/zh7Jj3aPEMYgN87umhusf2XPXvq5RrDSjt9HmqqjFRw== Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TY1P286MB3199.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2e7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.16; Mon, 11 Sep 2023 14:20:44 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::72d7:4747:7f49:f811]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::72d7:4747:7f49:f811%7]) with mapi id 15.20.6792.015; Mon, 11 Sep 2023 14:20:44 +0000 From: Enze Li To: John Baldwin Cc: gdb-patches@sourceware.org, enze.li@gmx.com Subject: Re: [PATCH] fbsd-nat: Pacify gcc with no functional changes In-Reply-To: <769d6902-2363-5bbc-3336-03eb85ba95ce@FreeBSD.org> (John Baldwin's message of "Sat, 9 Sep 2023 09:49:40 -0700") References: <769d6902-2363-5bbc-3336-03eb85ba95ce@FreeBSD.org> Date: Mon, 11 Sep 2023 22:20:35 +0800 Message-ID: Content-Type: text/plain X-TMN: [tM9898Scd/BH5unqoGzLDIwCqaKMfR3ZaogiQkrmor0=] X-ClientProxiedBy: SJ0PR05CA0115.namprd05.prod.outlook.com (2603:10b6:a03:334::30) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|TY1P286MB3199:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a518167-1f72-42dd-7fb7-08dbb2d248cd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9XPaGmTAf3SVYHmKpuXUYlXQkTubie+UIWdeOqiiGKmeCU+2AsjDuvf+D+Sd9qBt8PlrIDiBq/ckmYl/6jeI9XihvRAcG/rWFYlrYLUI54kj80qwXjSqYGAPBNaH2WUy6ObtDtDaUKAmMsPg+fsQFw7BPyrK1bGYwGmXH1rJx7ZgpYZYTvaveiIs0UUHdRwtEP5ISCA7GMfPSAzq6wXO3xjhtNwW00YohVb855E74Eo1+neHj/Nz6Dgudgl1/uo/vpqJij/SIgnFSoSGfPTmERluTrlvcWlP93mwtrnb1211wiDwwTLmGhlsc4oXl7QX9EtbDcSnBlwDKGlp7mtOmimY+p0kekmkUQAtQL8t74+ankDhafSuY1YBnH30yRxzOefIbjND9bB4T1klsBsZcjjzSixURTKBdCS5KEWtoQ7qUkPnWgO1OCpkQeHm3LMxhTYRXoij+9Dze4qKrz59wtY+4nRzJKLAr/XiBNvfS0cBbBR14xVVOTn9DVDL3NTZLN2i1w3EcDy0ghKGxzGneQwJxKEjU6kaLrALskL3eBvSLcnpbq6iWQubCQ2XZU1/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+tspkFUTvbWUYc+Ma8NabbpU/sgJUOTN7tKa618BKe+yccuNrjApbMsQv52M?= =?us-ascii?Q?+b2eGqbOpbIL+9nwmy5Rh4i1prcUJSRyH0mY+cob32Lp3lNRTjGAOHBOBas1?= =?us-ascii?Q?rcQHbj6hrlr1bCW8Fhh5o/zJy0LzzZFrD1HZqvqXwkvD7I1FNcVMivAu3NQw?= =?us-ascii?Q?ZV/bsgbsM6H0uw/aWlUTr4K1iPLQEYLaJj4xYljz4XDinamjy7SDIPsfNsTY?= =?us-ascii?Q?syQpFdhpYnCr6q6McA8rvrVWUlCXFJ0NTOXTmSfPTdefh8alf0swabNObdj4?= =?us-ascii?Q?+NKTUvBMzrTYYuYMIcf5ESUQJzLdSt93jTeV1v0/NF6PgNP0CD5F4uvWbTN4?= =?us-ascii?Q?e31hI+/Rkc5X5bZIEmpSDweoZ6ts07gWdzdhvdDrz8UtwknaCFNm81K+Qg9Y?= =?us-ascii?Q?vPNfCTRDg5kEjTTjrNr1o+sWXHXiuGGwk+i8dlhNzlTdYFL/QBYulQcqIhn9?= =?us-ascii?Q?UdW7J8ZsubTYclUrf+BCZcB8DdzUFzPJiq/SCmtus8ceYDLAL4a7JftJiFdl?= =?us-ascii?Q?8yj2xSP6cCwuE3cKzyKXU6+aa+AlJlnsFWLIEfgCv4XePvMQiNmrNLVXC7Vj?= =?us-ascii?Q?MZnbmUOUvQDBWffItS5079cjh6ImxDIWFwyqikRHe8eRzanZqhXW7elRf3Ro?= =?us-ascii?Q?/gmzSH1Zn+DT6JI0U1pkZHDpPvnp4qYmTB5nfKjTABXMw907hfzTVX8GVdwL?= =?us-ascii?Q?dNM7bSO5A4bpou7FirePaGUpL8kX76x7gfqMifz/z1tSREatPfiexsHVCL0o?= =?us-ascii?Q?SdHUW8nZWw+6fsJ5u0xUDm6Md4D6bhhXnrkKfQBvViGI0UvWdBwObAt6gT/c?= =?us-ascii?Q?+H974mk6FNJx7uZE+SQgOEXe5+pBuGECaGp2PzrN/eGqCMC2s9FgVJ4onadC?= =?us-ascii?Q?Q4jYasiU+Z23kDrM5hhTCoS2gyhpD7Uh2sorGXRZ/U+a1ppA2ZyfuwWb7hKG?= =?us-ascii?Q?o5sZI8FKtc+PjKVwIY6wwIT7q61WdYYhB8wv4Y3VYGejXVTGbcSOGScfUdP4?= =?us-ascii?Q?hTWRxKZKZTwPiHCY7MBISQJkzKe46BGiqeM5SefgBuOhb7YpuPbZC1zhxMdL?= =?us-ascii?Q?fgAbROeaWj1VTF0UCGeV0Q1eCD9nkJQJYOZe1i/6tQcI4T7lrbBGI3Xb8OHD?= =?us-ascii?Q?KZ//N1uABoqfBTEKRKypE//bkDcf5Q3+pHPLtW+Jc6H0zV3hWDRI4pvhzxQo?= =?us-ascii?Q?vvzfOSaUiaDfakAYh0Rkaa3UBY9Bq5oei00KSg=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 4a518167-1f72-42dd-7fb7-08dbb2d248cd X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2023 14:20:44.3790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1P286MB3199 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Sep 09 2023 at 09:49:40 AM -0700, John Baldwin wrote: > On 9/9/23 6:50 AM, Enze Li wrote: >> I see these errors on FreeBSD/aarch64 when using gcc 12 without passing >> --disable-werror. >> ===================================================================== >> CXX fbsd-nat.o >> fbsd-nat.c: In member function 'void fbsd_nat_target::resume_one_process(ptid_t, int, gdb_signal)': >> fbsd-nat.c:1208:11: error: unused variable 'request' [-Werror=unused-variable] >> 1208 | int request; >> | ^~~~~~~ >> fbsd-nat.c: In member function 'virtual ptid_t >> fbsd_nat_target::wait(ptid_t, target_waitstatus*, >> target_wait_flags)': >> fbsd-nat.c:1726:22: error: declaration of 'inf' shadows a previous >> local [-Werror=shadow=compatible-local] >> 1726 | for (inferior *inf : all_non_exited_inferiors (this)) >> | ^~~ >> fbsd-nat.c:1697:17: note: shadowed declaration is here >> 1697 | inferior *inf = find_inferior_ptid (this, wptid); >> | ^~~ >> fbsd-nat.c: In member function 'virtual void >> fbsd_nat_target::detach(inferior*, int)': >> fbsd-nat.c:2044:18: error: variable 'wptid' set but not used >> [-Werror=unused-but-set-variable] >> 2044 | ptid_t wptid = wait_1 (ptid, &ws, 0); >> | ^~~~~ >> cc1plus: all warnings being treated as errors >> ===================================================================== >> This patch includes the following non-functional changes, >> 1. Remove unused variable "request". >> 2. Rename inf to inf_p to avoid shadowed declaration warnings. >> 3. Set wptid to null_ptid when USE_SIGTRAP_SIGINFO is not defined. Hi John, Thanks for your review. > > I'm surprised you see this third warning. USE_SIGTRAP_SIGINFO should > be on for all modern versions of FreeBSD. In particular, fbsd-nat.h > enables it on 11.3 and later. What version of FreeBSD are you > building on? I just realized that the third description is incorrect and should be: "3. Set wptid to null_ptid when USE_SIGTRAP_SIGINFO is defined." BTW, I'm using FreeBSD/aarch64 13.2-RELEASE. > > From fbsd-nat.h: > > /* FreeBSD kernels 11.3 and later report valid si_code values for > SIGTRAP on all architectures. Older FreeBSD kernels that supported > TRAP_BRKPT did not report valid values for MIPS and sparc64. Even > older kernels without TRAP_BRKPT support did not report valid > values on any architecture. */ > #if (__FreeBSD_kernel_version >= 1102502) || (__FreeBSD_version >= 1102502) > # define USE_SIGTRAP_SIGINFO > > >> Tested on FreeBSD/aarch64 by rebuilding. >> --- >> gdb/fbsd-nat.c | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c >> index 0ee3bccb5ef..af416557504 100644 >> --- a/gdb/fbsd-nat.c >> +++ b/gdb/fbsd-nat.c >> @@ -1205,8 +1205,6 @@ fbsd_nat_target::resume_one_process (ptid_t ptid, int step, >> for (thread_info *tp : inf->non_exited_threads ()) >> { >> - int request; >> - >> /* If ptid is a specific LWP, suspend all other LWPs in the >> process, otherwise resume all LWPs in the process.. */ >> if (!ptid.lwp_p() || tp->ptid.lwp () == ptid.lwp ()) > > Thanks. This a leftover from my recent patches, not sure why clang > didn't notice. > >> @@ -1694,9 +1692,9 @@ fbsd_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus, >> || ourstatus->kind () == TARGET_WAITKIND_NO_RESUMED) >> break; >> - inferior *inf = find_inferior_ptid (this, wptid); >> - gdb_assert (inf != nullptr); >> - fbsd_inferior *fbsd_inf = get_fbsd_inferior (inf); >> + inferior *inf_p = find_inferior_ptid (this, wptid); >> + gdb_assert (inf_p != nullptr); >> + fbsd_inferior *fbsd_inf = get_fbsd_inferior (inf_p); >> gdb_assert (fbsd_inf != nullptr); >> gdb_assert (fbsd_inf->resumed_lwps != null_ptid); >> gdb_assert (fbsd_inf->running_lwps > 0); > > I might call this variable `winf` to match the `wptid` vs `ptid` pattern. > Fixed. >> @@ -2094,6 +2092,9 @@ fbsd_nat_target::detach (inferior *inf, int from_tty) >> } >> } >> } >> +#else >> + /* pacify gcc */ >> + wptid = null_ptid; > > Probably the better way to pacify this is to use a (void) cast to mark it > as used, e.g. `(void)null_ptid;` > Okey, fixed. I'll send v2 to the list soon. Best Regards, Enze >> #endif >> sig = 0; >> break; >> base-commit: 38a984fa440c7686c741b7804eae06a528849aa7