From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2012.outbound.protection.outlook.com [40.92.99.12]) by sourceware.org (Postfix) with ESMTPS id C48A33858D1E for ; Mon, 19 Sep 2022 12:50:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C48A33858D1E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+fOVhOgXUf4gScC5HqeN7CH54FuuQ3D6DIcDdK8jxxVuzWdrqBG5cC3u3fGIpq1odJr/xBOetkSl2bZYtKTVj3hn+WvupQvc4GsSYNfevZ9iZ/Up4DvpVrYUU2Lk30kkZFdZaLBH5JzZFWdFJHXdD1Hxn8f2POoNhA9dmmxaFCKEljy3fG0fdgqNDkFRZt153xyYOzMAZrAkd31GLpHxFNeP3Po66uBfEa+t0GgtpULwtFia39knpdGKBbWiTbsJESkqJ5qylpvqAw4mJ9KEVj6EqkEz5jYO0z4jxLeopiNTeo+t5fgGMfn6MKDNxQWV7TOeVO+tpyVx0Mrtn7iJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+KPqDxosF5orug2J2Hdrx1fRQqqGAcWsRXQn8tLAmLA=; b=Bvl4qoHVldmFqHETh8m6Y5tYDzz5/OP45IKmGDJIf2/TQquU29k5nkYTBLCuWPgONxAa2lYII73FDsjk0Hh7EoEy8MJ1cfAKt6LpMb66l2fT/JQzopEEXQWWerSJWh0VNknza0DimKOZETHiXpM0XeM2wPDKv0g2BcnOuVuJgcWUHgM2wdiCHjY2VDPCYSFiymICsf+Jcaia5wAYTmgnDOr7+Q9sc47s0ttlOWYP12B/e2EeTqqjoOPOULztZIzMD3rr9x+DV2lzCPDWOBKPrJ+KDG/Iswx7BQsT2M9oyVY4nurhZ/rEbqKxPumbudJKv5e6wlS7ZsDKUaYUVWL1cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYYP286MB1691.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:fd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Mon, 19 Sep 2022 12:50:30 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::e442:a4b4:201c:8097]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::e442:a4b4:201c:8097%4]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 12:50:30 +0000 From: Enze Li To: Tom de Vries Cc: gdb-patches@sourceware.org, enze.li@gmx.com Subject: Re: [PATCH] gdb: add ATTRIBUTE_PRINTF to gdb_bfd_error_handler References: <1e04fad6-5160-3897-9b83-15067ed59313@suse.de> Date: Mon, 19 Sep 2022 20:49:53 +0800 In-Reply-To: <1e04fad6-5160-3897-9b83-15067ed59313@suse.de> (Tom de Vries's message of "Sun, 18 Sep 2022 07:45:10 +0200") Message-ID: Content-Type: text/plain X-TMN: [aLH3sFvn4IAZdu7YL3ZSNDmLEduamW2X] X-ClientProxiedBy: SG3P274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::27) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|TYYP286MB1691:EE_ X-MS-Office365-Filtering-Correlation-Id: 3280880b-d192-4f4b-0822-08da9a3d888a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EzpFW/J8cAYtP+ly5drZXz+qtFJOM/gsy4vrSW12pRXuEYCmb1ci6IC2T9wp/V9l8z2WVhgg05m8w8GlWAd9pMFGkY2RBHzyTxewr6/b5eF842WbqxkKUtYABGiS0mm9oZrp3wAntew7ZLlbaETr5gfsoeLvbX1Z/1L0pGhvsmZl4rmhSZXjmq8Eb5ZBUjG2YxENQzg/knsuLB4v8Gdk/ZMpHzp716ODVRW2MlITZbao4wbixw0yWeFQo7qsMksGxtBgpPrcuGk8vsGPrvfgJ8J60GmZsWGEfg8MYwvunRpw7B7Ovb5QujBLljxpkkMjjXWNYpUlLwKeo0OXo9sqp0XJ4zCVYquy3Neq0XCUrJXyPSZnRipGuJA/1Wk3W/d6D6R5dRQNzl8acbvU6sLUyNs1peuedjKwBPIXErwuoT0gXkWoN+EXdEKjlljhwKsayguDUF0OihAqOuDzfhlAuqIJbcNGFiNSyOFHnxbvkbsh4sxDKSX0Uq7/q4DMQUzmOzVWYn4l+RszhKH1Dc3uXeBTTtUR1R47I3dASIHxNX8epOyYTVTgrdQ/mKovFmX1CrwazC9XiE52H7KF9fEuVLiYmC4IKdhR3zjZuvlQBitJAjiXwO6F1Yaape/1rUS+FVmX0MTOEWtNAYtJQHqfgvNQlSuvR3il37LH+IopGM8XlkR6XeAxfd77QHc8yNMM X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k6UuMcQ53TbpsyyR7HJO/bvMcsSyQelztUk2WLzWFI8I0sVYU4AT+lP+dmVH?= =?us-ascii?Q?N62GVT7rBNliAwV5kHB+Luk3oskd+JiCKp88zUOEpHUQ0mxp5x7ig2dlhmyH?= =?us-ascii?Q?JeC4OqGttbOydOvtQAl+LkZgYpQ8XmGMi+VF094t7JZpCpwn+QvX4O+/Wo/E?= =?us-ascii?Q?jnipaFnK0djw4duUAm16MhOQVX/IcqtzFxHuh9OSAwj8yP+KYRdiErw05i/a?= =?us-ascii?Q?T4AYlmf8BV+08tpoAfEBodAypXn/d6fbsj5jHoF3i5P4EV/UOfvrxMtrZSxu?= =?us-ascii?Q?8FB11+7+3ORvMFrkNB3ArFwLcILYDonNrW4y3bczBq9A3JEWUZKRi1OaqVZm?= =?us-ascii?Q?1r59PpfqcMDfgEs93AfeBmIXFeq4xArbSDrefdCCpMSPcg0kfWurdd8nR/ko?= =?us-ascii?Q?e0C11yqgD4XUDuZZAjXz3SmFQtKPtzH+duQfal/ednkS3yeqVOfGffUqQWbi?= =?us-ascii?Q?ctQ3nc6YjkafiHvWlKNyt8efKWHoHtPZjRcWsk3Jjq268+dL0FtOCQ8gKsBq?= =?us-ascii?Q?IuVgciL6ReJ2GCAGTZQfDEPc63iBnj7B9ULZ38nGBApQDSVi/UzKlo3JEs4e?= =?us-ascii?Q?i2FJtfvYFyMFnTBz3eeXQxv+XPXEhhsXoVbYZRTMMS1+xd4VarFCRExKLtXk?= =?us-ascii?Q?VlISxH+vyzRqB4eHjK7gqGCTkhzPoQPriE3UVvruqygUFRKIB2lWlLmVrlib?= =?us-ascii?Q?3mGoO9hQlPeqhyzAypgVbSPWhiVypyYufv2nE/B8IVXQaJwn6QNHPvz8oGYs?= =?us-ascii?Q?lPp286QK8uA+zh8/MWqFn9LS76z/WvBczttg+ADaNXHwCAGlw32J3BcTre/A?= =?us-ascii?Q?VYln64r/zqoxSjsnV1bcffPXyxHSeMuqLc86HVn7tEbFxCc5tWg1D++0g99e?= =?us-ascii?Q?xIaPkPMMlvDXkpEj08T/NlXkLro1FJLrMiSITbTnYjDvQVO/v1mZBTPx56ob?= =?us-ascii?Q?O+m24suJLQJXKOBJGmQR0NxwozB782KCT47sO9Gh+h+n4cHJsc5JmLFFPStL?= =?us-ascii?Q?waOqg2XDhhebb/+LZ2i3NHH8JR3Ai3/kWdD+WE9AF0wsbr6U39J3Qhv/MI3t?= =?us-ascii?Q?LXAcozHPOmWYeja3Joq+mNtcuS10f7qp+whl6fMadZZ6pDNRKAsSC2Ei6brK?= =?us-ascii?Q?F7f98BSvlfAT+WAyDjcn5unsCIl8oHNEeSqJd2/1Zd/aXuL1T54JGG8r6hqI?= =?us-ascii?Q?kpHRFGyk5ivENSjr/ZxG3Rcjwb6/aXvxM6fo2VGeQMQmzejlO+L9hRXGjUAJ?= =?us-ascii?Q?rWt8fkJhYV1w8SowCJy73dtqnfnSzGpUAT0+bR3esA=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 3280880b-d192-4f4b-0822-08da9a3d888a X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 12:50:30.3901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB1691 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2022 12:50:36 -0000 On Sun, Sep 18 2022 at 07:45:10 AM +0200, Tom de Vries wrote: > On 9/18/22 06:58, Enze Li via Gdb-patches wrote: >> I see this error when building with clang, >> CXX gdb_bfd.o >> gdb_bfd.c:1180:43: error: format string is not a string literal [-Werror,-Wformat-nonliteral] >> const std::string str = string_vprintf (fmt, ap_copy); >> ^~~ >> 1 error generated. >> This patch adds missing ATTRIBUTE_PRINTF to fix the error. >> Tested on x86_64-linux with gcc 12 and clang 14. > > > LGTM. > > Thanks, > - Tom > Thanks, Tom. Pushed. Enze >> --- >> gdb/gdb_bfd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c >> index 6299148d419..c5a5ed95e8e 100644 >> --- a/gdb/gdb_bfd.c >> +++ b/gdb/gdb_bfd.c >> @@ -1170,7 +1170,7 @@ static bfd_error_handler_type default_bfd_error_handler; >> messages which have been printed once already. This is done on a >> per-inferior basis. */ >> -static void >> +static void ATTRIBUTE_PRINTF (1, 0) >> gdb_bfd_error_handler (const char *fmt, va_list ap) >> { >> va_list ap_copy;