From: Enze Li <enze.li@hotmail.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org, pedro@palves.net, enze.li@gmx.com
Subject: Re: [PATCH] gdbserver: remove unused for loop
Date: Sat, 24 Sep 2022 12:13:00 +0800 [thread overview]
Message-ID: <OS3P286MB2152E2B51EC4366B84D9B2A5F0509@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <75190099-2c5e-4616-fbf4-045aa4f5535b@simark.ca> (Simon Marchi's message of "Thu, 22 Sep 2022 12:13:25 -0400")
On Thu, Sep 22 2022 at 12:13:25 PM -0400, Simon Marchi wrote:
> On 2022-09-22 09:30, Enze Li via Gdb-patches wrote:
>> In this commit,
>>
>> commit cf6c1e710ee162a5adb0ae47acb731f2bfecc956
>> Date: Mon Jul 11 20:53:48 2022 +0800
>>
>> gdbserver: remove unused variable
>>
>> I removed an unused variable in handle_v_run. Pedro then pointed out
>> that the for loop after it was also unused. After a period of smoke
>> testing, no exceptions were found.
>>
>> Tested on x86_64-linux.
>> ---
>> gdbserver/server.cc | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
>> index c619206d5d2d..366a843ea894 100644
>> --- a/gdbserver/server.cc
>> +++ b/gdbserver/server.cc
>> @@ -2984,9 +2984,6 @@ handle_v_run (char *own_buf)
>> char *new_program_name = NULL;
>> int i;
>>
>> - for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';'))
>> - p++;
>> -
>> for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i)
>> {
>> next_p = strchr (p, ';');
>>
>> base-commit: aaf3f3f3bb38a59125ea34afa0ef7e0e14c2e916
>
> Thanks, this is ok.
>
> Simon
Thanks, Simon. Pushed.
Enze
prev parent reply other threads:[~2022-09-24 4:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 13:30 Enze Li
2022-09-22 16:13 ` Simon Marchi
2022-09-24 4:13 ` Enze Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB2152E2B51EC4366B84D9B2A5F0509@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
--to=enze.li@hotmail.com \
--cc=enze.li@gmx.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).