* [PATCH] gdbserver: remove unused for loop
@ 2022-09-22 13:30 Enze Li
2022-09-22 16:13 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Enze Li @ 2022-09-22 13:30 UTC (permalink / raw)
To: gdb-patches; +Cc: enze.li, pedro
In this commit,
commit cf6c1e710ee162a5adb0ae47acb731f2bfecc956
Date: Mon Jul 11 20:53:48 2022 +0800
gdbserver: remove unused variable
I removed an unused variable in handle_v_run. Pedro then pointed out
that the for loop after it was also unused. After a period of smoke
testing, no exceptions were found.
Tested on x86_64-linux.
---
gdbserver/server.cc | 3 ---
1 file changed, 3 deletions(-)
diff --git a/gdbserver/server.cc b/gdbserver/server.cc
index c619206d5d2d..366a843ea894 100644
--- a/gdbserver/server.cc
+++ b/gdbserver/server.cc
@@ -2984,9 +2984,6 @@ handle_v_run (char *own_buf)
char *new_program_name = NULL;
int i;
- for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';'))
- p++;
-
for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i)
{
next_p = strchr (p, ';');
base-commit: aaf3f3f3bb38a59125ea34afa0ef7e0e14c2e916
--
2.37.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdbserver: remove unused for loop
2022-09-22 13:30 [PATCH] gdbserver: remove unused for loop Enze Li
@ 2022-09-22 16:13 ` Simon Marchi
2022-09-24 4:13 ` Enze Li
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2022-09-22 16:13 UTC (permalink / raw)
To: Enze Li, gdb-patches; +Cc: pedro, enze.li
On 2022-09-22 09:30, Enze Li via Gdb-patches wrote:
> In this commit,
>
> commit cf6c1e710ee162a5adb0ae47acb731f2bfecc956
> Date: Mon Jul 11 20:53:48 2022 +0800
>
> gdbserver: remove unused variable
>
> I removed an unused variable in handle_v_run. Pedro then pointed out
> that the for loop after it was also unused. After a period of smoke
> testing, no exceptions were found.
>
> Tested on x86_64-linux.
> ---
> gdbserver/server.cc | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index c619206d5d2d..366a843ea894 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -2984,9 +2984,6 @@ handle_v_run (char *own_buf)
> char *new_program_name = NULL;
> int i;
>
> - for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';'))
> - p++;
> -
> for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i)
> {
> next_p = strchr (p, ';');
>
> base-commit: aaf3f3f3bb38a59125ea34afa0ef7e0e14c2e916
Thanks, this is ok.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdbserver: remove unused for loop
2022-09-22 16:13 ` Simon Marchi
@ 2022-09-24 4:13 ` Enze Li
0 siblings, 0 replies; 3+ messages in thread
From: Enze Li @ 2022-09-24 4:13 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches, pedro, enze.li
On Thu, Sep 22 2022 at 12:13:25 PM -0400, Simon Marchi wrote:
> On 2022-09-22 09:30, Enze Li via Gdb-patches wrote:
>> In this commit,
>>
>> commit cf6c1e710ee162a5adb0ae47acb731f2bfecc956
>> Date: Mon Jul 11 20:53:48 2022 +0800
>>
>> gdbserver: remove unused variable
>>
>> I removed an unused variable in handle_v_run. Pedro then pointed out
>> that the for loop after it was also unused. After a period of smoke
>> testing, no exceptions were found.
>>
>> Tested on x86_64-linux.
>> ---
>> gdbserver/server.cc | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
>> index c619206d5d2d..366a843ea894 100644
>> --- a/gdbserver/server.cc
>> +++ b/gdbserver/server.cc
>> @@ -2984,9 +2984,6 @@ handle_v_run (char *own_buf)
>> char *new_program_name = NULL;
>> int i;
>>
>> - for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';'))
>> - p++;
>> -
>> for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i)
>> {
>> next_p = strchr (p, ';');
>>
>> base-commit: aaf3f3f3bb38a59125ea34afa0ef7e0e14c2e916
>
> Thanks, this is ok.
>
> Simon
Thanks, Simon. Pushed.
Enze
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-24 4:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 13:30 [PATCH] gdbserver: remove unused for loop Enze Li
2022-09-22 16:13 ` Simon Marchi
2022-09-24 4:13 ` Enze Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).