From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2063.outbound.protection.outlook.com [40.92.99.63]) by sourceware.org (Postfix) with ESMTPS id 0A8D93858D28 for ; Sat, 24 Sep 2022 04:13:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A8D93858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FduDSqYjDQsAr2pkkuJtRDg7N84/A4woKuVHX9YiNqE2dBKHB+2j21BqN9q5Ll4N5tvv3ka5SJNEEEOsMkyc3cy03w+M7RuJ1Wa8sRMnOQzGpP6R7/OwjNWG2hMHwncLw7rLKqpltuTBwHlXlopa5cgz0pJBA0iNsz3WJbZClThZTViWfyfEE6bq5ebzph0RBUMdxrmN6sQd6Ppt3Uz+OukmAsZxcU3BwxBhJBsYtjog1ebZMvGYvKzxPTGy7YxgDlV03arYvzutifJNsF0XYZzUbGN94crVulsn3rq91fVEYsFjXLOsLz+ZnIju2QGY4JyO4hITUA339cNNr6cNjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eha+CDfJH+oY5NN1bqeuv7Bw+ZFh92Lr0n5NY5507Eo=; b=gZn/c6/JoyDhfKi0ipK+QQrkbGgg85PLW4JeOZEvaXOMHzXFL6QWlSuYUUIm5+fkAP4BvPWCuzI8MvoVabTxsMGb4iNCh+PkB4SCpkzJbfEYeUQdLad9qFRDaaSiRPKraOBPV0x3YVPyykFvzBoP1iesZV2RP+qaWCEswnFvHKQN2swrXAtoj3YZEe64kmdHDanDS7tSwmMrXT1S309lx0U7hd0harDMMYX/4nP5iPR0FlwQJFgJ6etGQdWqSMTRgEqXMaI8NRCc1sVcOrxvNmMMgAYBnzD7BfmbfmzoCq3jNg2Co3GsmFWTNQgddZd1G5S2xC9Hrre3JF+TpSYPTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OS3P286MB1565.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:17b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.15; Sat, 24 Sep 2022 04:13:10 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::e442:a4b4:201c:8097]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::e442:a4b4:201c:8097%4]) with mapi id 15.20.5654.022; Sat, 24 Sep 2022 04:13:10 +0000 From: Enze Li To: Simon Marchi Cc: gdb-patches@sourceware.org, pedro@palves.net, enze.li@gmx.com Subject: Re: [PATCH] gdbserver: remove unused for loop References: <75190099-2c5e-4616-fbf4-045aa4f5535b@simark.ca> Date: Sat, 24 Sep 2022 12:13:00 +0800 In-Reply-To: <75190099-2c5e-4616-fbf4-045aa4f5535b@simark.ca> (Simon Marchi's message of "Thu, 22 Sep 2022 12:13:25 -0400") Message-ID: Content-Type: text/plain X-TMN: [yiwVMhcbGy6rqFIAwN3lsqjtWQi+u8mT] X-ClientProxiedBy: SG2PR06CA0232.apcprd06.prod.outlook.com (2603:1096:4:ac::16) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <87v8pdmmur.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|OS3P286MB1565:EE_ X-MS-Office365-Filtering-Correlation-Id: b2b1d0f1-3ea8-418f-d357-08da9de31767 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yc+eQKB/tlpNE8cgooOx5FETu8QFAVo18zQTAJYLVOG3lTOI3R1gbtbV5yFOtAxbe0kzjYfKz/rQcHGvBAtFAYHD0ueB1ZrPt1SYV+ryaIbI9kOCzuS0CbZT29kjCjFnkRM4jje7Br0/Od9yeUYSY1GT0DSkkdCyDNX24WDqC6rggiALbQQO819fAG4u9fpATHl2V4/bOtiSMIVjxRFvTPM1v3oDLUNthYLKzp/I6yhmW4pE/IfJyzdp7Lv4cKjsFQXgGK3nhESz/zHpxUF3LXbz4oFKzG9QizJNAcd89IYFbZC9amR0xkmJ9sQszU8gBFRCkV1xslACvYJ/iYLBehh1ZX5aP1S5qLlRxosUTFEIINGgLOkGYQRsZYKBRUDMr+ULmzZ2wkCtYegpUzUu13bUSxN6YKXeJlP1zhfs59ospy/sImXV8mUgi+bmwo6NxM6P8F9usZxrGbuyRR4kVQWioSEsiBoBXD+NOkQMizh3cTDDr187WTvHcDtcwADj/q485olTWTbMJ90k78RQxA85mgGKpVYmofRerHy+I89xEywzPSwcWuAnEOjk+UKagaVs/nKCfC0idjPerqQZUmflZpurypTOY4+u89Rt3IdIp3dnP/LChbZ6XcgLSy745E4686gBXlNLKRbNodMLgas4wghQ+IEy37ko4r/q9lACmODTB1WIsSF63ZijBAho X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J9AN3mmmebyhiP4Y5p4f3NeIUnOtTu/5jQjrf6qYsvDu3LNwnb1GfS0uhkOf?= =?us-ascii?Q?MS+wt35VSAD6c5zlf3ADSoFceyeH93AtEbEQr2hjfzAuuMwGPONbnjKHwiWK?= =?us-ascii?Q?Qm+s+mGzrBLr1E69wWTs1yOhfeie+cbABEuuyKFKoFuNHGZyV8mg2/dni2Sw?= =?us-ascii?Q?roqi6PycnOjxFuU96AgfEJASAZB1Blm55ejrkMIQmkfUpJRyNFMiqwypeebC?= =?us-ascii?Q?VHEYvaiMdijdxA8Sq0FYUUB+qbHmGlmAszU67hsXEcHKT0qGVj2s6zqtPriH?= =?us-ascii?Q?pOLYqlL5vhJJuKilYEBx7szSk++mAfj8e9yPVBNXb4gXb+1z3WKNjBBaTxIl?= =?us-ascii?Q?KD1f/X1jX9tyM/EGFYVcN1NiU5MwtBLwgQWGZ9g4/Q43J30TGWT9ORHxkPH+?= =?us-ascii?Q?ssTPZgN4xHf7ttoG9AgrwhQXNq1qr6nndWHzLxyUjsM+H3yO5LKptMOKq3QB?= =?us-ascii?Q?45UfOr5hV8Elm0+tCBEgFZ7Az/ukKC3ioaPpEPwM6absoGrrTlAWIQaJl+Cl?= =?us-ascii?Q?zmtRqcPozXCD0RaCthXdN8FiJIzjoRMKGu1ZQWb9HAYL6qPdAvYInBPc4QPt?= =?us-ascii?Q?aOj/YBGRjBPRGmSwN0fT2TetB3wdPaVbQwAugxlqEAVskGJP6G3O5Gzod6U0?= =?us-ascii?Q?i50L8/isgvvcFQZZMQ5Cwzc4fUpBtfmEldq/f5HBy+0L+7/KE4234pPxal0Q?= =?us-ascii?Q?SHBFVvbFEUSHQ3JBRbWib8mCtrWVvJ8BEB8qm/LViR5/FIrH1wjp1jgv1HaK?= =?us-ascii?Q?6DtVYi5YhsCn9/qHyeBcQYxI453Ove1SGtD3DtQzvw6+WJPNLPH5L6Mfn5+m?= =?us-ascii?Q?/pRhWicVVUpir+n1l4vs9MyAj3/Z6T44CU6EDNXqoEKqAFjNhdnQwP9bJuoR?= =?us-ascii?Q?87TFCou4IIOX/U1+2WkCx9HXxIg043gTWoDz1SVGR22LBut4b9bJo0Chvtb6?= =?us-ascii?Q?y3cIs1RED5yKJjUjtypPSWRbMxiqsW5h1vxgxGYArJ1Z9mhyuLemefxwaXn7?= =?us-ascii?Q?3iJllQ+0KnbL1upX8qxGhfDJwWW+g/vM3mjjWuT3v1VbhcX0D50cgyycEz/3?= =?us-ascii?Q?Yefm26m9+DeadTVUaw/d4ilNA+fh7kUaiOkzwxPchEOPJqBYaL0d4XWBgUXz?= =?us-ascii?Q?bqcOY9SYXmMSBd9anE/eV734nkqLM7WYAkdOS6TGRhx8yZFLrvznAlMJ0StC?= =?us-ascii?Q?J3HZEUiOs1yHIlD2rrT8AzQ61CGgiLYf0MQF80t4g66aIBJycX5/ixCYOWti?= =?us-ascii?Q?sPQURoowrAYzR07vlR7RWSEdJn0LF0kmNNzPhRJG4w=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: b2b1d0f1-3ea8-418f-d357-08da9de31767 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2022 04:13:10.4350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB1565 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Sep 2022 04:13:16 -0000 On Thu, Sep 22 2022 at 12:13:25 PM -0400, Simon Marchi wrote: > On 2022-09-22 09:30, Enze Li via Gdb-patches wrote: >> In this commit, >> >> commit cf6c1e710ee162a5adb0ae47acb731f2bfecc956 >> Date: Mon Jul 11 20:53:48 2022 +0800 >> >> gdbserver: remove unused variable >> >> I removed an unused variable in handle_v_run. Pedro then pointed out >> that the for loop after it was also unused. After a period of smoke >> testing, no exceptions were found. >> >> Tested on x86_64-linux. >> --- >> gdbserver/server.cc | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/gdbserver/server.cc b/gdbserver/server.cc >> index c619206d5d2d..366a843ea894 100644 >> --- a/gdbserver/server.cc >> +++ b/gdbserver/server.cc >> @@ -2984,9 +2984,6 @@ handle_v_run (char *own_buf) >> char *new_program_name = NULL; >> int i; >> >> - for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';')) >> - p++; >> - >> for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i) >> { >> next_p = strchr (p, ';'); >> >> base-commit: aaf3f3f3bb38a59125ea34afa0ef7e0e14c2e916 > > Thanks, this is ok. > > Simon Thanks, Simon. Pushed. Enze