From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2029.outbound.protection.outlook.com [40.92.98.29]) by sourceware.org (Postfix) with ESMTPS id E0AAC3858029 for ; Wed, 6 Jul 2022 13:53:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E0AAC3858029 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ALNg8pIIrwzz3k56d1dRAs8/Hm6eOFX15a8/TVQYCjWox4AjAEfDLBWdY6PoLEctN4dLY15hrSCXwe8y51F75GzY8JRtkW8hwV0nEysNOTmrQwTdJOB52j2NZ5zoW0WaeR85iO8S2k5f5+7sIlgT2UxB2Dw3ZBqGlOvidFboKhrOF8BIAV5aBiKMe/qQhXq4S8ZqUKhT/QlaUR6cPKnkT+BDaroBfN9hTh+0fgnusbec6CTL138C6xkiXCOHZIRnek6XMua4ciI4uWMzdh216/Und+sCnQO5llEBGKeWjCTGPvf7JqxwW7sluGgUtAoQASWVhcUrT6kFh18jWpHXdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WQ2gC0Aypb7fHSZFvVoy/qKKAL7BYhfTklQn3RcnY7Q=; b=bJj1+uBhtRTDMQd2rkLjRIC3QOCEqy6xH0gy4NxyhRmsVpui1Q8ugUOh1SICRR8vukXdQLY10AsxGBZ3rmyimxh/K2YwbmGcM6N28o4PFKLjNoovJDaE1yBVk8lNVk0i+cUuPEp+gZ7bcE58lkTUcBvkCISMPonhYqk9Ee1XXmZs/S1Jpwwkw+ZN5n4hzv+gIGgqcqxG0aJWmblMP+Hx0IJ1p7C6Jm2ySTpw5/BOnhO5oJe9EeAm4iuCnt8uRwHlIehOLzJM9aOHhEQcr1kDgsVKCUdKsWkAIXWZ149TtWe8cFek64QwTaUwGobCov2PHW7hXIJVP3echKyva3eg/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OS0P286MB0131.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:96::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 13:53:34 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%7]) with mapi id 15.20.5395.022; Wed, 6 Jul 2022 13:53:34 +0000 Message-ID: Subject: [PING] [PATCH] gdb: initialize the data_head variable to eliminate compilation warnings From: Enze Li To: gdb-patches@sourceware.org Cc: enze.li@gmx.com Date: Wed, 06 Jul 2022 21:53:29 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 X-TMN: [zAcgJSBXVTfvdHjHP5erUIivXRxbBSl0] X-ClientProxiedBy: SG2PR02CA0134.apcprd02.prod.outlook.com (2603:1096:4:188::14) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <15bd43bfd5ef80bc467fa353047763bda9a79807.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 851cf4a3-2ad8-4759-0b83-08da5f56eb1b X-MS-TrafficTypeDiagnostic: OS0P286MB0131:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pJIqQdVKkWnL5UklwwLo0QoLCwp2e/M48lVdy+bKmmeZsSjGrxm8yImY4FPN/258Cf6V/FfuXbcBEeOfAT4QAkpw5h+THqUVtAL6e+NeLCnedjrhHkBEMCMcwAXrIVlv85UDfZ5Cma5f2zfb9in4qZFP2BnhTm3U7zRb8imALX0cS+175A6vt+THK/aNPTJ4gV+Rq11wMFHAvrD6Ijc2gWOenjDu18YC9ZBs9dWyDTOHapwfEXvHvhwokMadNsHL6LpA09T6q5GO4PVXyA3bsiYNeKyOOx4xu9iHGMJEGFJUfe11Op3q/VNdQLfJvYMi03W3a61fSZ0CwKnScA6YvkNzvh52nAXH0GJ3aMJ9bXFy/di6/h180TsDRFj7b50SQrew630rjPKaKn7NwVMzqh5KCMMw46fPGE/HBfwZpqCFhhS9r4aO+gWGNi+2a8/uzxAa765LG9S/b+kQejp8Y0Hq/Q/H5nfLEjZGenzLxKbmt3awrC9mEVpOYKrh2daWvrzBRg+FmMohMEFZ1+lGusy4H4vdOf8Fo5P3G57fGCBk8KfIZSbxI+QuqMNPw7GsYMx8I/a0/DP56lS5VuWaOhGLGcXbQi0tfyiIzjpOfIRU/9zlfSO+naz7A4i+6T1vlcOURygv1V3hxmy+3znZiw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rm01ZWszTjRQNTNlUk9uT1JSTHNHVy91MGFCZStlQVYzNkJvUHhoNnVpWlJT?= =?utf-8?B?cC9oNndSN05Cb1V6ci9KYkc0WEtHNCtvQTZCblRZdk1OUWZMZ0w3L1Z0N01I?= =?utf-8?B?UllHZUl5OFZiUjdjMTY5ZEZBTk01WWsvS01JS2ZKeFNSSjhSUWtablJXRytt?= =?utf-8?B?VFFyY2pTemZWdGhrVkpCenNteUpMWXFremVJeXVTOFVTcHcvTUFCOVU0djdw?= =?utf-8?B?dHBGM25NTXRrbHpma25ic0NKdHFlT0RCY28rUkZuNnFnYTVSNFRQN1JKU3k4?= =?utf-8?B?aWFVcXo0cnNJclJmOWRjYklUdkZNL3RDc3FVcG9xcDY0U0RBV1J0dklkU2dp?= =?utf-8?B?azVSTWQ1WmUrci9iV0ZKNjJka3A3R3RWaEROZ0taYWQzOXhLYS95aTZtS3VT?= =?utf-8?B?eWFiRTkyTk9iWU9CSWdpUTZVb1B4bUxUY2hERGdCc3VJUlBZWGtwTDhjVkRt?= =?utf-8?B?R0xtQlJhN2tub0svbEVMbDJWUTRVWjRvWDNLalhQbTJoSTBrdWVJMjVWR05H?= =?utf-8?B?Tlp4UVdydFA3OFdQdjMveWg1aVRWUnpjcUp5d1JjYUtnWUR5ZnExMjY5eCtG?= =?utf-8?B?dytmVmNha3poekR1NGg1ZnRpRzNNdldzVWVkY0t0QVBFcjFjWUYyWk9odFg3?= =?utf-8?B?bzgya0YzREduc2Z1WUdIWmFiMEdkaEdHR1VOb2FySXJ4K2RoeXl3bllxd09L?= =?utf-8?B?U29DR3BndS81RzRQcUc5Q2QxMGZ2RHA4emxvdUtnNW1zc0JoTitVMVNDeFFx?= =?utf-8?B?RSswSENFY1JoM21uWllOamhFdUtBeC9IQUNPS1l0QlpmTW9VUnFlSG5yd2cr?= =?utf-8?B?T2VYT0VyYks2dXpPWHJZVjVQbFVWR2MzRHBXbmYrbERNeU1YOVUvVDYva2dz?= =?utf-8?B?TUxDZnAwSVM0T2YwRGIxdkZaZWNTcndDYk9tZGs4VnJNdnJqS3B4NW1ScGN1?= =?utf-8?B?c0dxRDIza29OeU0xNWNPN0hCNTVpT2FVU09SSTdMN0R5MVpaY3BmVlpOQlZm?= =?utf-8?B?RExtNndJdEpyZy83WW45T0g3VXU4WGRSUWlldytYYWI1N0xUS0J2R3lhSFVF?= =?utf-8?B?aWRHNHdlamI1d1NYcTNzQk5LcTZiTHR2WndwcjFESjd4WE9xVWtaVFJvM3pu?= =?utf-8?B?SUlRMXZwYUpuMTRkbVk0YmdDUStDdTNzY1VDQlkzZEpMWEI2K3E0STJzNDZn?= =?utf-8?B?ZmNKYWFpOXoyV0l3b20zSHU0RkxFeE5FZXQ4bW9BbG5hMFdwdFRWUkNWRnZu?= =?utf-8?B?WUQrZEQ1SUJ2enplTWovYVprWnhtNzJ4Wm1kN3NiOHNmVmVlVDg5RFZrQmF4?= =?utf-8?B?UkpPME96clRlNlA1Z3JSYVF6NCtkaTlmdVBzRXZSajN2eCt3cVNKVjl0Ujkw?= =?utf-8?B?YXFDSXVqTUREcnJhNXo0Wm1LM3kyNlNVVkdVUEQ4ODBUUWZJY3g4OFBsUlV4?= =?utf-8?B?ZmVUNVBuaHBrNXlvT2FrU3orSy9sNXpvbmhrQ2hpeWNRTm1Ma0JWRFNXNHNQ?= =?utf-8?B?NnFXamIxREFmQ0x3NytFY0UvbzRyT3FqcGVYbVYveHpzekVncWFldjc3bUVP?= =?utf-8?B?SEtTWEtHRUFDYjhrU0F3YU93dEJJS3p5SDN0YTFncWU5YVQzdjU3VXRYODVS?= =?utf-8?B?bmV4RG5jTXJxNCtGREtCM0tTNWRpTjZwNnlEMlJqVkhVR2RKaHNpVFRoRGtz?= =?utf-8?B?RDFuWVVkYnR4Y3U4a2NFc0hwV2JWVURHNkxVa2F5UzBpbzVjR3IvVXBnPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 851cf4a3-2ad8-4759-0b83-08da5f56eb1b X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 13:53:34.5246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS0P286MB0131 X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 13:53:39 -0000 Hi all, Kindly PING for this tiny patch. The warning mentioned in this patch still exists in the trunk. Does it make sense? Best Regards, Enze On Sat, 2022-06-11 at 18:36 +0800, Enze Li via Gdb-patches wrote: > On a machine with gcc 12, I get this warning: >=20 > =C2=A0 CXX=C2=A0=C2=A0=C2=A0 nat/linux-btrace.o > In function =E2=80=98btrace_error linux_read_bts(btrace_data_bts*, > btrace_target_info*, btrace_read_type)=E2=80=99, > =C2=A0=C2=A0=C2=A0 inlined from =E2=80=98btrace_error linux_read_btrace(b= trace_data*, > btrace_target_info*, btrace_read_type)=E2=80=99 at ../gdb/nat/linux- > btrace.c:935:29: > ../gdb/nat/linux-btrace.c:865:21: warning: =E2=80=98data_head=E2=80=99 ma= y be used > uninitialized [-Wmaybe-uninitialized] > =C2=A0 865 |=C2=A0=C2=A0 pevent->last_head =3D data_head; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 ~~~~~~~~~~~~~~~~~~^~~~~~~~~~= ~ > ../gdb/nat/linux-btrace.c: In function =E2=80=98btrace_error > linux_read_btrace(btrace_data*, btrace_target_info*, > btrace_read_type)=E2=80=99: > ../gdb/nat/linux-btrace.c:792:9: note: =E2=80=98data_head=E2=80=99 was de= clared here > =C2=A0 792 |=C2=A0=C2=A0 __u64 data_head, data_tail; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 ^~~~~~~~~ >=20 > Fix this by initializing the 'data_head' variable. >=20 > Tested by rebuilding on x86_64 openSUSE Tumbleweed with gcc 12. > --- > =C2=A0gdb/nat/linux-btrace.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c > index b0d6dcd7cf1..c31fb5ffe43 100644 > --- a/gdb/nat/linux-btrace.c > +++ b/gdb/nat/linux-btrace.c > @@ -789,7 +789,7 @@ linux_read_bts (struct btrace_data_bts *btrace, > =C2=A0=C2=A0 struct perf_event_buffer *pevent; > =C2=A0=C2=A0 const uint8_t *begin, *end, *start; > =C2=A0=C2=A0 size_t buffer_size, size; > -=C2=A0 __u64 data_head, data_tail; > +=C2=A0 __u64 data_head =3D 0, data_tail; > =C2=A0=C2=A0 unsigned int retries =3D 5; > =C2=A0 > =C2=A0=C2=A0 pevent =3D &tinfo->variant.bts.bts;