From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2090.outbound.protection.outlook.com [40.107.21.90]) by sourceware.org (Postfix) with ESMTPS id 7147A3858C31 for ; Thu, 14 Mar 2024 13:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7147A3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=xmos.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xmos.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7147A3858C31 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.21.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710424005; cv=pass; b=ExR3wV/hoBE7iENz1QD20gsgZhgQsZFKl7TJXFfhFA45wA8gsQzzTqLbQlQd9ebcvIeZ312A/VA/7NmwpPSnEvCItJpfZzNa83BS075mJeCE1fGufmCVbA+qJdw+rFDNNoi2iNAfxJ4lX15kkIHjTaJiFJuutF8ZY7o9e2ih2DQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710424005; c=relaxed/simple; bh=Po8K0JKVEXF9ueJeCnxWH7U0NiVYopG860cNUW4dAx4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=klPka69ZYyewnRqYRfXCZ18P/OGfRpViIJaMln7FehVatTrl5i9SP4RP22VngL5RgT2NwZ9KXOONfIyjr7+/zhj5t+75XLv4HEuXO2M35I8MZk8ND5b5auqDmVP1T+r/786eeOdhlmI5SL77vUpLlKOZtxWgfQ9Tn4Dj78TfIQ8= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A5XSP+zDfxJhKGP1m7PVN0f+fztrCJtPDtzLym5RMHpuleESLLwNKGwZ2wPyGTEjOwuYOohZPQkc2CExY36goO427vET3vsv7VK4Z/PnCS9hqiFQ9cGJ1/ahPISW6P20P0vjnhUTiIaw7F8Zj38iyE5gzbTaKrEZ5wKqubZIhUerMH9P+IxzquOF9j+NuebU1mHvyO1xQr8tsNf6vOVgLKAZ9ThyF+jk2fbKKtA7JDveGi9MBtL05Vvwn7Ar3CASjeZxWgzndiWcI/dVBuo74iANqZZZR1Un0emcyh/PwmqwkWd+UYngA2lL+OjH0A6+H0fsGkFXi+M5tfiWgLZ+pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tqhGrw3ApN6vfCTREButJ1ar7uTZlIjN71hI3H7o7Zg=; b=IIcFtb/qW8fLxQ2y1P55TGT+Bc/olSDGIPJEWpCqF0S/H2nBRQLLz4B17EyBMSRbG/a/Kx1rjitzZSkpo5RjMAUpho72rId4wdkQvfzEuCIdpw//17edQ4pOlpUuOwe7sglEzH2/HjMWgp0xL65d4SPKwOkhy7Z2JGiRrtQcQCNEv6IAjI0K1W3OCHsXtngnMG8GqzeOp1mEBWDVHtbiTzWRtatgX4JVG7Z1oTIQ7hZBOTH4Tik/d29fjdd7C1OHrZW4RQyrAB8WRMD5FI5hd4S2SyGVNzmXarg5Zn8LcZjGISkZ+u/5WGyh2lWooiQVhLWVbKp3+++y0FOJZNhLmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xmos.com; dmarc=pass action=none header.from=xmos.com; dkim=pass header.d=xmos.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xmos1.onmicrosoft.com; s=selector2-xmos1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tqhGrw3ApN6vfCTREButJ1ar7uTZlIjN71hI3H7o7Zg=; b=eePXsEJ5rxj6R4zfHclS03RTVrToEbvcMtqAxQUGGh3MO9oO+AAgYSqdKSolBv1Q45G9g/WwS7nkB7ENvGSmgcDPWV2yrRqrflT6qSvLve93W+bS5GnqOSdVleajcT3k3wmM4Sq1A1+OS9uYv6eLX7mqIucCWuRtHDCEPEtk9sk= Received: from PAXPR09MB5583.eurprd09.prod.outlook.com (2603:10a6:102:280::6) by AM0PR09MB3825.eurprd09.prod.outlook.com (2603:10a6:208:18e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21; Thu, 14 Mar 2024 13:46:39 +0000 Received: from PAXPR09MB5583.eurprd09.prod.outlook.com ([fe80::1338:c63c:6c3c:9090]) by PAXPR09MB5583.eurprd09.prod.outlook.com ([fe80::1338:c63c:6c3c:9090%7]) with mapi id 15.20.7386.017; Thu, 14 Mar 2024 13:46:39 +0000 From: Ciaran Woodward To: Tankut Baris Aktemur , "gdb-patches@sourceware.org" CC: "tom@tromey.com" Subject: RE: [PATCH v2 3/4] rsp: add 'E' to escaped characters Thread-Topic: [PATCH v2 3/4] rsp: add 'E' to escaped characters Thread-Index: AQHadhDS82DeeOqzgU+JoU3zWwIOKbE3O7HA Date: Thu, 14 Mar 2024 13:46:39 +0000 Message-ID: References: <2df4539dd59feb3b70f15ed679563a85bb286075.1710420898.git.tankut.baris.aktemur@intel.com> In-Reply-To: <2df4539dd59feb3b70f15ed679563a85bb286075.1710420898.git.tankut.baris.aktemur@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xmos.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR09MB5583:EE_|AM0PR09MB3825:EE_ x-ms-office365-filtering-correlation-id: 81f7f902-cf9e-4be8-bd83-08dc442d2cea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X+w1VceNfz1mtxHoLyZ1rX0jtFQnMFYwtwyv/6+ZrQvUT0zq9XbLnnpU7/os2w1PNzYyWSPo4vmzUf4DsDnJwK4SSAZH6KqCMUKrGOZ9/WqYR81lNfpSj4w8YF4mtGKcbThx6/6h3+8ktHpFRjuI8q8u9rj9ebIzLamen/TgYRGQtRrzRUx7l9AyUTDnT2f1rWzEkkz5OzZUfy195bhXOGrWDaqBiKFuoY/viPrPbezxzXhnzCzhJRXBR/fmkK4YMCx3dUNrgOcNWYUVp5X1YoN6uaSeXogAvNp8jSOsUMTMrKQ/uIYI9wgd8fLKEV4mqdPTAHv5sB/PnQjwST5K0AQHqt33Rg3GikPysDJhbAsbo2ZrTcMqYC80cnyuQwfYAVFAfY1LFPEGDoObFSpKXZROMqA0lovhin0FK2GwnYrN8xZ6aV3YSO1Vzep3YJiU6UAny421VYvf1aActkhyXt5c5/yTKT7BUyIsJHh+hd1QI+0TDcNYhcASWHqONsyKlpPf/UsNcMMmwiN1OMJOlcThNu7NzQgXpxg7fVezPQwK/CX1W5wRdpEWubTVgI+0j/oqQc05EwKe0k2NBMx1c2Dp9l5qUlM4HXjhsQBq4yWApTHGqgDeZ+rjcotuKxiYVPysMZfLAJeOxrQ3IpiqGU+uk1dffSKUDg3njlVb6Rg1sVFWzphvla2C3JzIfLPCUiaOVKOEIV2pn40YYCUN75QhNLlzOn+fROuBQ7+gGF0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR09MB5583.eurprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MTF42N4CGtztRQD/1QdCL9EVmytkar+9KmhvAbNvo3cZyb3tStGefs0H2N9c?= =?us-ascii?Q?SU9Jexn0J3aS0NPr4/729vzlXJxizallcnX/wnqlkjkFvPC++ZEiHNlK0SYB?= =?us-ascii?Q?SvtSjSR2LKDIMl4A5JB4cZ5rFKMVN9x+uvoh8VRP+CTdVWwjzxNIEY9lJaVW?= =?us-ascii?Q?9tIVYDhtD9W8JfkI1uhvySgPp8Das+K9lx6AIfyQM3nRAteavPQO23n+ptLr?= =?us-ascii?Q?ozsXiNR/ePiIkOde+bzaZlmAcO3/f8lr0ehV07PcO5Mk7dKkmUoSw/BQBXg7?= =?us-ascii?Q?Ny1Fo6C7yZ8VzZtfam4kDlZ9kpStn3C4NqhBj2T8sCwbQDzFUc/kQdZvX+87?= =?us-ascii?Q?QKjLnHKSKJ5zqmH8g/WMPw//1snDslWvSar3eUnoR63TP7v3LmXzP1j0+7Yc?= =?us-ascii?Q?g9dEQk02IX5uUwmPy9x5oSuHSbfCDRVnJ6geVrtFPNui4nz7n/JVSuP3j4Jv?= =?us-ascii?Q?V+sPgRhDyR1fZXq0FC1U3E9lLbn4uIFDQqFGA5H+bC8hfIkZQ2f6b9+sjck8?= =?us-ascii?Q?TdlktvCO92JFQwS/vhdXU9JNG0Fc1HStxe6uU6JfL2+Mw45jdIYgoqz0e2K0?= =?us-ascii?Q?ySjf0aCuTRscIiV3gaT0odlfNU8eGw5CZmsNREmkw7uahxHR2FfiPlVlGzg0?= =?us-ascii?Q?Db0yO1oY5RVWbgGGaMs8/BTsrmXFn0kBuBVPQwTrjstNS1Pl9V5mHp2x+119?= =?us-ascii?Q?OQ1fsiqBJ+K7tCxBCdA0EGkrZ3TrWRZewhZMQfSnDsiw5zgSV2YIPifpjX8W?= =?us-ascii?Q?8vIUuqGAUd9TkIZsmiBJzJI2wH3nydcTabX5wumLU0ely8IcD9oWPik3aTjq?= =?us-ascii?Q?UvqufzOurH9cEpnOHKlQjtdXm5LOA/SEHTfb1c4B39qpG3KDywVyH3/A2nbu?= =?us-ascii?Q?7jlrQnvvkdbmbBNJMF8MXNRi5nS2oWfr8QhaJTzMNmrDWr8UeurLz1oLXJTV?= =?us-ascii?Q?4h1kxhW39o8R1kOqh3biFA2m72Hv6e2X46JXY50qAGLTfBYWNoSTQ98paS+S?= =?us-ascii?Q?SbTYTfQJJhMMhg6wziCLOfDMPh2yFE/Pp0IY959Vu1+j6Y/gkeNB1LkwpouN?= =?us-ascii?Q?XCLdGOvmDzV6973SXH8ShzpegguFmTFXcEbpXGdSu3BEvPkXy/cwR5XhyHd+?= =?us-ascii?Q?Y6gIO0Fj1Ef81Oe/vlPcJWCXe6I0FjN5gqAKyTShtbJEIWJzy9fNBDt7x6qt?= =?us-ascii?Q?XR7xkuY/ylC/muw0eezPmmx9G0u36rob+ziVhi1LnYi7khoExlpN2Eb8m4FQ?= =?us-ascii?Q?uECU2xe3sis34CILrfZyLIVXz4mo9beYULQ7MnBXIKCSbJh+7MY0iUSyrOMX?= =?us-ascii?Q?e/2dKBdxG3RpBPvZO1ZH/T94JFbIku7gjB3ulvUMYCAL9gZd6SdH+RgCmcB2?= =?us-ascii?Q?2oLRthwIal1lCri3OCX8nsu9KBiLxho1zWJ5Ax/AfnnuhX33f31PI3FDGJoM?= =?us-ascii?Q?aW98tgCci1Tp7gEHKzgwJMsPvl/J6wNK6OuhWUv+kJFDx6z/QUJo+mIFVeHv?= =?us-ascii?Q?3CFj4IM1zMeQQEwx2XwEQBWhM1mlmZMGRqqlJ3hM4Pf+SuiG8hxm+zOSlDMv?= =?us-ascii?Q?VKADJ3/xnvUdqHMlibqUE8Kq6pgJkBhbo0CycFt1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xmos.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR09MB5583.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81f7f902-cf9e-4be8-bd83-08dc442d2cea X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2024 13:46:39.7488 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 975ecfb1-4080-42d2-a01d-4a4d0707a539 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wkjR5yNk+xWAFNjy8tICp11flTqXTUtmm9g8jSgFJvLFF+foB2TeJkHwMOzHo76IQ4RN2FcxX/qj29F6tsI5iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR09MB3825 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tankut, > Add 'E' to the list of escaped characters when sending/receiving > binary data. This is a preparation for the next patch, to be able to > distinguish an error response from binary data that starts with 'E'. I wonder if there is a better way to do this, given that this is for a tota= lly new packet. My concerns are twofold: 1. The other 'escaped' characters are part of the RSP packetization layer, which is conceptually below the message processing. This new packet is looking at both escaped and non-escaped message in order to figure out which type of response it is looking at, which is (in my opinion) unnecessary layer crossing. 2. The idea of allowing this list to grow when there are other possible solutions is just less scalable if other new binary packets are added in the future. Instead, I would propose a similar approach to other packets which would have the potential for 'ambiguous' replies, such as 'qCRC', 'qMemTags' etc. That is: Always have a leading byte (not just in the error case) in order to disambiguate what type of reply the message contains. So (for example) the message is something more like: 'E NN' for an error 'd XX...' for binary data Does that sound reasonable? (Note that I am not a maintainer, so would appreciate other opinions!) Thanks, Ciaran