From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2090.outbound.protection.outlook.com [40.107.104.90]) by sourceware.org (Postfix) with ESMTPS id 08F57385841C for ; Mon, 20 Nov 2023 13:25:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08F57385841C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xmos.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xmos.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08F57385841C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700486736; cv=pass; b=Q+VIEOMBR1IKJ8DxylqVhi8WKNCwkJzXdqKjI6a9Pri/ZUOFpMi6I6RTZtK5WjUQv52t1b82pScLf0cW0cMmJTx+Qtz+dTFGvVX5Lc2ZWaS354Z2H3GnNffECHwZ/BGPc3ahqd4/tkz11ew8Qmi8tUVVKeW42ZaHnyICsPQEPA4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700486736; c=relaxed/simple; bh=Fc5K8A/vr2jCONYcwV/G9XMPI+Y84VHTlg0+yMt5Q78=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iHC4luWRZjMiJEC2VziKMrv5YsAM4uVb5uC27aiM3zg0uOry8nIbgLUarg3VczOz1THhpGL5RKKzUbvhy3JyrHtiCVr1MEtpNOPKvmAD2myDhTMIAZFnhKH0HZBrvkY0KoCuMy+6TgBTpQCqPPUdg2Cy7XnQPC8E4GBSOMI3HfA= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Duzls0dhnMUmfGaERknTdcsDFgymZXmvuNUDugWQ02tAIZjYqMjgIbQaz2oYoJYzoMT3xvx3qcdjmwRJQstb2G4FJV6ECd2qxDb7gETJ2KPg9tYJ2e6Y6zZl9ZKWhRANury9nueGyS/J0llxBl+oCIi3zNrWp0mru+QmkuvdpnFa9Qb6W/Ud5YJsAqamYEKcz0Evm5vIn1RH+NveNyeOU2oiebOOUBH8ziVXiEaNAi8MS+5xqx7iGz0nNvi7avHX6lOBH6Khcka6nfaXZGz4VkuedPuMHikUYhaSVXD//oEIcYDfUGHGOJ+wNtHzm8dRtULLICZTwt5eA4qJIZpnBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hTiy2lNjVZiyEbBf0zlhne7xTNTmPd7xWN3Wd648As8=; b=QBENCKob6iCglZP3uU1ZUw4G+Sw7VWGvocg65mR3rBBqIPO4/IDwk5taQhyBoK6B/g0XrVD54qaEfFyevldElyW1EdUqLexAQOt1j5BsmLEFmfBV5kIHTgszO+RCykGyQD9s/45XcW1zSGTVOwvRKflIxtDvWdRIOztF4OztMUgjMB8Z8xBY4qPNidCFdBras7jK6XC+KZMJlmn2HgjUcNHBH1v7HdzfkhMGXBrqxw+sqEwH4ZFnRpr1seuTvg8z4Rp03BigTZKjEnyWWAEXpi0G3hX9p2AbJeoLPm2BZCg5jDqZJYYoy6OfJgzkpqhqi7e6XdrQ4sP8hpKFT66B+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xmos.com; dmarc=pass action=none header.from=xmos.com; dkim=pass header.d=xmos.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xmos1.onmicrosoft.com; s=selector2-xmos1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hTiy2lNjVZiyEbBf0zlhne7xTNTmPd7xWN3Wd648As8=; b=icO2ZnnGDny8+SesDah5nHIMBxoQ0FudESr7edVq/4Kz8DHHIx80/k+v2Adbtne1XbXy14IT74QKJjfQAOnAcE3llsYeum7jvzDRhgXb+21SPM6m4zoL7f5XL116OCf7MZUyLZZTUKatyG6xdpA7Bv4aiXxnS8JXRPD/CQnTNI4= Received: from PAXPR09MB5583.eurprd09.prod.outlook.com (2603:10a6:102:280::6) by PAVPR09MB6205.eurprd09.prod.outlook.com (2603:10a6:102:321::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.26; Mon, 20 Nov 2023 13:25:30 +0000 Received: from PAXPR09MB5583.eurprd09.prod.outlook.com ([fe80::7bb1:2b0b:2733:2340]) by PAXPR09MB5583.eurprd09.prod.outlook.com ([fe80::7bb1:2b0b:2733:2340%5]) with mapi id 15.20.7002.027; Mon, 20 Nov 2023 13:25:30 +0000 From: Ciaran Woodward To: "gdb-patches@sourceware.org" CC: "luis.machado@arm.com" , "aburgess@redhat.com" Subject: [PING][PATCH v2] gdb/tdesc: Don't assign custom-group tdesc registers to 'general' Thread-Topic: [PING][PATCH v2] gdb/tdesc: Don't assign custom-group tdesc registers to 'general' Thread-Index: AQHZ5jc/DMU/2Vf//0KhUrDZAeorcbCDnaHg Date: Mon, 20 Nov 2023 13:25:30 +0000 Message-ID: References: <20230907170752.28639-1-ciaranwoodward@xmos.com> <20230913114126.23101-1-ciaranwoodward@xmos.com> In-Reply-To: <20230913114126.23101-1-ciaranwoodward@xmos.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xmos.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR09MB5583:EE_|PAVPR09MB6205:EE_ x-ms-office365-filtering-correlation-id: ff0d8f71-4f9c-4ef5-b94d-08dbe9cc2adf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fO4hvYZXGV9g1oScmjB6OA+d5mDx97K6t/4jjsU5HL84NikD/iltD5wRc9+27ZOzTB66Tc/ihxC8i5ERbHkbbz2ES2myVW29pOkbKE+M7x28a/27SvBkSXEgcf1RXqdlMVfNfn4ftURQg3kLMAWpCligVrgqjfHtWc3VDXLji4ca4wUZswRmH0S8p6I8oEJk5vLlD2oygMpLonNBlgoSo0D/vEwhZPEn/fOQw4nidklI8SnhU73W9aIvHuJoiilvkcrvfqoUTg4TujRqnQFQMejfhZoEqHsD+JHF5ippLYlParWpV2fLcp6PaeVCMcMowa/CuATGfdw9V7hhAD3YVEPp73l9HGoRtpefAPhRsKLr+Fx7GZR97hoCHexALFS18L7qmsiwjk5CkvOqqAGrJhS9ZojGMQ4ioYwwGrEjpeR6uG3t1JLfSVwEv3fvpYvCUdMtMV1U1drmjiJDUQRzb6uOhajineJqYzjX8Df2q5SdX6YH8VkhMKg0z9Wjdn0v8L+CZPcyugNMytcEJdcFNsbztXe2WFDwqbmRQJWxqGPiuGBIQy+pdZmiq1ijpA+Ep1fkrQtDXmCpbmPcjJbnQqs6cDwUw542KWMg2z78MD8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR09MB5583.eurprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39840400004)(136003)(366004)(346002)(376002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(41300700001)(52536014)(5660300002)(33656002)(2906002)(86362001)(38070700009)(8936002)(83380400001)(122000001)(6506007)(7696005)(53546011)(55236004)(478600001)(71200400001)(966005)(26005)(55016003)(9686003)(76116006)(38100700002)(4326008)(8676002)(316002)(54906003)(6916009)(64756008)(66946007)(66446008)(66556008)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SmNkjHkijgzF5j6B73mOFw+NJRhwpnmFyPGjBYybFtinNLE+PX9jDElnXcKj?= =?us-ascii?Q?RPNYdR4fB0aCibS920GgLuF8h5RIBrVa6eJ88mz/4DuT3dxs0R0WIUfk5gw/?= =?us-ascii?Q?oyQP495WSYw9oKt8jwUZ05aY4g3jIcabZvcY06DKpGawTlWVggwpmoFu34il?= =?us-ascii?Q?M+PpYMRiu6wHvfKH+PHZ9XpnsDewhGjD5sSH358xNpUz/L/Us4gZl0T5hdnZ?= =?us-ascii?Q?uVZSWPI5wrDaopOybNNl5DTz6RcZflhlyP3gykoCx5EpgOCHRfhqfD5zzWJd?= =?us-ascii?Q?7zoy8UFrJQgcXqzqNs3fnHeRXtUvodtE4VgvR8c/bu77gAfwBvkLokLriRJY?= =?us-ascii?Q?1pJOI30RX9vmmZP2BRxILfOVS/0DLUtSa+pVtXpaP0zchAJp5uFUlecc9aKH?= =?us-ascii?Q?EQVfz4GKZyXRJNuWegH1H8gA0e8Dk6uWyg+wjPshwTd5ZznDYwFC7n1tu3f3?= =?us-ascii?Q?jgK2IjxD4pK7xVCXsHYiB31BqW0h9GXoOk7Mgol812OZFgnAa/shuThHX9wR?= =?us-ascii?Q?v5rCFOhFpcv1CnX76YtP+sTfvgEGxB1ujhXWEY0pU8GhwRA4IsQqaYu4YhNp?= =?us-ascii?Q?k+VY/VwVXLt2G4pRR/5bHZXb0JGIfU14xOO2zdGyV7SodjYGO80xYQb3ehnw?= =?us-ascii?Q?rk3s4LtN/zc3GSGL+HG594CYQPMxULO3HHxKRgw92SeAN0JkiuiKq1r39N7i?= =?us-ascii?Q?U5Tdxo5bY4xK9dUAoMsfQVyxLj6yyAbe97wt4jzWLkep5H5VoCowdkLtdlFe?= =?us-ascii?Q?ZXAA/VrHmVcUsAjm3p61Wa5RpW6dCsC+AetZwRBhRuPiatxZJPPZ0cRc5uSx?= =?us-ascii?Q?CisFdhDArMQXIgkTL622dP0JMVQ2iDKO3O1j2Aal7/SgfZ3Gydj3bWMtv1pv?= =?us-ascii?Q?m3Rr/7YczJv8ix/2YmkXTT0WjQPIbDM9xlneg3HRqyswotKrveRCarmNttAM?= =?us-ascii?Q?eczFFUj7X3r3z++PR2w7BL1WTBeripr/n9VlJCmxfSi6VaHHmhuRXU2DyGKu?= =?us-ascii?Q?u4lBnQHAXnEmpUCs7s6i+cy/qjXIIizD7aJiX32reQi1/ZmxDQjlrYiXOvyk?= =?us-ascii?Q?kuAx2VPPSU4nUk3Lp7PVrBSZy/pPa7aXsrLWyPUniUlSHOpBRFREe2DIlwrE?= =?us-ascii?Q?iNVjENgBlcBtgQxbBuwsrBywAVg7n8T2D4Ns4P277HXEDCQFZMgU+XeF0sx9?= =?us-ascii?Q?v3P3fYtKlFeGvPhgzkK6PUFZD7ayb568ZSuk746AZqPK8rJT6uJL4LWXKbbZ?= =?us-ascii?Q?eV81pJFXsRCKWY3gdO5SLz8Eu5AmQGPvpuk0sVjCdZFLAb2Q5e1FEkw3D99K?= =?us-ascii?Q?VdN3xgpiCK6DbQkS+FJ+iWo91BNqDz0FZxnZqeccRKEu7BkhrtsktuvjeDVV?= =?us-ascii?Q?0llZ4ZkfeZaZW4t4VG+9XQq8VqK9GgcNo+cQIFnkSUWC/c7rOPigbjYr4niT?= =?us-ascii?Q?aRMbGZIWD1XqVcBKI6iMoaAZuhMW7oEZbu9bcc5wQzUuBfGdxIEu7VQpzzkU?= =?us-ascii?Q?UHoDAeXimC/3RuMiiFAa1YR3vSY9D2S+cIYp8B3DuwITE26ou02bTMooTXcQ?= =?us-ascii?Q?YZDFF2ydEX4vSHLcc3YnOZeEuQq21yH49oxIL1n3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xmos.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR09MB5583.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff0d8f71-4f9c-4ef5-b94d-08dbe9cc2adf X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2023 13:25:30.4542 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 975ecfb1-4080-42d2-a01d-4a4d0707a539 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HDHe+8tv2tCG6/nJECKhWMqVPeMGkUL7l92JlyH1172YgBSmwzZ8OkbXMHP5bts6JCUV7sLPwhr2ZdeElN62Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR09MB6205 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping Discussion of the V1 can be found here: https://patchwork.sourceware.org/pr= oject/gdb/patch/20230907170752.28639-1-ciaranwoodward@xmos.com/ >From what I see, this change is complete & useful as-is, but opens the door= for further useful work in future - to improve the tdesc XMLs. > -----Original Message----- > From: Ciaran Woodward > Sent: Wednesday, September 13, 2023 12:42 PM > To: gdb-patches@sourceware.org > Cc: luis.machado@arm.com; aburgess@redhat.com; Ciaran Woodward > > Subject: [PATCH v2] gdb/tdesc: Don't assign custom-group tdesc registers > to 'general' >=20 > The 'Target Description' mechanism in GDB enables the target to > supply the full set of registers available on the system to gdb > in an XML format. >=20 > This format enables setting the 'group' of each register, such > that they can be queried using the 'info registers ' > mechanism. >=20 > However prior to this change, even if a register was explicitly > assigned to a group, it would still show up in the > 'info registers general' report. This is unexpected, and also > disagrees with the comment above the tdesc_register_in_reggroup_p > function, which says that '-1' should be returned if the register > group is not-known, not the register group is known, but differs. >=20 > There was a previous change that did address this issue in > aa66aac47b4dd38f9524ddb5546c08cc09930d37 > but it also caused registers with *no* group in the target > description to be removed from 'general', so it was reverted in > 440cf44eb0f70830b8d8ac35289f84129c7a35c1 > as that behaviour was used by some targets. >=20 > The change in this commit enhances the usefulness of the tdesc > 'group' attribute for adding system configuration registers, > of which there may be hundreds - very inconvenient to request > and print on every 'info registers' call. > --- > gdb/target-descriptions.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) >=20 > diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c > index cdedf88c793..6eb626b9c5a 100644 > --- a/gdb/target-descriptions.c > +++ b/gdb/target-descriptions.c > @@ -954,13 +954,17 @@ tdesc_register_in_reggroup_p (struct gdbarch > *gdbarch, int regno, > { > struct tdesc_reg *reg =3D tdesc_find_register (gdbarch, regno); >=20 > - if (reg !=3D NULL && !reg->group.empty () > - && (reg->group =3D=3D reggroup->name ())) > + if (reg !=3D NULL) > + { > + if (reggroup =3D=3D all_reggroup) > return 1; >=20 > - if (reg !=3D NULL > - && (reggroup =3D=3D save_reggroup || reggroup =3D=3D restore_reggr= oup)) > - return reg->save_restore; > + if (reggroup =3D=3D save_reggroup || reggroup =3D=3D restore_reggr= oup) > + return reg->save_restore; > + > + if (reg !=3D NULL && !reg->group.empty ()) > + return (reg->group =3D=3D reggroup->name ()); > + } >=20 > return -1; > } > -- > 2.25.1