From: Ciaran Woodward <ciaranwoodward@xmos.com>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH][PR 31853] Fix printing strings on macOS Sonoma
Date: Tue, 11 Jun 2024 10:32:50 +0000 [thread overview]
Message-ID: <PAXPR09MB5583FB98A08BD4751C3C84F0B9C72@PAXPR09MB5583.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <87wmmwimwl.fsf@tromey.com>
> Ciaran> The INTERMEDIATE_ENCODING which this patch modifies is only used
> as
> Ciaran> an intermediate encoding. i.e. The characters which are converted
> to
> Ciaran> it are always converted to a different encoding (such as the host
> Ciaran> encoding) before actually being passed to any external API such
> Ciaran> as printf, so this should be pretty low-impact.
>
> I think this isn't quite true as the wchar_t might be passed to
> iswprint.
Ah yes, you are correct, I removed the problem text from the commit message and pushed.
My apologies, I forgot to add your approved-by tag.
Thanks,
Ciaran
next prev parent reply other threads:[~2024-06-11 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 16:28 Ciaran Woodward
2024-06-10 20:05 ` Tom Tromey
2024-06-11 10:32 ` Ciaran Woodward [this message]
2024-06-11 15:08 ` Tom Tromey
2024-06-11 16:19 ` Ciaran Woodward
2024-06-11 17:58 ` Tom Tromey
2024-06-12 10:21 ` Ciaran Woodward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR09MB5583FB98A08BD4751C3C84F0B9C72@PAXPR09MB5583.eurprd09.prod.outlook.com \
--to=ciaranwoodward@xmos.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).