From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2108.outbound.protection.outlook.com [40.107.22.108]) by sourceware.org (Postfix) with ESMTPS id D01EC3858C48 for ; Tue, 11 Jun 2024 10:32:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D01EC3858C48 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=xmos.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xmos.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D01EC3858C48 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.108 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1718101987; cv=pass; b=KM28qdGg5qvStPvMULLV6RqnoGbK7sFJh/kMlxhKkBdP2WZ41OKgxyCNLJe7OfG1wc4z6qkIVN2HzR5nGi4Tx3f4pR+c8DI6qxNArSIEFXKWTB7nhmwQWaiV3nmCIFFM9AXxNHKwo0MgVE8Psk5NNQDqHyZ81+XGEJMiuezQDvo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1718101987; c=relaxed/simple; bh=c48n81pl3G0nRWAAMQ4BD/xzcBJhnXD0M1j4Q2o2Vhc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vA+bvgo/IwcWziABxJC6r52GABdEbImFlqpqFEuli5p0ZsZpNJ/3j7pXfI24DC9NSk20SlANS/PQbCfWbisjzvZVjrtQQ6rFM+DHUtlUfqHT8z6AfPqEDaUC2urxXFuGcCWLc2JUFmOp4gTBbI6sN2L+xXCI6SCUPxf7YWb9VwA= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cVsa3+hg7NANq9zMyh01DT8IjPbhg4YOQW1CGncXfCUD/rs+C3tLqqFtUJt6yOQajwACt7zD+WiKqOWDOsV6Q9a4tUrTfzezbuR+9JQFAHEIFaVVloHN6CLlrFboswAdiLZ/v/ITrjaccfNHR+vz9TyoUmOLZgqhmA6DzaIysq7tE14+/0xpNRiAFcz0YExCcXWDOSPbAMj7I4qV1eOodBVxKkWZ0NuR2s9mzorkFRN3XWfeKaCMKsrZBUuPYEZ+hX3hVB/TTFUnaozaWG9TkMLgUaIUghKQhlpdie4Vn3HeZrB6DnuMOeZ2ZHruPBimsGcl5T56Zgr7C6JoOGKGfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c48n81pl3G0nRWAAMQ4BD/xzcBJhnXD0M1j4Q2o2Vhc=; b=V2LsHFubJ7kNXbbaz8UZFWOy3KqGjtG3GxORqMsZFdc9QpLPQIIN7g4SSTEJ+l3t+XZmadyB60NB8wHGfUHnq040v7Ro0mn1G5w9LjHHCUEG7rsGUjYaKdtCKnzz7BMMOfc335Q5D4p+QRpYI/b1VZ6WRzzuZi5gbtwhAZ7DOuzm6HjCFxobn6aU1e8LeZNOa/HBdIhyAInI01dC5R4iZWOOtyRB0ZcN0JxH2nD9iY+Hzc1KyX68ABiA0IRHIgzHg5Wxp8k12L1TmRbO1AWrS5JQAmfUUBJaV9T6v1Ua4d+JjSrMa+z7yhb9H9NASDQWQsCorJ9zZZY+okDUH10jsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xmos.com; dmarc=pass action=none header.from=xmos.com; dkim=pass header.d=xmos.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xmos1.onmicrosoft.com; s=selector2-xmos1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c48n81pl3G0nRWAAMQ4BD/xzcBJhnXD0M1j4Q2o2Vhc=; b=XzQu9Lh2iZQ99/3jq2ZiKx5nWx9Vymzfpf88dY2YwN3gKVssVyNHDE6JvqhniaQ2y8MEtRb/36pl70LVDVtXQ4HPpmALykGqtqk6KSr/g6SzaA+Zf00uUjj6YjL/KBJBW6lkIe5JiYqYZHnZJTtZdaNRjY1JWtQAYW28qMX/y2M= Received: from PAXPR09MB5583.eurprd09.prod.outlook.com (2603:10a6:102:280::6) by PAVPR09MB6617.eurprd09.prod.outlook.com (2603:10a6:102:308::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Tue, 11 Jun 2024 10:32:50 +0000 Received: from PAXPR09MB5583.eurprd09.prod.outlook.com ([fe80::a234:3031:e3c0:bab9]) by PAXPR09MB5583.eurprd09.prod.outlook.com ([fe80::a234:3031:e3c0:bab9%6]) with mapi id 15.20.7633.036; Tue, 11 Jun 2024 10:32:50 +0000 From: Ciaran Woodward To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH][PR 31853] Fix printing strings on macOS Sonoma Thread-Topic: [PATCH][PR 31853] Fix printing strings on macOS Sonoma Thread-Index: AQHau1MzQNmVdL3bmEWMhLUxyw8RhbHBbHjUgADx19A= Date: Tue, 11 Jun 2024 10:32:50 +0000 Message-ID: References: <20240610162810.1584-1-ciaranwoodward@xmos.com> <87wmmwimwl.fsf@tromey.com> In-Reply-To: <87wmmwimwl.fsf@tromey.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xmos.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR09MB5583:EE_|PAVPR09MB6617:EE_ x-ms-office365-filtering-correlation-id: 2719489c-3806-4979-d5d1-08dc8a01d7ef x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?J0+8ivi6C+qZsyjWU0W2DqtTTHWZFJI7zBfkabnV8jDz5/4rMwNNFGK5pXp6?= =?us-ascii?Q?1xze4DHZxJKmFh6RtKIajew7e8zHgml/FDvFnOBhY55s8HA0Fx6NluQ9Lrjo?= =?us-ascii?Q?WEZ1RHmB7xOEsSOcOkx4VGfEmTY7wIsAGNGwcIgw0P9/BosCMzXwIgPmCHKL?= =?us-ascii?Q?7WEJdkxBHGJ1w1qBxtzQ4dQJdE45xQVsHBsbZbM10cw7W+6xg94xMWbM20hN?= =?us-ascii?Q?G81pmbcLChIiEQRQlDFF+R1+my4WPLwJAdGDr4i0JJgM+LwHLO0nSlDVqBAr?= =?us-ascii?Q?yODms3BRUuUJcCc62ghrtrGcdJcpeMcOfwu5aJP/IoopTIGBPBrAhTkAKTYq?= =?us-ascii?Q?uzu9y8XnDSBCadfWAdI2qRxByP6TVStz5jrN+qeMlm1xX6IhmxNDREOFTrY5?= =?us-ascii?Q?J9Zp4yNGK+JyjW72JHXdPvglGh49UusJ7zRl1ZbMX7Stb49j8XtIxop+ix3j?= =?us-ascii?Q?bJkkx1CCZGXVUq4fmgUjhXJQbSzLtmnZUtkYZsTKs5L8c3BakQ0EMGCxjljT?= =?us-ascii?Q?HaOlo6AHqGb4t7PN9+dDMgHNIq8DHtHgCJKl2IdSbot7FnmNguCXq40jOLTv?= =?us-ascii?Q?mvnxxRKvvO6YxjrjiTcQWYFmNCSi9EYjTDvq3JFBIFj2XUPvJ9BZTd6EwmPU?= =?us-ascii?Q?og5HF0arWfQtHA4uzHvo+/kyOXd+J8JZE2Fx/s6xnvNKmf2/IR9sNuEOibW7?= =?us-ascii?Q?h58RI2Yvy7OgxCunC+SjFd9pO7tw3svcUMtO1sjS4n2HKyFtcP/TUOMN4PNJ?= =?us-ascii?Q?6nZOJ7ixO19GLKvY3OiIlkf4GEOwzWzLMNKwXy2zfo6QxiRWQOpoKFwOppPv?= =?us-ascii?Q?v0A197cP1ZEyn05oSJFJ6cRSiTnnlQFiiEthV4hjd4EYgPMZpOjvw4ifJG04?= =?us-ascii?Q?Feg1cOKPmhvitQc8W+WyMftCsUs3LvdDoUyk8L5tz6oJTpMHygB4PJXf8Ou0?= =?us-ascii?Q?fHBk8mjOOGBKy0I+ilXNZGHCZZGcd2E9mq/3uuIaSmQ5BCgJgOazwGFKUHL5?= =?us-ascii?Q?N47Rz8N7xAm+rWyuAfUItgqfJteGwd81yxW9y5yGvLinjXtw68UsoHW1EBKn?= =?us-ascii?Q?zJ1afmzN106JJ8eaB5x9i6gEHePZwnxVOHTReThmF7tw6SSsYg1MlajgWz5j?= =?us-ascii?Q?LtZ9bmfZZnMMMp1VbLi+OFtPNyJ+lU+zrk6cLu/ptP7Ih85ak1rjZHK/Ojn7?= =?us-ascii?Q?RPW+4xdeMEl8Lx1R1KrIYVXp4fk6NKpW6aBWyNXPKLT82GXHePNaa2mjzSO7?= =?us-ascii?Q?a3pZgzHRZg5sEPMmwSBmshKx8vjolBBOy58DZC6CDhcXfRZZqUZ50AAI3mgI?= =?us-ascii?Q?bpl3jh+31h6FOBjEyj+/ahxynJkoojSyNP4Ex+OfVvXvPiys/Px7FKR//rVh?= =?us-ascii?Q?0lxlrvg=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR09MB5583.eurprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mdZQu9V+gSKh0heDY9svmP9sKaolfz7W18YlUjMFUE+iSX6CN+Gf2ftJmNiV?= =?us-ascii?Q?7DdfuAWhdwuAFLsqc0injjCkhfs1hrSCf1FZC0wsP+Y3hvBNbA0aL+8yHwgZ?= =?us-ascii?Q?ZXLtVJxpiWJ0jOZmHeFG6iXv3w6qBUo0opTncSgIW+lR6Ctmcvmri4NqCREn?= =?us-ascii?Q?69OH4GMj9wmh9F87bJvv/tPczXH0YY8kCmQgwPOlNbc1uMpUs8HmAKKTSFvr?= =?us-ascii?Q?pQHoJc+jtS+un9SmD9nvQhIO5w2qIp3TEk9DPymkBpxXTT+oTuN0CUMW7MQf?= =?us-ascii?Q?Y2utgUNR4fgbwD0peyszEOxIUtsGkYi+N3NcvnLXhLmCP8FWwW37yC7pEbBA?= =?us-ascii?Q?TIeySiXdNaTHbCyhaCG5eR0uAboDlZnhDJEKUs0jjUMRGRwkczOGmqiTFr4U?= =?us-ascii?Q?c6tApD11hhvVgosfbQV5LbiIZA4U4AtOeOLyYL6qs0yOUDwwHZbuWFyBziGx?= =?us-ascii?Q?lFn7YPW74cNPwY2dGFCjsrz0LLrK87bBEZZX5MT0npNvmm/Cr3JSXABL586k?= =?us-ascii?Q?POcsmaHkUD5JLG3k8YJed3RGRL0Jq7JfBTbWmgWsI4JmtofUXNFyi26wL3SP?= =?us-ascii?Q?eljsdw/ES3/ilNIRig2WVt6SZn30NpBYidbwBOMTxZV2+nXG1BucNDpo6Uwe?= =?us-ascii?Q?1n9gz+QlRrBBk/8ENfCbezTTPmNCB352UsgoKW2gEAwUC7IHi56n17V0KDI0?= =?us-ascii?Q?sOSN7iGUzdD+vepwl4Pefy0vhSDsv2uHyTtzCU92plVzpWVqvMVYC7tgyh/N?= =?us-ascii?Q?ij3xf8tDe8AAEyVol5KltzQX+8LApVHwOtnO4NNXc2pMnpLhUtJlPn3p8Q+q?= =?us-ascii?Q?vZT9cAb9Spu2W6pAT761UqksW01/Fg7G4rrZX1fTHlG4cUz5QWSvOQnxvaAm?= =?us-ascii?Q?NO4JZ1fHnF6aQ8bZkUelBHv5aV6Y6QmweSDuIcT+3zovSXPzepNF7oh6XHKC?= =?us-ascii?Q?CXx4csZGpE0x5rYeBq9nAERFh97pujF/AfeVCQCqOJt4vcinQvs6CrCDP9o1?= =?us-ascii?Q?4B/D2sScP90By1GBdXszXQZGsWcickWqxdXDVyG1/sUhZdeAvj2D17fPep6d?= =?us-ascii?Q?1gS6jjmfk6ISKE5M4+5jU5uIlg/Sw0EEf4eBZGnOEPMBHWtK77b456xhpnIL?= =?us-ascii?Q?jyPdQUA398FnpjBuKoq19ndwPGy6e4jB6YhJSPNtEIo4KB31W17GvPmhDcBX?= =?us-ascii?Q?F0pxUVdjWUY1cTPQMAvSdxk8ZcvUVqQkyrngLBQNKafpnARXVggBipSUe5g4?= =?us-ascii?Q?b+zEWxbjm7l6clSAUc/cTFyYHWWuaOpZgZfDgwZFohQhiWBNjYnP3BfXN9N4?= =?us-ascii?Q?vzkqbXPSVfGDHoPznzt0pyqqfzXkujJ+HabneuKtkoOhK/vjHXGxCljrqkUk?= =?us-ascii?Q?+I/RZJj8fJxNi/7fKqPCIV+dI68gTgOMHwuUMhr5vYoPZdmJpna6MsLPWzSj?= =?us-ascii?Q?QuiHslVaimF5H39aFc8Cgbnz/9gJbGglpk+9CMCDIG8pDChsstdOYRMFhLJF?= =?us-ascii?Q?GT5uGorlkzWOx5C5qxYBmXKgdFnUTKooZGAaX9xr3OBas7W+/tk3ktpA1KR8?= =?us-ascii?Q?SB/gTUxyczqbpTnciR/+NWl9+LgNYqHG6Be+zkPn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xmos.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR09MB5583.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2719489c-3806-4979-d5d1-08dc8a01d7ef X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2024 10:32:50.1712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 975ecfb1-4080-42d2-a01d-4a4d0707a539 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nuPJ81x6lbFrBLko5ikq5UdlhSckaUfM8EM9ItY7IPVqwjWq2auKjLKHUvGj8Y6mDFMHcwVRy9dTX7vxbPxmiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR09MB6617 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: =20 > Ciaran> The INTERMEDIATE_ENCODING which this patch modifies is only used > as > Ciaran> an intermediate encoding. i.e. The characters which are converted > to > Ciaran> it are always converted to a different encoding (such as the host > Ciaran> encoding) before actually being passed to any external API such > Ciaran> as printf, so this should be pretty low-impact. >=20 > I think this isn't quite true as the wchar_t might be passed to > iswprint. Ah yes, you are correct, I removed the problem text from the commit message= and pushed. My apologies, I forgot to add your approved-by tag. Thanks, Ciaran