From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71]) by sourceware.org (Postfix) with ESMTPS id BDFAB3858D28 for ; Mon, 31 Jan 2022 14:19:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDFAB3858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eKfO+BcAywrzcuhfAazcQrbiyLF11yzfIIXIOu5edUrIN4TWrbYTBK8VD0xmbtNOpR188GXPVHKvBIbyA2pExGRGKcVJkmkbdSsmIXJkq6YyveEWVdpMxP0ZlGHcxFOWlQAVPsdnehb6vM80hLduhcDI34LAHkfaKz0otB9GQTafRCnW5UhAOvHgL+yjeHAOk2ZWiltqC4sgzE1sdZ246igIuuiDOTfOeNFDnJ2Qpii8na6Fc8uf5sNdRin8Cp2KvNRvMIPjMrR4I1lpJVkBHno0nB+uPA7S36+0ia6FvFnFVgVprr+1MLnv40goYvRiL1C90NV1oAyPeXsdV9bTMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2h+h6ZjL8i3WBZJcrRE2U/+DXPzkZmbktY541+edTao=; b=ELnE7N7dBNOzfUv7sSGwsQnRxUtpgATnxXsxnNmtHK+uYYxbqQubRftr+ZXWesFknuXXdvLPUG8cuy7ZsZaB372mPyk5eSVJ9QCXkzkpyI2cq7gc/dLkTES6s9yqT3pxGlUu09jdwbW5SG75pbSPpWcPapRJVN+Bve+SnTmsGVtpjawtDfMT6CEQXvLkqoZNM/1+EmsBZTcqjC55/Gt4jZ+cqH3OhhFs+lkMwrdMoyIuQgGGvNYEjqopvJxJz5Awbwfqp1B2S+0Q7/UVuDKkdMotGZMlivyXJI/XERP1mtWVTX/mi9AhSiuXT3PF0kuQMKTS8xRXYD3HmJeTtSoV8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR12MB5452.namprd12.prod.outlook.com (2603:10b6:510:d7::16) by MN2PR12MB4406.namprd12.prod.outlook.com (2603:10b6:208:268::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Mon, 31 Jan 2022 14:19:41 +0000 Received: from PH0PR12MB5452.namprd12.prod.outlook.com ([fe80::c071:3b53:4a01:8b91]) by PH0PR12MB5452.namprd12.prod.outlook.com ([fe80::c071:3b53:4a01:8b91%5]) with mapi id 15.20.4930.022; Mon, 31 Jan 2022 14:19:40 +0000 From: "Six, Lancelot" To: Bruno Larsen , "gdb-patches@sourceware.org" CC: "lsix@lancelotsix.com" Subject: RE: [PATCH v2 2/2] gdb: Respect the DW_CC_nocall attribute Thread-Topic: [PATCH v2 2/2] gdb: Respect the DW_CC_nocall attribute Thread-Index: AQHYFFPaOkgyWFHIrUSeugLSM1mH56x9IcYAgAAOyDA= Date: Mon, 31 Jan 2022 14:19:40 +0000 Message-ID: References: <20220128142931.39750-1-lancelot.six@amd.com> <20220128142931.39750-3-lancelot.six@amd.com> <49c17cc9-fd06-31ea-b4f1-174c26b7eb9b@redhat.com> In-Reply-To: <49c17cc9-fd06-31ea-b4f1-174c26b7eb9b@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2022-01-31T14:19:37Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=66c24e47-376b-4890-8704-9c04a3fc5f27; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=1 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_enabled: true msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_setdate: 2022-01-31T14:19:37Z msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_method: Standard msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_name: AMD Official Use Only-AIP 2.0 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_actionid: 997dfe1b-2987-4bae-8818-6ce016f3f518 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_contentbits: 0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b78f283-4df1-4da6-10cc-08d9e4c4b814 x-ms-traffictypediagnostic: MN2PR12MB4406:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SaY455ujgpxscDV1XbH2MSgCd71sk6h+iiocRb4IlCEwNVOcXD1Yj8buun67h40SNGQ7EO5S867G+JHdGoRawwc5Q6TW9b36lYJi48YCNYokyQUhKsfsyPFac+oaCGvS95yurru/jzKZgMcvz4YwUsyt59OFF8aSPWUnAmoDKeKvPKZQDsBg3TqjaXfgWDEyVKPZGIMSlfmyudUkdEzsW3WPdUPrC1/t9BpNWhRiKezZZE0LMEEDfbfiiZW/4gYeIv1GdXDyruWJoeUCjXlZRSiNUq/mE0HqXNPPFoszDk6CmNaO1nghoYUickwUPAt0UgianQyWBY4HW5mWXOfkwCD6qcFUBNMSY0UuR4lnreeQu2L0oy+ILd+1wEqSIkOokPnQCxH0NbI1hHMw8CeaxKiak/N3zVxOK0/fmyiKViH7h+Omawxn1OhUreePSUtOaCf9I8/kNq0jadYfEUur5+c7IvKoflx6qkibMeGtijtYM2wsvONB0CeWHdB5dDn//1vBngerBrXsQnewfbGVpmN/0I8QYtlGi+gvw5JuZr/56njtUy6CprOcSZWqR7+sB0ewtJMwOu2oTN8Bs443k/QQfgIVtNCRewZ9fEZpK5P8QxI2084aSims70ETPr5F0gIREM0fxjKYWSP+mBVqjVdSNTeoxYkZGdqktkUxTe58FQHUeEs1zrhQDsPMawDKOprFWUnO6U5VVcYdm88dAA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB5452.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(26005)(186003)(71200400001)(5660300002)(52536014)(38100700002)(7696005)(6506007)(86362001)(9686003)(83380400001)(316002)(38070700005)(508600001)(122000001)(110136005)(8936002)(4326008)(8676002)(66946007)(2906002)(66556008)(66446008)(66476007)(64756008)(76116006)(55016003)(33656002)(20210929001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ieTOLwyaydzNNpORA65kK8MSuRnE25LkprtcRRVeq1sMNocEd/ffw7H4vnnd?= =?us-ascii?Q?jn3k7kEinzPB3AstChNmMyKgTqrAUqAMvUEj/UuIe174NjmI5t6bfhWll2Od?= =?us-ascii?Q?TL/tytz9xIG75ok3dr9F7nnJnuoeAOnWmZSpTTQf4+hF9sPpT6d2fkBgX1Uc?= =?us-ascii?Q?eImgPYgH1CgiBM3spbc8EfgTks9nuLT76rftRPBPB7yxW9R8Hjj2H4bpG25V?= =?us-ascii?Q?xfLHniq3cx46j+GjQVH/CbH7hdt8/lx175evD4KWrYZDWbjR18Cxs5FOfdk9?= =?us-ascii?Q?e6H/0XZx9mEAtfAiYsHZzO8IO5gX4Ga1Ij0yA7x49wuoRIvz5Fq+G82LhvxV?= =?us-ascii?Q?VBv1/0c6NErwr382PcGNEsNYqB2INcCoVMjZPz0ANDe45sdoeg5vHARNgh9c?= =?us-ascii?Q?yByLcZqKqrpatyPgmK3jAIUHXzw2+XaJ7u3ijVDwXpZYio0U7xwXbNuD3Kt7?= =?us-ascii?Q?oBEQ9QSWoHZS/tnmO+yZ6+Rls66QX01D/Co+UmFvaPO0r4XGb3UpYkF9DYFV?= =?us-ascii?Q?pPZ4p8rG1SfslcTz44m/Sf4PoI3FfIzIxyZfBiYIoZKrV71BigN5Q7Uop5R7?= =?us-ascii?Q?CPRFIOpqL/FH8UhSNk2Z5NY2VuGG7kKCC7g/8Ysh8K0VvW/+ZCJAriKlE5Rl?= =?us-ascii?Q?yRXlM+0sWRkpuk9R0CNbwznb0G3GxwRXizGdD9ExI2uA/9rhT/9H+0QPsCnl?= =?us-ascii?Q?69e7/oyFiQFbAQiVu2uRPfmWVq/Le4rtClsPonhO8exiKD2ljBrMGwpY7YD6?= =?us-ascii?Q?hKr2B+2ZB7Zo/w8OJD7vXTcG0Bx7gNLfwsCUce0bQ+y1dbuGEE8gLMfi5YzM?= =?us-ascii?Q?HsYbUaPZsKnM0qCzKyVsaBdr0Mx11eFk2BMni9gunanRT3x8M8wi0PV7EV0R?= =?us-ascii?Q?Mt/zXMDs224Grtkoq3aZ9gm+0HjUgHE3uT8cLY3J81gkn3CetcetnYiJSK5W?= =?us-ascii?Q?dZpzQeMEV+NSXfgzKoul7thsHftaBWSoIWsLIQU+kdJWByJSBpwblugAtza8?= =?us-ascii?Q?OGIA7qEfy18qBAp11CrokIsyxG+u6DEpyhaH0oLRDZcbTQbt9dN2gcwQ81er?= =?us-ascii?Q?EZ33mFPAuOe+SR+PqzWjbk2lF7067zy/XGGFmYZLR8SMzOqzA0vSNajQkIrG?= =?us-ascii?Q?Uypb1hjvTDAvSyy/iKGkTBqtpSTyyLr8l4CGBKq7kzN17Htd2thLbemWDhT1?= =?us-ascii?Q?ClsnElgshQsKp0oEvg95fAy00lXgPaVjLvpYJh631TZUVn4u393PxKLsdwZ0?= =?us-ascii?Q?0WI5Ws4zT1pkenQgbTK/w0SlYEGxiMposUrLshxOjpG/Bxgq0oEVDu8La+18?= =?us-ascii?Q?eiC0/Qp25OKNgmdhFpXNdj73dlFVV0rH5nlElcgAVjfVD/C0qNk4YPtOBzjA?= =?us-ascii?Q?BdJyf2MOqZ7oFoxQnWGynQZiDid5sY6Tym7M3UWjNCRJDXE/nL+UoZJY4OwA?= =?us-ascii?Q?DnKddoNTMmPpPWpAQzO2wdrPnaZ+tA/XuEcp0vjc779Iflr9+8xGZMAp+Amd?= =?us-ascii?Q?46aleB3RFtCs+4M/LNnzbo8b/EI3YnQUop9Hy/5lEziwu+NEU+EYfrUf7JMh?= =?us-ascii?Q?f73nIo87YIhGo7ceAztalUGatYNvdzt2UJAdhxyIqqBNfAhs7glCqYnfeem8?= =?us-ascii?Q?Nw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b78f283-4df1-4da6-10cc-08d9e4c4b814 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2022 14:19:40.1275 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EPozfpy+11npLHs1HwH0c6pDn1Fkq9VUVNBa2s1WVTwu/uFVS/FAlGD8ihcbwcob6gdt9civFtwykesyb7zyag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4406 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 14:19:45 -0000 [AMD Official Use Only] Hi, > > else if (thisfun !=3D NULL) > > { > > + if (is_nocall_function (check_typedef (value_type (function)))) > > + query_prefix > > + =3D string_printf ("The function '%s' does not follow the t= arget " > > + "calling convention.\n" > > + "If you continue, setting the return value= " > > + "will probably lead to unpredictable " > > + "behaviors.\n", > > + thisfun->print_name ()); > > + > > I feel like this if statement could have a set of { } around it. The assi= gnment and call are big enough to be confusing on a quick glance Will do. > > + > > +int > > +foo () > > +{ > > + asm ("foo_label: .globl foo_label"); > > + return 42; > > +} > > According to the testsuite coding standards, this should be foo (void), i= nstead of foo () OK > > +if ![runto_main] { > > + return -1 > > +} > > Following Keith Seitz's request to be more pedantic about TCL formatting,= I think this should be >=20 > if {![runto_main]} { Will change that as well. Thanks for pointing this out. Thanks for the feedbacks. Best, Lancelot. > Like I said, I can't approve for pushing, but LGTM. > > -- > Cheers! > Bruno Larsen