From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18779 invoked by alias); 2 Jul 2010 17:03:40 -0000 Received: (qmail 18634 invoked by uid 22791); 2 Jul 2010 17:03:39 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from az33egw02.freescale.net (HELO az33egw02.freescale.net) (192.88.158.103) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Jul 2010 17:03:32 +0000 Received: from de01smr01.freescale.net (de01smr01.freescale.net [10.208.0.31]) by az33egw02.freescale.net (8.14.3/az33egw02) with ESMTP id o62H3KOb015297; Fri, 2 Jul 2010 10:03:20 -0700 (MST) Received: from lds03-tx32 (lds03-tx32.am.freescale.net [10.83.20.63]) by de01smr01.freescale.net (8.13.1/8.13.0) with ESMTP id o62HF1dV022685; Fri, 2 Jul 2010 12:15:01 -0500 (CDT) Date: Fri, 02 Jul 2010 17:03:00 -0000 From: "Anmol P. Paralkar" To: Eli Zaretskii cc: gdb-patches@sourceware.org Subject: Re: Fix "maint time" command documentation. In-Reply-To: <83d3v69p2j.fsf@gnu.org> Message-ID: References: <83d3v69p2j.fsf@gnu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00045.txt.bz2 On Fri, 2 Jul 2010, Eli Zaretskii wrote: >> Date: Thu, 1 Jul 2010 18:20:49 -0500 (CDT) >> From: "Anmol P. Paralkar" >> >> The documentation for the "maint time" command does not mention the units of time. >> Also, there are a couple of typos in there. I have attempted to fix these in the >> following patch; please let me know if we could word/punctuate this better and >> I'll be happy to re-spin. > > Thanks. I have a few suggestions for a better change: > >> Control whether to display the execution time for each command. If >> set to a nonzero value, @value{GDBN} will display how much time it >> ! took (in seconds) to execute each command, following the command's own output. > > It would be better to place the units right after "time": > > Control whether to display the execution time for each command. > If set to a nonzero value, @value{GDBN} will display how much time > (in seconds) it took to execute each command, following the > command's own output. > >> ! The time is not printed for the commands that run on the target, since >> there's no mechanism currently to compute how much time was spend > ^^^^^ > "spent" > >> ! by @value{GDBN} and how much time was spend by the program been debugged; > ^^^^^ ^^^^ > "spent" and "being" > >> ! this is not possible currently. > > I think this part is not needed. The sentence already says that > "there's no mechanism currently" to do this, so this addition simply > reiterates the same thing. > > Thanks. Hello Eli, Thank you for your suggestions; please see the new version with them, below. Regards, Anmol. Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/doc/ChangeLog,v retrieving revision 1.1083 diff -c -p -r1.1083 ChangeLog *** ChangeLog 1 Jul 2010 17:40:04 -0000 1.1083 --- ChangeLog 2 Jul 2010 16:54:42 -0000 *************** *** 1,3 **** --- 1,8 ---- + 2010-07-02 Anmol P. Paralkar + + * gdb.texinfo (Maintenance Commands): Mention units of time + and fix typos in documentation for command "maint time". + 2010-07-01 Pedro Alves * gdb.texinfo (Create and Delete Tracepoints): Add more index Index: gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.737 diff -c -p -r1.737 gdb.texinfo *** gdb.texinfo 1 Jul 2010 17:40:04 -0000 1.737 --- gdb.texinfo 2 Jul 2010 16:54:44 -0000 *************** switch (@pxref{Mode Options}). *** 30571,30585 **** @kindex maint time @cindex time of command execution @item maint time ! Control whether to display the execution time for each command. If ! set to a nonzero value, @value{GDBN} will display how much time it ! took to execute each command, following the command's own output. ! The time is not printed for the commands that run the target, since ! there's no mechanism currently to compute how much time was spend ! by @value{GDBN} and how much time was spend by the program been debugged. ! it's not possibly currently ! This can also be requested by invoking @value{GDBN} with the ! @option{--statistics} command-line switch (@pxref{Mode Options}). @kindex maint translate-address @item maint translate-address @r{[}@var{section}@r{]} @var{addr} --- 30571,30584 ---- @kindex maint time @cindex time of command execution @item maint time ! Control whether to display the execution time for each command. ! If set to a nonzero value, @value{GDBN} will display how much time ! (in seconds) it took to execute each command, following the command's ! own output. The time is not printed for the commands that run on the ! target, since there's no mechanism currently to compute how much time ! was spent by @value{GDBN} and how much time was spent by the program ! being debugged. This can also be requested by invoking @value{GDBN} ! with the @option{--statistics} command-line switch (@pxref{Mode Options}). @kindex maint translate-address @item maint translate-address @r{[}@var{section}@r{]} @var{addr}