RE: [PATCH v4 1/3] gdb/testsuite: Fix indentation issues in gdb.dwarf2/dynarr-ptr.exp

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Hi Tom,

Thanks for the feedback.

Abdul>      return -1
Abdul>  }
 
Tom > This hunk doesn't look correct.
Second line is used differently in existing testsuite (e.g. with 4 spaces or tab + 2 spaces or more etc).  I have used "4 spaces" in this patch for the splitted line. Will replace it with "Tab + 2 spaces" in V5 patch, hope it would be fine.

Best Regards,
Abdul Basit

-----Original Message-----
From: Tom Tromey <tom@tromey.com> 
Sent: Thursday, January 11, 2024 6:47 PM
To: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Cc: gdb-patches@sourceware.org; thiago.bauermann@linaro.org; tom@tromey.com; simark@simark.ca
Subject: Re: [PATCH v4 1/3] gdb/testsuite: Fix indentation issues in gdb.dwarf2/dynarr-ptr.exp

>>>>> "Abdul" == Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:

Abdul> From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
Abdul> ---
Abdul>  gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp | 138 
Abdul> ++++++++++++------------
Abdul>  1 file changed, 69 insertions(+), 69 deletions(-)

Abdul> diff --git a/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp 
Abdul> b/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp
Abdul> index 6e4a331eca8..26c64278103 100644
Abdul> --- a/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp
Abdul> +++ b/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp
Abdul> @@ -120,7 +120,7 @@ Dwarf::assemble $asm_file {  # the compiler.
 
Abdul>  if { [prepare_for_testing "failed to prepare" ${testfile} \
Abdul> -	  [list $srcfile $asm_file] {nodebug}] } {
Abdul> +    [list $srcfile $asm_file] {nodebug}] } {
Abdul>      return -1
Abdul>  }
 
This hunk doesn't look correct.

The rest is ok though.

Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928