From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "blarsen@redhat.com" <blarsen@redhat.com>,
"pedro@palves.net" <pedro@palves.net>,
"philippe.waroquiers@skynet.be" <philippe.waroquiers@skynet.be>,
"aburgess@redhat.com" <aburgess@redhat.com>,
"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
"Schimpe, Christina" <christina.schimpe@intel.com>,
"lsix@lancelotsix.com" <lsix@lancelotsix.com>
Subject: RE: [PING][PATCH v6 0/2] add annotation in 'info locals' command for variables shadowing case
Date: Thu, 28 Dec 2023 11:28:33 +0000 [thread overview]
Message-ID: <SA1PR11MB6846746E8D4E894EB7B1769DCB9EA@SA1PR11MB6846.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231122081301.5997-1-abdul.b.ijaz@intel.com>
Ping!
Note: Documentation part is already approved.
Best Regards
Abdul Basit
-----Original Message-----
From: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Sent: Wednesday, November 22, 2023 9:13 AM
To: gdb-patches@sourceware.org
Cc: blarsen@redhat.com; pedro@palves.net; philippe.waroquiers@skynet.be; aburgess@redhat.com; Aktemur, Tankut Baris <tankut.baris.aktemur@intel.com>; Schimpe, Christina <christina.schimpe@intel.com>; lsix@lancelotsix.com; eliz@gnu.org; Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Subject: [PATCH v6 0/2] add annotation in 'info locals' command for variables shadowing case
From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
Hi All,
For the variable shadowing case, these patches add the annotation "shadowed" and location information to the shadowed variables so that it is easier for the end user to identify which variable was shadowed.
V5 series:
https://sourceware.org/pipermail/gdb-patches/2023-November/204330.html
V4 series:
https://sourceware.org/pipermail/gdb-patches/2023-September/202637.html
V3 series:
https://sourceware.org/pipermail/gdb-patches/2023-September/202574.html
V2 series:
https://sourceware.org/pipermail/gdb-patches/2021-December/184675.html
Feedback for V2 series:
https://sourceware.org/pipermail/gdb-patches/2022-January/184822.html
https://sourceware.org/pipermail/gdb-patches/2022-January/184819.html
V1 series:
https://sourceware.org/pipermail/gdb-patches/2021-July/181174.html
Patch#1 updates "info locals" command and Path #2 is for the mi commands '-stack-list-locals' and '-stack-list-variables'.
Changes since V5:
* As per Eli feedback, update text by adding shadowed variable definition
and also did rewording in gdb.textinfo for both patches.
* Update commit message for patch#1 to mention why xfail is added.
Thanks & Best Rergards
Abdul Basit
Ijaz, Abdul B (2):
gdb: add annotation in 'info locals' command for variables shadowing
case
gdb: add shadowed field in '-stack-list-locals/variables' mi commands
gdb/doc/gdb.texinfo | 29 ++++
gdb/mi/mi-cmd-stack.c | 66 +++++++-
gdb/printcmd.c | 11 +-
gdb/stack.c | 64 +++++++-
gdb/stack.h | 3 +-
gdb/testsuite/gdb.ada/var_shadowing.exp | 38 +++++
.../gdb.ada/var_shadowing/var_shadowing.adb | 30 ++++
gdb/testsuite/gdb.base/var-shadowing.c | 49 ++++++
gdb/testsuite/gdb.base/var-shadowing.exp | 90 +++++++++++
gdb/testsuite/gdb.base/var-shadowing2.c | 16 ++
gdb/testsuite/gdb.mi/mi-var-shadowing.c | 48 ++++++
gdb/testsuite/gdb.mi/mi-var-shadowing.exp | 141 ++++++++++++++++++
gdb/testsuite/gdb.rust/var_reuse.exp | 34 +++++
gdb/testsuite/gdb.rust/var_reuse.rs | 20 +++
gdb/tracepoint.c | 3 +-
gdb/value.h | 4 +-
16 files changed, 631 insertions(+), 15 deletions(-) create mode 100644 gdb/testsuite/gdb.ada/var_shadowing.exp
create mode 100644 gdb/testsuite/gdb.ada/var_shadowing/var_shadowing.adb
create mode 100755 gdb/testsuite/gdb.base/var-shadowing.c
create mode 100755 gdb/testsuite/gdb.base/var-shadowing.exp
create mode 100644 gdb/testsuite/gdb.base/var-shadowing2.c
create mode 100644 gdb/testsuite/gdb.mi/mi-var-shadowing.c
create mode 100644 gdb/testsuite/gdb.mi/mi-var-shadowing.exp
create mode 100755 gdb/testsuite/gdb.rust/var_reuse.exp
create mode 100755 gdb/testsuite/gdb.rust/var_reuse.rs
--
2.34.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2023-12-28 11:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 8:12 [PATCH " Abdul Basit Ijaz
2023-11-22 8:13 ` [PATCH v6 1/2] gdb: " Abdul Basit Ijaz
2023-11-22 14:37 ` Eli Zaretskii
2024-01-16 15:40 ` Guinevere Larsen
2023-11-22 8:13 ` [PATCH v6 2/2] gdb: add shadowed field in '-stack-list-locals/variables' mi commands Abdul Basit Ijaz
2023-11-22 14:38 ` Eli Zaretskii
2024-01-16 15:41 ` Guinevere Larsen
2023-12-28 11:28 ` Ijaz, Abdul B [this message]
2024-01-15 12:29 ` [PING 2][PATCH v6 0/2] add annotation in 'info locals' command for variables shadowing case Ijaz, Abdul B
2024-03-04 18:10 ` [PING 3][PATCH " Ijaz, Abdul B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB6846746E8D4E894EB7B1769DCB9EA@SA1PR11MB6846.namprd11.prod.outlook.com \
--to=abdul.b.ijaz@intel.com \
--cc=aburgess@redhat.com \
--cc=blarsen@redhat.com \
--cc=christina.schimpe@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=pedro@palves.net \
--cc=philippe.waroquiers@skynet.be \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).