RE: [PATCH v3 2/4] gdb, types: Resolve pointer types dynamically

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Hi Tom,

Thanks a lot for the feedback.

>> -  /* We only want to recognize references at the outermost level.  */
>> -  if (top_level && type->code () == TYPE_CODE_REF)
>> +  /* We only want to recognize references and pointers at the outermost
>> +     level.  */
>> +  if (top_level
>> +      && (type->code () == TYPE_CODE_REF || type->code () == 
>> + TYPE_CODE_PTR))

Tom > Pre-existing but I wonder why this code checks TYPE_CODE_REF and not TYPE_CODE_RVALUE_REF.

Here we are checking for LVALUE or Pointers dynamic value and for them need to resolve the target memory to resolve pointer/memory at outmost level.  So as far as I understood checking for rvalue here would not be needed.  In case you have some case to try then please let me know I can give it a try.

>> -  if (type_not_associated (val->type ()))
>> -    {
>> -      val_print_not_associated (stream);
>> -      return 0;
>> -    }

Tom > I don't really know anything about Fortran, so I don't know why this code was here in the first place, nor what its removal might mean.

This was originally added at time to support DW_AT_Associated/Allocated DIEs for Fortran dynamic arrays but this is a redundant code so no need to keep it. Also in existing testsuite there is no affect with or without it.  Will mention in the commit message in V4 series.

Best Regards,
Abdul Basit

-----Original Message-----
From: Tom Tromey <tom@tromey.com> 
Sent: Tuesday, October 10, 2023 9:50 PM
To: Abdul Basit Ijaz via Gdb-patches <gdb-patches@sourceware.org>
Cc: Ijaz, Abdul B <abdul.b.ijaz@intel.com>; simark@simark.ca; tom@tromey.com
Subject: Re: [PATCH v3 2/4] gdb, types: Resolve pointer types dynamically

>>>>> Abdul Basit Ijaz via Gdb-patches <gdb-patches@sourceware.org> writes:

> -  /* We only want to recognize references at the outermost level.  */
> -  if (top_level && type->code () == TYPE_CODE_REF)
> +  /* We only want to recognize references and pointers at the outermost
> +     level.  */
> +  if (top_level
> +      && (type->code () == TYPE_CODE_REF || type->code () == 
> + TYPE_CODE_PTR))

Pre-existing but I wonder why this code checks TYPE_CODE_REF and not TYPE_CODE_RVALUE_REF.

> diff --git a/gdb/valprint.c b/gdb/valprint.c index 
> b65dda15c04..c71ae089f46 100644
> --- a/gdb/valprint.c
> +++ b/gdb/valprint.c
> @@ -1156,12 +1156,6 @@ value_check_printable (struct value *val, struct ui_file *stream,
>        return 0;
>      }
 
> -  if (type_not_associated (val->type ()))
> -    {
> -      val_print_not_associated (stream);
> -      return 0;
> -    }

I don't really know anything about Fortran, so I don't know why this code was here in the first place, nor what its removal might mean.
Could you say why this is being removed?

Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928