RE: [PATCH v2 1/1] gdb, testsuite: Handle unused compiler option fdiagnostics-color=never.

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Hi Tom,

Thanks for the feedback.

>> +	if {[string match *.s $source] != 0} {
>> +	    set new_options [universal_compile_options_assembly]

> Should this also check for *.S files?  If so it needs a change, and if not it should probably have a comment explaining why not.

Icx/icpx/ifx/clang compilers does not support this compile option only for ".s" files while .S files does not have this issue. Sure I will add the comment here.

Best Regards
Abdul Basit

-----Original Message-----
From: Tom Tromey <tom@tromey.com> 
Sent: Wednesday, May 15, 2024 6:18 PM
To: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Cc: gdb-patches@sourceware.org; Schimpe, Christina <christina.schimpe@intel.com>; Willgerodt, Felix <felix.willgerodt@intel.com>; keiths@redhat.com
Subject: Re: [PATCH v2 1/1] gdb, testsuite: Handle unused compiler option fdiagnostics-color=never.

>>>>> Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:

> The 'univeral_compile_options' in gdb.exp file only verifies the 
> support of '-fdiagnostics-color=never' for the "C" source file.  So 
> while running tests with assembly source file (.s), many of them are 
> not able to run on icx/clang compilers because 
> '-fdiagnostics-color=never' option is not supported.  After this 
> change, this function is split into multiple functions to check the support for different type of sources individually.

Thanks for the patch.

> -	set new_options [universal_compile_options]
> +	if {[string match *.s $source] != 0} {
> +	    set new_options [universal_compile_options_assembly]
> +	} else {
> +	    set new_options [universal_compile_options_c]

Should this also check for *.S files?  If so it needs a change, and if not it should probably have a comment explaining why not.

Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928