public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Stephanos Ioannidis <root@stephanos.io>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] Assume "unknown" terminal type by default
Date: Tue, 2 Jun 2020 16:15:03 +0000	[thread overview]
Message-ID: <SLXP216MB0285D4DE5ECFA46AC4C8E18ABD8B0@SLXP216MB0285.KORP216.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <835zc9eblh.fsf@gnu.org>

> Isn't this something that ncurses itself should do on MS-Windows?

ncurses assumes the "#win32con" terminal type (required for proper terminal 
operation on the Windows console) when the tgetent is called with 
termtype=NULL or termtype="unknown".

In this case, _rl_init_terminal_io is passing termtype="dumb" to tgetent when 
the TERM environment variable is not defined, so ncurses is resolving the 
"dumb" terminal type instead of required "#win32con".

This effectively causes some keys (e.g. backspace and arrow keys) to not work 
in the gdb command line, and this patch ensures that the problem is fixed.

p.s. I apologise for the horrible line formatting in the previous messages; I
 am sending these from a home machine and the mail client settings are all
 messed up.

  reply	other threads:[~2020-06-02 16:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02  3:52 Stephanos Ioannidis
2020-06-02 15:22 ` Eli Zaretskii
2020-06-02 16:15   ` Stephanos Ioannidis [this message]
     [not found]   ` <SLXP216MB0285D95A8DA9B4C0AB87C6D8BD8B0@SLXP216MB0285.KORP216.PROD.OUTLOOK.COM>
2020-06-02 16:18     ` Eli Zaretskii
2020-06-15 14:07 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SLXP216MB0285D4DE5ECFA46AC4C8E18ABD8B0@SLXP216MB0285.KORP216.PROD.OUTLOOK.COM \
    --to=root@stephanos.io \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).