From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Pedro Alves <pedro@palves.net>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "simark@simark.ca" <simark@simark.ca>
Subject: RE: [PATCH 0/3] Prevent bad conditions from putting breakpoints into broken state
Date: Thu, 23 Jul 2020 07:13:13 +0000 [thread overview]
Message-ID: <SN6PR11MB2893D5090695C96B52E1D1BAC4760@SN6PR11MB2893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <58ba7b97-03e9-4886-d502-0a5e4f82e501@palves.net>
On Wednesday, July 22, 2020 8:24 PM, Pedro Alves wrote:
> On 7/21/20 10:08 AM, Tankut Baris Aktemur via Gdb-patches wrote:
> >> Hi,
> >>
> >> If the condition of a breakpoint is "bad" (e.g. has unresolved
> >> symbols, syntax errors, etc.), the breakpoint goes into a broken state
> >> where the condition string or the condition expressions are updated
> >> inadvertently. This small series attempts to fix that.
> >
> >
> > Kindly pinging for
> >
> > https://sourceware.org/pipermail/gdb-patches/2020-June/169954.html
>
> I'm confused -- are you proposing to merge patch #2 as it was,
> or with the two passes?
Sorry for the confusion. Please consider the two-pass version.
Thanks
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2020-07-23 7:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 13:48 Tankut Baris Aktemur
2020-06-29 13:48 ` [PATCH 1/3] gdb/breakpoint: do not update the condition string if parsing the condition fails Tankut Baris Aktemur
2020-07-22 13:12 ` Simon Marchi
2020-07-22 13:15 ` Simon Marchi
2020-06-29 13:48 ` [PATCH 2/3] gdb/breakpoint: set the condition exp after parsing the condition successfully Tankut Baris Aktemur
2020-07-22 13:21 ` Simon Marchi
2020-07-22 13:28 ` Simon Marchi
2020-07-22 15:29 ` Aktemur, Tankut Baris
2020-07-22 16:06 ` Simon Marchi
2020-07-23 7:11 ` Aktemur, Tankut Baris
2020-07-30 10:56 ` Aktemur, Tankut Baris
2020-07-30 15:15 ` Simon Marchi
2020-06-29 13:48 ` [PATCH 3/3] gdb/breakpoint: refactor 'set_breakpoint_condition' Tankut Baris Aktemur
2020-07-13 8:45 ` [PATCH 0/3] Prevent bad conditions from putting breakpoints into broken state Tankut Baris Aktemur
2020-07-21 9:08 ` Tankut Baris Aktemur
2020-07-22 18:24 ` Pedro Alves
2020-07-23 7:13 ` Aktemur, Tankut Baris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB2893D5090695C96B52E1D1BAC4760@SN6PR11MB2893.namprd11.prod.outlook.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).