From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Pedro Alves <pedro@palves.net>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] target_is_non_stop_p and sync targets
Date: Tue, 16 Mar 2021 14:29:12 +0000 [thread overview]
Message-ID: <SN6PR11MB2893EA7429095774FB5F1A6BC46B9@SN6PR11MB2893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210316132643.691299-1-pedro@palves.net>
On Tuesday, March 16, 2021 2:27 PM, Pedro Alves Wrote:
> gdb.base/maint-target-async-off.exp fails if you test against
> gdbserver with "maint set target-non-stop on" forced.
>
> (gdb) run
> Starting program: build/gdb/testsuite/outputs/gdb.base/maint-target-async-off/maint-
> target-async-off
>
> Breakpoint 1, main () at src/gdb/testsuite/gdb.base/maint-target-async-off.c:21
> 21 return 0;
> (gdb) FAIL: gdb.base/maint-target-async-off.exp: continue until exit (timeout)
>
> Above, GDB just stopped listing to stdin.
>
> Basically, GDB assumes that a target working in non-stop mode
> operation also supports async mode; it's a requirement. GDB
> misbehaves badly otherwise, and even hits failed assertions.
>
> Fix this my making target_is_non_stop_p return false if async is off.
"my" -> "by".
Thanks
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2021-03-16 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 13:26 Pedro Alves
2021-03-16 14:29 ` Aktemur, Tankut Baris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB2893EA7429095774FB5F1A6BC46B9@SN6PR11MB2893.namprd11.prod.outlook.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).