RE: [PATCH v8 6/6] gdb/infrun: handle already-exited threads when attempting to stop

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Thursday, May 14, 2020 8:59 PM, Pedro Alves wrote:
> On 5/14/20 7:54 PM, Aktemur, Tankut Baris wrote:
> > On Thursday, May 14, 2020 8:00 PM, Tom de Vries wrote:
> >> On 13-05-2020 22:53, Pedro Alves via Gdb-patches wrote:
> >>> +	set testpid($num) [get_integer_valueof "pid" -1]
> >>
> >> I'm running into:
> >> ...
> >> ERROR: tcl error sourcing
> >> /data/gdb_versions/devel/src/gdb/testsuite/gdb.multi/multi-kill.exp.
> >> ERROR: can't set "testpid(1)": variable isn't array
> >>     while executing
> >> "set testpid($num) [get_integer_valueof "pid" -1]"
> >
> > I'm not able to reproduce this problem.  The test runs fine on my system
> > with 58 expected passes and no failures.  Could it be related to the tcl
> > version?
> 
> It's related to testcase run order, and the fact that global variables
> can leak between testcases.
> 
> >
> > As a rough guess, could you try the patch below to initialize the array
> > variable?
> >
> > diff --git a/gdb/testsuite/gdb.multi/multi-kill.exp b/gdb/testsuite/gdb.multi/multi-kill.exp
> > index ce6075045fc..a21f8a78b0d 100644
> > --- a/gdb/testsuite/gdb.multi/multi-kill.exp
> > +++ b/gdb/testsuite/gdb.multi/multi-kill.exp
> > @@ -70,6 +70,7 @@ proc start_inferior {num} {
> >  # Sufficient inferiors to make sure that at least some other inferior
> >  # is killed while we're handling a killed event.
> >  set NUM_INFS 10
> > +array set testpid {}
> 
> That's not sufficient, because the variable can leak to other tests.
> For example:
> 
>  $ runtest gdb.threads/check-libthread-db.exp gdb.multi/multi-kill.exp
> 
>  Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.multi/multi-kill.exp ...
>  Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.threads/check-libthread-db.exp ...
>  ERROR: tcl error sourcing /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.threads/check-libthread-db.exp.
>  ERROR: can't set "testpid": variable is array
>      while executing
>  "set testpid [spawn_id_get_pid $test_spawn_id]"
>      ("uplevel" body line 8)
> 
> This works for me.
> 
> From 96aa00638e9a1201874e316ad53c38614da8cc04 Mon Sep 17 00:00:00 2001
> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 14 May 2020 19:07:35 +0100
> Subject: [PATCH] Fix global variable collision in gdb.multi/multi-kill.exp
> 
> gdb/testsuite/ChangeLog:
> 2020-05-14  Pedro Alves  <palves@redhat.com>
> 
> 	* gdb.multi/multi-kill.exp: Wrap in namespace.
> 	(start_inferior): Add TESTPID parameter.  Use it instead of the
> 	testpid global.
> 	(top level): Define empty TESTPID array, and pass it down to
> 	start_inferior.
> ---
>  gdb/testsuite/gdb.multi/multi-kill.exp | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.multi/multi-kill.exp b/gdb/testsuite/gdb.multi/multi-kill.exp
> index ce6075045fc..03bf8449cf8 100644
> --- a/gdb/testsuite/gdb.multi/multi-kill.exp
> +++ b/gdb/testsuite/gdb.multi/multi-kill.exp
> @@ -39,11 +39,15 @@ save_vars { GDBFLAGS } {
>      clean_restart ${binfile}
>  }
> 
> +# Wrap the entire test in a namespace to avoid contaminating other tests.
> +namespace eval $testfile {

TIL.  Thanks.

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928