RE: [PATCH v7 2/2] gdb, breakpoint: output multiple bp locations

["Gerlicher, Klaus" <klaus.gerlicher@intel.com>]

Thanks Eli. Replies inline. I'll wait until I get some feedback from others and will roll fixes into a V8.

Klaus

> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Tuesday, October 29, 2024 2:10 PM
> To: Gerlicher, Klaus <klaus.gerlicher@intel.com>
> Cc: gdb-patches@sourceware.org; aburgess@redhat.com;
> blarsen@redhat.com
> Subject: Re: [PATCH v7 2/2] gdb, breakpoint: output multiple bp locations
> 
> > From: Klaus Gerlicher <klaus.gerlicher@intel.com>
> > Date: Tue, 29 Oct 2024 11:33:43 +0000
> >
> >  gdb/NEWS                                      |   4 +
> >  gdb/breakpoint.c                              | 135 ++++++++++++++----
> >  gdb/doc/gdb.texinfo                           |  45 +++++-
> >  gdb/testsuite/gdb.base/ctxobj.exp             |   4 +-
> >  .../run-control-while-bg-execution.exp        |   2 +-
> >  gdb/testsuite/gdb.cp/ovldbreak.exp            |   6 +-
> >  gdb/testsuite/gdb.linespec/cpcompletion.exp   |   2 +
> >  gdb/testsuite/gdb.linespec/linespec.exp       |   2 +-
> >  gdb/testsuite/gdb.linespec/multiple-locs.cc   |  41 ++++++
> >  gdb/testsuite/gdb.linespec/multiple-locs.exp  |  57 ++++++++
> >  .../mi-breakpoint-multiple-locations.exp      |   4 +-
> >  .../gdb.mi/user-selected-context-sync.exp     |  16 +--
> >  .../gdb.multi/inferior-specific-bp.exp        |   2 +-
> >  .../gdb.multi/multi-target-continue.exp       |   3 +-
> >  .../gdb.multi/multi-target-ping-pong-next.exp |   6 +-
> >  gdb/testsuite/gdb.python/py-breakpoint.exp    |   3 +-
> >  gdb/testsuite/lib/completion-support.exp      |   3 +
> >  gdb/testsuite/lib/gdb.exp                     |  34 ++++-
> >  18 files changed, 308 insertions(+), 61 deletions(-)
> >  create mode 100644 gdb/testsuite/gdb.linespec/multiple-locs.cc
> >  create mode 100644 gdb/testsuite/gdb.linespec/multiple-locs.exp
> 
> Thanks.
> 
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -3,6 +3,10 @@
> >
> >  *** Changes since GDB 15
> >
> > +* Printing multiple breakpoint locations when setting a breakpoint that is
> > +  instantiated for multiple locations now prints all locations limited by
> > +  "set breakpoint max-breakpoint-location-printed <count>".
> > +
> >  * Debugging support for Intel MPX has been removed.  This includes the
> >    removal of
> >    ** MPX register support
> 
> This part is OK.
> 


Thank you.

> > +  add_setshow_uinteger_cmd ("max-breakpoint-locations-printed",
> > +			    class_breakpoint,
> > +			    &breakpoint_show_max_locations, _("\
> > +Set number of locations printed when setting a breakpoint."), _("\
> > +Show number of locations printed when setting a breakpoint."), _("\
> > +Use this to choose how many number of locations are printed\n\
>                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Either "how many locations" or "the number of locations".
> 

I think I had looked at similar commands and tried to copy something verbatim 
and I failed miserably. Thanks for catching this.

> > +@kindex show breakpoint max-breakpoint-locations-printed
> > +@item show breakpoint max-breakpoint-locations-printed
> > +Display the number of locations that @code{break} will print.  If the
> number
> > +of locations is greater than the limit, the additional number of locations
> > +will be listed.
>    ^^^^^^^^^^^^^^
> I guess "will not be listed"?
> 

What I meant to say is that there will be a line of output that tells the user
how many more locations apart from the listed one there are.

So maybe:

"If the number of locations is greater than the limit, the breakpoint command will 
add a line reporting the number of locations that were not listed due to the limit.

Or maybe you have a better way of phrasing this?

> The documentation is OK with those nits fixed.
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928