Re: [PATCH] gdb: AC_INIT should be called with package and version arguments

[Enze Li <lienze2010@hotmail.com>]

Hi Joel,

Thanks for the review.

BTW, I'm not familiar with the release process.
Where can I find documentation on the release process?

Thanks in advance
Enze

On Sun, 2021-11-21 at 17:03 +0400, Joel Brobecker wrote:
> Hi Enze Li, hi Simon,
> 
> On Sun, Nov 14, 2021 at 09:52:00PM -0500, Simon Marchi wrote:
> > On 2021-11-13 23:09, Enze Li via Gdb-patches wrote:
> > > This patch adds package and version parameters to AC_INIT and
> > > regenerates the configure script.
> > 
> > Just wondering, is there practical reason to change this other than
> > to
> > "do things right"?  I'm not against it, I would just like to know the
> > motivation behind it.
> > 
> > > diff --git a/gdb/version.m4 b/gdb/version.m4
> > > new file mode 100644
> > > index 00000000000..2fa57f680ef
> > > --- /dev/null
> > > +++ b/gdb/version.m4
> > > @@ -0,0 +1 @@
> > > +m4_define([GDB_VERSION], [12.0.50])
> > > 
> > 
> > We already have the version number in gdb/version.in.  I don't know
> > if
> > we want to hardcode it at two places.  At least, this should be
> > coordinated with Joel, responsible for the release process including
> > bumping the version number.
> 
> Agreed. Can we have the configure script get the information from
> gdb/version.in?
>