From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn2144.outbound.protection.outlook.com [40.92.62.144]) by sourceware.org (Postfix) with ESMTPS id F17903858D28 for ; Tue, 23 Nov 2021 13:40:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F17903858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VzU6FqL5qgKmCaPfujpqUNLhbiP6bGquCU8a3CKPlUyZ+7XofDohk6r0/7TIVE2cdxXylxxXOWUTYJa4YNFw6XZ3ftnZXR8GGgLv9TMRMEoElJggEpCM+3oh1vdlQSXYgJ6ksrPUIuJXSzdHn6Jijdhp4Axp3HtkSTzoMU85BmhTPxzmGMNM88aVRjP6SFVn23yEMveShqesVCaEBqr1DpZilUONofKgv1OyETaUsLsao+9J8HCNxPuXUXakvr88YCnxJJjrDbOtbfy2y27eKG2KFSsXLnPKS+AxIgzhXM56HxyADTTRMVNnzxCEIi495xSUZkdcjMbJ7UYII5eVgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yEu6unPjHf0+5mzX4zfcpCiT5f9CWofjVt1VdSsjTDc=; b=CbhDsiz/NoeuJjyTzmEmuF0RxcPGQVzIlVXI7iAm0hiR/sqAxIguGDXHOcyJCUcPQV5E7R0/2xZLBmFTm7jqLFZZ0JcbtBcfLPXOD8ernUFAaOQDiJXWt01nAA0v3qfN+eSGF+PK5J1LDW9U+8q88FMinLcks/fuHXxijATrl1uX1q3pkvwbHWPlUvaq86YblhxDMbVxMGfxSnq98CueobtapWgn3TteJh1Yi2PuJ42WMgYWKvEDdOOBKPXZIY5Rkm/5DxZuOtWUBKpGIXr6eaS+qKxiT0Y/v5f6aIfZMs3bzC9ZQ9BOEpy6Kjb3uqvlIrr70HgUrNHkV9LDUEaiBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from SYBP282MB0300.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:6c::11) by SYBP282MB0043.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:60::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 13:40:16 +0000 Received: from SYBP282MB0300.AUSP282.PROD.OUTLOOK.COM ([fe80::b9aa:5a71:7a5f:6893]) by SYBP282MB0300.AUSP282.PROD.OUTLOOK.COM ([fe80::b9aa:5a71:7a5f:6893%4]) with mapi id 15.20.4713.026; Tue, 23 Nov 2021 13:40:15 +0000 Message-ID: Subject: Re: [PATCH] gdb: AC_INIT should be called with package and version arguments From: Enze Li To: Joel Brobecker Cc: gdb-patches@sourceware.org Date: Tue, 23 Nov 2021 21:40:11 +0800 In-Reply-To: References: <6b270217-7410-9ae2-cfeb-a05c158704c2@polymtl.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 Content-Transfer-Encoding: 8bit X-TMN: [IpcCC+Pn6r3GTd54eK5ZDy9yHvkaBiuW] X-ClientProxiedBy: HK2PR02CA0200.apcprd02.prod.outlook.com (2603:1096:201:20::12) To SYBP282MB0300.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:6c::11) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.3.105] (61.48.211.155) by HK2PR02CA0200.apcprd02.prod.outlook.com (2603:1096:201:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Tue, 23 Nov 2021 13:40:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d9d4457-e995-489e-6b0e-08d9ae86c837 X-MS-TrafficTypeDiagnostic: SYBP282MB0043: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vt36DDJdLLlDWVWe/hzTI9TgSjsIOMawWAm3WSz9PGxgF2GyQYs6a+ahkeXNGeEtkwmtCHDciJVLvcMH9oLp+xwHPdEpOnmrIG/Qio2mkTpPBE+JX+ZLgkmON8IVxHeaflRX5tWf1EIFpcqJZZWvuJ55yqc4GxVOXzecrOzW/YI1gI8qDVD6Z0KTVKeunWlw0gM1VyNh1Ybz21dr7vsuw5IsmlvUK1PNVamci+h+938AG0Sp8MwFIse+n9t2+qpPHoH6rrig4oMXD5rxROjXrMerXjzkFcIsjODNUqmETMj/t+1RzLWvvpX7gjw7vV/XHh8xv28RT8IVW2yDNhZ6wv4FB5dC5PP9dW2PhrR5AoMQi8ARlMIoYn6HQb7d9hS88evUZwNVNifXwP37hwF2N+2gXNBfppD7J+sFEGv7ask6ZgErHIXuTkIwzFK16PtwOpZ8sl6evx/iXH+5JcC2TwIMhIjSTWTYQtt8N7qhgSj1139N3o+1ZZGXyNvxShYqUvS3Y6mlnxlJRUjTX8RSUTUzpy2vlvO+2wJrGn0yCq3MjoQWfq5MyQODHpLRTCvIZlKIaCj2UGdVm6T7mbzkow== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qBMq+fVq+Ss5euwIbLAgOE/b/HLqaPWTTNUCmQTv8xeUOtsL2U3LUgbWLWkaKtKvlhsrP7p8D0DrUd2VtypW6MLuFHU5KiCFyPaqPj3eeVwmC+RTZOf0q2aZO1Suzc/k5DQ8z98IomETL2XwMUHAoAoZnXJj0D8+aIralE7M5KAmIBJHq/w9M6akibn/h0Fs0juBfLkaCHVWiTm5EoTI/XZHcHQ3gKYrM5+PMTRUvR8mre5YzALaV8Wuws0HoeCddry6nRbevWY34nDnJTQ2jOT7B8OQFzUp/q7sFV/QunRF6b3mJ99idRjSBhXERjHJPZRTpP6ZajDEh9PjxlmN912vaLaTCc/tbU28u+uexDszl7a2vzNwetriid1+0X7YpAUQeVjOZiQHL3I/8gT5X5GGnQp2JFpPzeSTlFaGrkuXXb2EMs3JWCjQEWCaWBU8mPrRdqdM7ThCvWN/Jv/y/amrybtZ1Ehp6CPyXSoBwUPQMdns9JpPm9KJOcfUaXmNg3dLKyyQ7P4co4j/hRIfLHbEY9udfYl6lXjdIIQ9ZpDKi9qGmJ/JlEDkF3IR08YB3kxVWxLNgQQdnVDcAXls3YQc1mgRAay6jxgXbqcqipKNCFjEeT0c8HUHcSibxOcbgeoyXbmF21rFvQ9/FaSceoLqYx6po/gyJDkgxvAJyVXRt30OFRstNln+bCiEfM5dLPNGLCeJ/2l6/OycPok8Tw== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-8dac2.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5d9d4457-e995-489e-6b0e-08d9ae86c837 X-MS-Exchange-CrossTenant-AuthSource: SYBP282MB0300.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 13:40:15.9530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYBP282MB0043 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 13:40:23 -0000 Hi Joel, Thanks for the review. BTW, I'm not familiar with the release process. Where can I find documentation on the release process? Thanks in advance Enze On Sun, 2021-11-21 at 17:03 +0400, Joel Brobecker wrote: > Hi Enze Li, hi Simon, > > On Sun, Nov 14, 2021 at 09:52:00PM -0500, Simon Marchi wrote: > > On 2021-11-13 23:09, Enze Li via Gdb-patches wrote: > > > This patch adds package and version parameters to AC_INIT and > > > regenerates the configure script. > > > > Just wondering, is there practical reason to change this other than > > to > > "do things right"?  I'm not against it, I would just like to know the > > motivation behind it. > > > > > diff --git a/gdb/version.m4 b/gdb/version.m4 > > > new file mode 100644 > > > index 00000000000..2fa57f680ef > > > --- /dev/null > > > +++ b/gdb/version.m4 > > > @@ -0,0 +1 @@ > > > +m4_define([GDB_VERSION], [12.0.50]) > > > > > > > We already have the version number in gdb/version.in.  I don't know > > if > > we want to hardcode it at two places.  At least, this should be > > coordinated with Joel, responsible for the release process including > > bumping the version number. > > Agreed. Can we have the configure script get the information from > gdb/version.in? >