From: TaiseiIto <taisei1212@outlook.jp>
To: gdb-patches@sourceware.org
Cc: tom@tromey.com, TaiseiIto <taisei1212@outlook.jp>
Subject: [PATCH] Fix null pointer representations
Date: Tue, 13 Sep 2022 22:55:03 +0900 [thread overview]
Message-ID: <TY0PR0101MB4285F5DA4C3E1366CCD2604DA4479@TY0PR0101MB4285.apcprd01.prod.exchangelabs.com> (raw)
Since "NULL" and "0" are used to represent invalid address in function
"gdbarch_find_by_info" in "binutils-gdb/gdb/arch-utils.c", I modified
them to "nullptr".
---
gdb/arch-utils.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c
index 9bd4f0ddae6..01111b69d6b 100644
--- a/gdb/arch-utils.c
+++ b/gdb/arch-utils.c
@@ -1326,13 +1326,13 @@ gdbarch_find_by_info (struct gdbarch_info info)
gdbarch_info_fill (&info);
/* Must have found some sort of architecture. */
- gdb_assert (info.bfd_arch_info != NULL);
+ gdb_assert (info.bfd_arch_info != nullptr);
if (gdbarch_debug)
{
gdb_printf (gdb_stdlog,
"gdbarch_find_by_info: info.bfd_arch_info %s\n",
- (info.bfd_arch_info != NULL
+ (info.bfd_arch_info != nullptr
? info.bfd_arch_info->printable_name
: "(null)"));
gdb_printf (gdb_stdlog,
@@ -1351,16 +1351,16 @@ gdbarch_find_by_info (struct gdbarch_info info)
/* Find the tdep code that knows about this architecture. */
for (rego = gdbarch_registry;
- rego != NULL;
+ rego != nullptr;
rego = rego->next)
if (rego->bfd_architecture == info.bfd_arch_info->arch)
break;
- if (rego == NULL)
+ if (rego == nullptr)
{
if (gdbarch_debug)
gdb_printf (gdb_stdlog, "gdbarch_find_by_info: "
"No matching architecture\n");
- return 0;
+ return nullptr;
}
/* Ask the tdep code for an architecture that matches "info". */
@@ -1368,12 +1368,12 @@ gdbarch_find_by_info (struct gdbarch_info info)
/* Did the tdep code like it? No. Reject the change and revert to
the old architecture. */
- if (new_gdbarch == NULL)
+ if (new_gdbarch == nullptr)
{
if (gdbarch_debug)
gdb_printf (gdb_stdlog, "gdbarch_find_by_info: "
"Target rejected architecture\n");
- return NULL;
+ return nullptr;
}
/* Is this a pre-existing architecture (as determined by already
@@ -1390,10 +1390,10 @@ gdbarch_find_by_info (struct gdbarch_info info)
new_gdbarch->bfd_arch_info->printable_name);
/* Find the existing arch in the list. */
for (list = ®o->arches;
- (*list) != NULL && (*list)->gdbarch != new_gdbarch;
+ (*list) != nullptr && (*list)->gdbarch != new_gdbarch;
list = &(*list)->next);
/* It had better be in the list of architectures. */
- gdb_assert ((*list) != NULL && (*list)->gdbarch == new_gdbarch);
+ gdb_assert ((*list) != nullptr && (*list)->gdbarch == new_gdbarch);
/* Unlink SELF. */
self = (*list);
(*list) = self->next;
--
2.34.1
next reply other threads:[~2022-09-13 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 13:55 TaiseiIto [this message]
2022-09-20 18:49 ` Tom Tromey
2022-10-14 23:42 ` Tom Tromey
2022-10-17 13:18 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY0PR0101MB4285F5DA4C3E1366CCD2604DA4479@TY0PR0101MB4285.apcprd01.prod.exchangelabs.com \
--to=taisei1212@outlook.jp \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).