From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92007 invoked by alias); 18 Oct 2019 12:52:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91998 invoked by uid 89); 18 Oct 2019 12:52:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*c:HHH X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-oln040092067070.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.92.67.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Oct 2019 12:52:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nU7pLBzAaDfBLuKuhMaFAWYf2hfzleMKSak7YWjcNOgf9GKnVciNKHYRuDqezFU+aDdUKYfYfBezDLT5n5NDyHVuPnJhxYij7AOHaRqXc2XHgkavLOxX5xfZ95s1xKyQvkNfkNh9DflecJiPl9E5faReBNLC/zpwVjh0vY7ApTQZv5W2FsKKOubAjOoNSnOuXr6/2FBTjA9gKgMChyzQIzbOIa+qGtYdAnqMpST5NOi7iuz/x5f8BV0lhrlGRS0mzSZbWf/eUNnJYsv00U0UTo5FaDy3bC10s1qbJPNzNTCXxzuW6QwNGx8W4K7/WugHzMP7Gmoz2Aa2qzWnFk2q0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QhPgiAJLPjTxrsossq+zJa60GcGrKUxfW+f0eNhlZO4=; b=WPMj/bmIldZporVPVs2XB0+Na4oUMyHi07G8M9D1/ikPHzoRsk54+TKhwjCljVMgZNTZm2z6rDfF3LpVpn9xaCwoyz0TVfYnPN9oYKC6+5P5lTKygbrzeDxrOdBcanUm0BLPXPd63/waa+gbZB9sgdcOaZr6N+S94bC3JQDEpatI9pJwgcRrl19QEsCM4mIGROkasNE6hFFPPxgp9RGCIO+lnzRvJozsgBLibyRMhUM1RMXM9NeEaTbV04P1gHs6q4DfiOmJD4LWmXFo2iquEL/CIe80kpehpLDbuenFjr+Zr82J1NbWVj47ZuvcxANyo9ZnUBbowStI0a+6BkKD6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM5EUR02FT058.eop-EUR02.prod.protection.outlook.com (10.152.8.51) by AM5EUR02HT065.eop-EUR02.prod.protection.outlook.com (10.152.9.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2367.14; Fri, 18 Oct 2019 12:52:40 +0000 Received: from VI1PR03MB4528.eurprd03.prod.outlook.com (10.152.8.54) by AM5EUR02FT058.mail.protection.outlook.com (10.152.9.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.14 via Frontend Transport; Fri, 18 Oct 2019 12:52:40 +0000 Received: from VI1PR03MB4528.eurprd03.prod.outlook.com ([fe80::f12a:6f14:2368:e758]) by VI1PR03MB4528.eurprd03.prod.outlook.com ([fe80::f12a:6f14:2368:e758%4]) with mapi id 15.20.2347.024; Fri, 18 Oct 2019 12:52:40 +0000 From: Bernd Edlinger To: "gdb-patches@sourceware.org" Subject: [PATCH] Make "skip" work on inline frames Date: Fri, 18 Oct 2019 12:52:00 -0000 Message-ID: x-microsoft-original-message-id: <828f3924-03c4-9986-edd8-23b92a31b7b4@hotmail.de> x-ms-exchange-transport-forked: True Content-Type: multipart/mixed; boundary="_002_VI1PR03MB4528B9076FC778EF9C0B8B61E46C0VI1PR03MB4528eurp_" MIME-Version: 1.0 X-SW-Source: 2019-10/txt/msg00620.txt.bz2 --_002_VI1PR03MB4528B9076FC778EF9C0B8B61E46C0VI1PR03MB4528eurp_ Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable Content-length: 420 Hi, I noticed that skip is not working well on inlined frames which may happen in optimized gcc stage3 binary, where step stops at functions which are marked for skip, whenever they happen to be in-lined, where it is ignored if the frame is marked for skip, thus currently skipped frames are only checked when the skipped function is not inlined, which is usually only the case in non-optimized builds. Thanks Bernd. --_002_VI1PR03MB4528B9076FC778EF9C0B8B61E46C0VI1PR03MB4528eurp_ Content-Type: text/x-patch; name="0001-Check-all-inline-frames-if-they-are-marked-for-skip.patch" Content-Description: 0001-Check-all-inline-frames-if-they-are-marked-for-skip.patch Content-Disposition: attachment; filename="0001-Check-all-inline-frames-if-they-are-marked-for-skip.patch"; size=4418; creation-date="Fri, 18 Oct 2019 12:52:39 GMT"; modification-date="Fri, 18 Oct 2019 12:52:39 GMT" Content-ID: <47BE0A7A484C914D9D33DA66E857E36D@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 Content-length: 5991 RnJvbSA2ZjI0Yzc2MmJmNDVkN2IxYjJkMmU5Mjg1ZGZlMjI1MGI2NTRiOGVh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBFZGxpbmdl ciA8YmVybmQuZWRsaW5nZXJAaG90bWFpbC5kZT4KRGF0ZTogRnJpLCAxOCBP Y3QgMjAxOSAxNDoyODo0NSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIENoZWNr IGFsbCBpbmxpbmUgZnJhbWVzIGlmIHRoZXkgYXJlIG1hcmtlZCBmb3Igc2tp cC4KClRoaXMgbWFrZXMgdGhlIHNraXAgY29tbWFuZCB3b3JrIGluIG9wdGlt aXplZCBidWlsZHMsCndoZXJlIHNraXBwZWQgZnVuY3Rpb25zIG1heSBiZSBp bmxpbmVkLgpQcmV2aW91c2x5IHRoYXQgd2FzIG9ubHkgd29ya2luZyB3aGVu IHN0ZXBwaW5nIGludG8KYSBub24taW5saW5lZCBmdW5jdGlvbi4KLS0tCiBn ZGIvaW5mY21kLmMgfCAxNSArKysrKysrKysrKysrKy0KIGdkYi9pbmZydW4u YyB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCA2NSBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dkYi9pbmZj bWQuYyBiL2dkYi9pbmZjbWQuYwppbmRleCA3MTA1Nzc0Li45ZTRkZTY2IDEw MDY0NAotLS0gYS9nZGIvaW5mY21kLmMKKysrIGIvZ2RiL2luZmNtZC5jCkBA IC01OCw2ICs1OCw3IEBACiAjaW5jbHVkZSAidGhyZWFkLWZzbS5oIgogI2lu Y2x1ZGUgInRvcC5oIgogI2luY2x1ZGUgImludGVycHMuaCIKKyNpbmNsdWRl ICJza2lwLmgiCiAjaW5jbHVkZSAiZ2Ric3VwcG9ydC9nZGJfb3B0aW9uYWwu aCIKICNpbmNsdWRlICJzb3VyY2UuaCIKICNpbmNsdWRlICJjbGkvY2xpLXN0 eWxlLmgiCkBAIC0xMTEyLDYgKzExMTMsOSBAQCBwcmVwYXJlX29uZV9zdGVw IChzdHJ1Y3Qgc3RlcF9jb21tYW5kX2ZzbSAqc20pCiAJICAgICAgJiYgaW5s aW5lX3NraXBwZWRfZnJhbWVzICh0cCkpCiAJICAgIHsKIAkgICAgICBwdGlk X3QgcmVzdW1lX3B0aWQ7CisJICAgICAgY29uc3QgY2hhciAqZm4gPSBOVUxM OworCSAgICAgIHN5bXRhYl9hbmRfbGluZSBzYWw7CisJICAgICAgc3RydWN0 IHN5bWJvbCAqc3ltOwogCiAJICAgICAgLyogUHJldGVuZCB0aGF0IHdlJ3Zl IHJhbi4gICovCiAJICAgICAgcmVzdW1lX3B0aWQgPSB1c2VyX3Zpc2libGVf cmVzdW1lX3B0aWQgKDEpOwpAQCAtMTExOSw3ICsxMTIzLDE2IEBAIHByZXBh cmVfb25lX3N0ZXAgKHN0cnVjdCBzdGVwX2NvbW1hbmRfZnNtICpzbSkKIAog CSAgICAgIHN0ZXBfaW50b19pbmxpbmVfZnJhbWUgKHRwKTsKIAkgICAgICBz bS0+Y291bnQtLTsKLQkgICAgICByZXR1cm4gcHJlcGFyZV9vbmVfc3RlcCAo c20pOworCisJICAgICAgc2FsID0gZmluZF9mcmFtZV9zYWwgKGZyYW1lKTsK KwkgICAgICBzeW0gPSBnZXRfZnJhbWVfZnVuY3Rpb24gKGZyYW1lKTsKKwor CSAgICAgIGlmIChzeW0gIT0gTlVMTCkKKwkJZm4gPSBTWU1CT0xfUFJJTlRf TkFNRSAoc3ltKTsKKworCSAgICAgIGlmIChzYWwubGluZSA9PSAwCisJCSAg fHwgIWZ1bmN0aW9uX25hbWVfaXNfbWFya2VkX2Zvcl9za2lwIChmbiwgc2Fs KSkKKwkJcmV0dXJuIHByZXBhcmVfb25lX3N0ZXAgKHNtKTsKIAkgICAgfQog CiAJICBwYyA9IGdldF9mcmFtZV9wYyAoZnJhbWUpOwpkaWZmIC0tZ2l0IGEv Z2RiL2luZnJ1bi5jIGIvZ2RiL2luZnJ1bi5jCmluZGV4IDA3YWViZmEuLjA0 YzFlZWUgMTAwNjQ0Ci0tLSBhL2dkYi9pbmZydW4uYworKysgYi9nZGIvaW5m cnVuLmMKQEAgLTQwNDEsNiArNDA0MSw0NSBAQCBzdGVwcGVkX2luX2Zyb20g KHN0cnVjdCBmcmFtZV9pbmZvICpmcmFtZSwgc3RydWN0IGZyYW1lX2lkIHN0 ZXBfZnJhbWVfaWQpCiAgIHJldHVybiAwOwogfQogCisvKiBMb29rIGZvciBh biBpbmxpbmUgZnJhbWUgdGhhdCBpcyBtYXJrZWQgZm9yIHNraXAuCisgICBJ ZiBQUkVWX0ZSQU1FIGlzIFRSVUUgc3RhcnQgYXQgdGhlIHByZXZpb3VzIGZy YW1lLAorICAgb3RoZXJ3aXNlIHN0YXJ0IGF0IHRoZSBjdXJyZW50IGZyYW1l LiAgU3RvcCBhdCB0aGUKKyAgIGZpcnN0IG5vbi1pbmxpbmUgZnJhbWUsIG9y IGF0IHRoZSBmcmFtZSB3aGVyZSB0aGUKKyAgIHN0ZXAgc3RhcnRlZC4gICov CisKK3N0YXRpYyBib29sCitpbmxpbmVfZnJhbWVfaXNfbWFya2VkX2Zvcl9z a2lwIChib29sIHByZXZfZnJhbWUsIHN0cnVjdCB0aHJlYWRfaW5mbyAqdHAp Cit7CisgIHN0cnVjdCBmcmFtZV9pbmZvICpmcmFtZSA9IGdldF9jdXJyZW50 X2ZyYW1lICgpOworCisgIGlmIChwcmV2X2ZyYW1lKQorICAgIGZyYW1lID0g Z2V0X3ByZXZfZnJhbWUgKGZyYW1lKTsKKworICBmb3IgKDsgZnJhbWUgIT0g TlVMTDsgZnJhbWUgPSBnZXRfcHJldl9mcmFtZSAoZnJhbWUpKQorICAgIHsK KyAgICAgIGNvbnN0IGNoYXIgKmZuID0gTlVMTDsKKyAgICAgIHN5bXRhYl9h bmRfbGluZSBzYWw7CisgICAgICBzdHJ1Y3Qgc3ltYm9sICpzeW07CisKKyAg ICAgIGlmIChmcmFtZV9pZF9lcSAoZ2V0X2ZyYW1lX2lkIChmcmFtZSksIHRw LT5jb250cm9sLnN0ZXBfZnJhbWVfaWQpKQorCWJyZWFrOworICAgICAgaWYg KGdldF9mcmFtZV90eXBlIChmcmFtZSkgIT0gSU5MSU5FX0ZSQU1FKQorCWJy ZWFrOworCisgICAgICBzYWwgPSBmaW5kX2ZyYW1lX3NhbCAoZnJhbWUpOwor ICAgICAgc3ltID0gZ2V0X2ZyYW1lX2Z1bmN0aW9uIChmcmFtZSk7CisKKyAg ICAgIGlmIChzeW0gIT0gTlVMTCkKKwlmbiA9IFNZTUJPTF9QUklOVF9OQU1F IChzeW0pOworCisgICAgICBpZiAoc2FsLmxpbmUgIT0gMAorCSAgJiYgZnVu Y3Rpb25fbmFtZV9pc19tYXJrZWRfZm9yX3NraXAgKGZuLCBzYWwpKQorCXJl dHVybiB0cnVlOworICAgIH0KKworICByZXR1cm4gZmFsc2U7Cit9CisKIC8q IElmIHRoZSBldmVudCB0aHJlYWQgaGFzIHRoZSBzdG9wIHJlcXVlc3RlZCBm bGFnIHNldCwgcHJldGVuZCBpdAogICAgc3RvcHBlZCBmb3IgYSBHREJfU0lH TkFMXzAgKGkuZS4sIGFzIGlmIGl0IHN0b3BwZWQgZHVlIHRvCiAgICB0YXJn ZXRfc3RvcCkuICAqLwpAQCAtNjUzMSw3ICs2NTcwLDggQEAgcHJvY2Vzc19l dmVudF9zdG9wX3Rlc3QgKHN0cnVjdCBleGVjdXRpb25fY29udHJvbF9zdGF0 ZSAqZWNzKQogCXRtcF9zYWwgPSBmaW5kX3BjX2xpbmUgKGVjcy0+c3RvcF9m dW5jX3N0YXJ0LCAwKTsKIAlpZiAodG1wX3NhbC5saW5lICE9IDAKIAkgICAg JiYgIWZ1bmN0aW9uX25hbWVfaXNfbWFya2VkX2Zvcl9za2lwIChlY3MtPnN0 b3BfZnVuY19uYW1lLAotCQkJCQkJICB0bXBfc2FsKSkKKwkJCQkJCSAgdG1w X3NhbCkKKwkgICAgJiYgIWlubGluZV9mcmFtZV9pc19tYXJrZWRfZm9yX3Nr aXAgKHRydWUsIGVjcy0+ZXZlbnRfdGhyZWFkKSkKIAkgIHsKIAkgICAgaWYg KGV4ZWN1dGlvbl9kaXJlY3Rpb24gPT0gRVhFQ19SRVZFUlNFKQogCSAgICAg IGhhbmRsZV9zdGVwX2ludG9fZnVuY3Rpb25fYmFja3dhcmQgKGdkYmFyY2gs IGVjcyk7CkBAIC02Njk3LDcgKzY3MzcsMTQgQEAgcHJvY2Vzc19ldmVudF9z dG9wX3Rlc3QgKHN0cnVjdCBleGVjdXRpb25fY29udHJvbF9zdGF0ZSAqZWNz KQogCiAJICBpZiAoY2FsbF9zYWwubGluZSA9PSBlY3MtPmV2ZW50X3RocmVh ZC0+Y3VycmVudF9saW5lCiAJICAgICAgJiYgY2FsbF9zYWwuc3ltdGFiID09 IGVjcy0+ZXZlbnRfdGhyZWFkLT5jdXJyZW50X3N5bXRhYikKLQkgICAgc3Rl cF9pbnRvX2lubGluZV9mcmFtZSAoZWNzLT5ldmVudF90aHJlYWQpOworCSAg ICB7CisJICAgICAgc3RlcF9pbnRvX2lubGluZV9mcmFtZSAoZWNzLT5ldmVu dF90aHJlYWQpOworCSAgICAgIGlmIChpbmxpbmVfZnJhbWVfaXNfbWFya2Vk X2Zvcl9za2lwIChmYWxzZSwgZWNzLT5ldmVudF90aHJlYWQpKQorCQl7CisJ CSAga2VlcF9nb2luZyAoZWNzKTsKKwkJICByZXR1cm47CisJCX0KKwkgICAg fQogCiAJICBlbmRfc3RlcHBpbmdfcmFuZ2UgKGVjcyk7CiAJICByZXR1cm47 CkBAIC02NzMxLDcgKzY3NzgsOCBAQCBwcm9jZXNzX2V2ZW50X3N0b3BfdGVz dCAoc3RydWN0IGV4ZWN1dGlvbl9jb250cm9sX3N0YXRlICplY3MpCiAJZnBy aW50Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9nLAogCQkJICAgICJpbmZydW46 IHN0ZXBwaW5nIHRocm91Z2ggaW5saW5lZCBmdW5jdGlvblxuIik7CiAKLSAg ICAgIGlmIChlY3MtPmV2ZW50X3RocmVhZC0+Y29udHJvbC5zdGVwX292ZXJf Y2FsbHMgPT0gU1RFUF9PVkVSX0FMTCkKKyAgICAgIGlmIChlY3MtPmV2ZW50 X3RocmVhZC0+Y29udHJvbC5zdGVwX292ZXJfY2FsbHMgPT0gU1RFUF9PVkVS X0FMTAorCSAgfHwgaW5saW5lX2ZyYW1lX2lzX21hcmtlZF9mb3Jfc2tpcCAo ZmFsc2UsIGVjcy0+ZXZlbnRfdGhyZWFkKSkKIAlrZWVwX2dvaW5nIChlY3Mp OwogICAgICAgZWxzZQogCWVuZF9zdGVwcGluZ19yYW5nZSAoZWNzKTsKLS0g CjEuOS4xCgo= --_002_VI1PR03MB4528B9076FC778EF9C0B8B61E46C0VI1PR03MB4528eurp_--