public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
	Tsukasa OI <research_trasio@irq.a4lg.com>,
	Stephane Carrez <Stephane.Carrez@gmail.com>,
	"Frank Ch . Eigler" <fche@redhat.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH v2 6/7] sim/ppc: Add ATTRIBUTE_PRINTF
Date: Sun, 23 Oct 2022 18:31:08 +0545	[thread overview]
Message-ID: <Y1U3kKt1zbvjgvV7@vapier> (raw)
In-Reply-To: <87wn95bctu.fsf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

On 12 Oct 2022 10:39, Andrew Burgess wrote:
> --- a/sim/ppc/corefile.c
> +++ b/sim/ppc/corefile.c
> @@ -292,8 +292,8 @@ core_map_find_mapping(core_map *map,
>      mapping = mapping->next;
>    }
>    if (abort)
> -    error("core_find_mapping() - access to unmaped address, attach a default map to handle this - addr=0x%x nr_bytes=0x%x processor=0x%x cia=0x%x\n",
> -	  addr, nr_bytes, processor, cia);
> +    error("core_find_mapping() - access to unmaped address, attach a default map to handle this - addr=0x%x nr_bytes=0x%x processor=0x%p cia=0x%x\n",

no 0x before %p

> +	  addr, nr_bytes, (void *) processor, cia);

why do you need (void*) cast ?  %p takes pointer of any type.

> --- a/sim/ppc/emul_chirp.c
> +++ b/sim/ppc/emul_chirp.c
> @@ -1509,7 +1509,7 @@ map_over_chirp_note(bfd *image,
>        return;
>      /* check the name field */
>      if (head.namesz > sizeof(name)) {
> -      error("chirp: note name too long (%d > %d)\n", (int)head.namesz, sizeof(name));
> +      error("chirp: note name too long (%d > %d)\n", (int)head.namesz, (int)sizeof(name));

please fix the format string instead of casting to random types.
sizeof uses %zu, not %d.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2022-10-23 14:00 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-25  8:44 [PATCH 0/7] sim, sim/ARCH: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 1/7] sim: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 2/7] sim/cris: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 3/7] sim/erc32: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 4/7] sim/m32c: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 5/7] sim/m68hc11: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 6/7] sim/ppc: " Tsukasa OI
2022-10-05 10:57   ` Andrew Burgess
2022-10-06  5:32     ` Tsukasa OI
2022-09-25  8:44 ` [PATCH 7/7] sim/rl78: " Tsukasa OI
2022-10-06  6:36 ` [PATCH v2 0/7] sim, sim/ARCH: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 1/7] sim: " Tsukasa OI
2022-10-11 14:24     ` Andrew Burgess
2022-10-06  6:36   ` [PATCH v2 2/7] sim/cris: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 3/7] sim/erc32: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 4/7] sim/m32c: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 5/7] sim/m68hc11: " Tsukasa OI
2022-10-11 14:25     ` Andrew Burgess
2022-10-06  6:36   ` [PATCH v2 6/7] sim/ppc: " Tsukasa OI
2022-10-11 14:27     ` Andrew Burgess
2022-10-12  8:29       ` Jan-Benedict Glaw
2022-10-12  9:39         ` Andrew Burgess
2022-10-12 10:36           ` Jan-Benedict Glaw
2022-10-12 12:15             ` Jan-Benedict Glaw
2022-10-12 12:50             ` Jan-Benedict Glaw
2022-10-12 13:16               ` Tsukasa OI
2022-10-12 12:38           ` [PATCH 0/1] sim/ppc: Fix erroneous error calls (supplement) Tsukasa OI
2022-10-12 12:38             ` [PATCH 1/1] sim/ppc: Fix core_find_mapping diagnostics Tsukasa OI
2022-10-12 13:50               ` Andrew Burgess
2022-10-23 12:46           ` Mike Frysinger [this message]
2022-10-06  6:36   ` [PATCH v2 7/7] sim/rl78: Add ATTRIBUTE_PRINTF Tsukasa OI
2022-10-11 14:23   ` [PATCH v2 0/7] sim, sim/ARCH: " Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1U3kKt1zbvjgvV7@vapier \
    --to=vapier@gentoo.org \
    --cc=Stephane.Carrez@gmail.com \
    --cc=aburgess@redhat.com \
    --cc=fche@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jbglaw@lug-owl.de \
    --cc=research_trasio@irq.a4lg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).