From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id CA263385116D for ; Sun, 23 Oct 2022 14:00:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA263385116D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id BE2283410BF; Sun, 23 Oct 2022 14:00:34 +0000 (UTC) Date: Sun, 23 Oct 2022 18:31:08 +0545 From: Mike Frysinger To: Andrew Burgess Cc: Jan-Benedict Glaw , Tsukasa OI , Stephane Carrez , "Frank Ch . Eigler" , gdb-patches@sourceware.org Subject: Re: [PATCH v2 6/7] sim/ppc: Add ATTRIBUTE_PRINTF Message-ID: Mail-Followup-To: Andrew Burgess , Jan-Benedict Glaw , Tsukasa OI , Stephane Carrez , "Frank Ch . Eigler" , gdb-patches@sourceware.org References: <9ee0350e33400397851bb55c129a675519e5f174.1665038133.git.research_trasio@irq.a4lg.com> <8735bucu5p.fsf@redhat.com> <20221012082940.44hq4m7qkudpvyl5@lug-owl.de> <87wn95bctu.fsf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JT/WBjtmNtTEMELi" Content-Disposition: inline In-Reply-To: <87wn95bctu.fsf@redhat.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --JT/WBjtmNtTEMELi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 12 Oct 2022 10:39, Andrew Burgess wrote: > --- a/sim/ppc/corefile.c > +++ b/sim/ppc/corefile.c > @@ -292,8 +292,8 @@ core_map_find_mapping(core_map *map, > mapping = mapping->next; > } > if (abort) > - error("core_find_mapping() - access to unmaped address, attach a default map to handle this - addr=0x%x nr_bytes=0x%x processor=0x%x cia=0x%x\n", > - addr, nr_bytes, processor, cia); > + error("core_find_mapping() - access to unmaped address, attach a default map to handle this - addr=0x%x nr_bytes=0x%x processor=0x%p cia=0x%x\n", no 0x before %p > + addr, nr_bytes, (void *) processor, cia); why do you need (void*) cast ? %p takes pointer of any type. > --- a/sim/ppc/emul_chirp.c > +++ b/sim/ppc/emul_chirp.c > @@ -1509,7 +1509,7 @@ map_over_chirp_note(bfd *image, > return; > /* check the name field */ > if (head.namesz > sizeof(name)) { > - error("chirp: note name too long (%d > %d)\n", (int)head.namesz, sizeof(name)); > + error("chirp: note name too long (%d > %d)\n", (int)head.namesz, (int)sizeof(name)); please fix the format string instead of casting to random types. sizeof uses %zu, not %d. -mike --JT/WBjtmNtTEMELi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVN5AACgkQQWM7n+g3 9YERZw//U0UwaBJB3tWGB5kgR3gAwq4aS75ebicxVNn2NZn4Uyn0uVz30V9osprY 1KPVkIsm1jUnT3B+unypiUPrFg9WNyKVnbGc9RhHIXAEAwxQM+SfNSwjRehKIheQ ffEHSpJHAAbvxk8XUnm85D/viJ/4iOQ7QCLlBGBaVbowLMXFSpfC3Mp1/FNVbQmt LckwSFs0inhPaYCP0NKapyWfFC4SOhxYZFhMSac7FESkpMY/ca3wcT5WMiskaLSz nvZBTa2PW99xDowQXVe7goSUjW4+kNudLLkMOC1T4bNOZLkdRxe0TgSCb6kWy082 qNxO7mlQZGrG9NYjTe0uU3rfynadgp+JcRGmZ7uElklMa3R0yjv8RxbinOTXXBqf BTQ94sQZ6LJefPSuDKCFb4nTkXCmG4nEvma7KwNdr0ywtV37VIjU67seKxSBoqPm 3L1ip8IIlTfDw/mTvIrJpzSgDTlQGxP8FOAOqXnxs3UQn9Wm4jTBkeiBaEx2YRK7 hspyYhfoWgoo1Q3FE6nu5PD00pp0Yd6/TxTh22Xeyadokwm3TTRCXn/7W8F7TeS3 RfvsL0rIs8KiAH2O2yA5FoRFg1J4+vd/uDuGbI2JGIRo+79MOS8tH8AOH929ffNW inVuXGqwJP71Ewx4yBtd/YXiZj4xqZ8qHdEutjmFbqOpXyYVIds= =9AVN -----END PGP SIGNATURE----- --JT/WBjtmNtTEMELi--