From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 6D57938582A4 for ; Sun, 23 Oct 2022 13:34:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D57938582A4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id E4D843410C1; Sun, 23 Oct 2022 13:34:30 +0000 (UTC) Date: Sun, 23 Oct 2022 18:05:05 +0545 From: Mike Frysinger To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] sim/ppc: fix warnings related to printf format strings Message-ID: Mail-Followup-To: Andrew Burgess , gdb-patches@sourceware.org References: <97bcb87aa4ece94b30b62ec5d1845909dbb933a1.1665578246.git.aburgess@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W5Zz1iUHfjVqDQ0m" Content-Disposition: inline In-Reply-To: <97bcb87aa4ece94b30b62ec5d1845909dbb933a1.1665578246.git.aburgess@redhat.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --W5Zz1iUHfjVqDQ0m Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 12 Oct 2022 13:38, Andrew Burgess via Gdb-patches wrote: > --- a/sim/ppc/igen.c > +++ b/sim/ppc/igen.c > @@ -442,7 +442,7 @@ main(int argc, > code |= generate_with_icache; > break; > default: > - error (NULL, "Expecting -Ggen-icache or -Ggen-icache=\n"); > + error ("Expecting -Ggen-icache or -Ggen-icache=\n"); the file is using inconsistent whitespace now > --- a/sim/ppc/ld-cache.c > +++ b/sim/ppc/ld-cache.c > @@ -88,13 +88,13 @@ static void > dump_cache_rule(cache_table* rule, > int indent) > { > - dumpf(indent, "((cache_table*)0x%x\n", rule); > + dumpf(indent, "((cache_table*)0x%p\n", rule); you don't want 0x with %p as %p already includes it comes up multiple times in this patch -mike --W5Zz1iUHfjVqDQ0m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVMXQACgkQQWM7n+g3 9YGgZA/9FxD2MKkfuG2rf4iQaOO7k5RW+Qy6ltmXENOOqZ3eyAkddxvWljbO8g4S fcrZE8vuHNUMlqvf0trBNg/qGWaDgztnN7bWieq9RQyTrrHJ1u5SlG2Dam2IVWAB QylHG7S5AuZRt1CI8E5RqmPbCuHL3jeqBcY1eigBl1qUeH6VJq+rS9Z4TTTmcE6l PZS3LsCK/KPzbG3wnD9dty59Fh3JO4GOnhg+fTxwcxvwJcz1xIqP0XXlIUAyRI4C Z4o9okGxQQfP4RNWctONpgMvhr8K8dq70GZupNp7RJMJb8pNtR5tQUHRsiEmg8F3 2z4AWzG7ntm+bn6PdoIXQltgwQ4Ka8LE9MtT/ySpjAM1/0j8K4sIQ1vyZH2xNyNa ZCTdaGG+iKQuCgHl+RYQMlFLqU0RHg56CQ1FannqfonQ0Z08N1H7hQTPFVgGCiet iRF3U7FeUDx6ADodan2QiDgOHsiqIC9KRPcguaHA46MgzA12q4p6QT8vbmiS1OEu 4kr2R5sQyYLsU4LpN7EP0S51PDkibdxqGfjhZL04DlfXhb1bOSVQIiiGt50GSYVh c8t+GerXP37ZKQVeBp/xlUQCzPr/fXmNq0bU1DLx//mRUcvkyx0PoGvVHnvtPv4e ZwTTtWoqCAY4ON0QF9K/srYH8IieZM52MASev9cZ4puq5V3lBTw= =Z79w -----END PGP SIGNATURE----- --W5Zz1iUHfjVqDQ0m--