From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id B7E263858CDA for ; Sun, 23 Oct 2022 15:05:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7E263858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 0411E340C6C; Sun, 23 Oct 2022 15:05:09 +0000 (UTC) Date: Sun, 23 Oct 2022 19:35:43 +0545 From: Mike Frysinger To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 03/10] sim/ppc: initialize a memory buffer in all cases Message-ID: Mail-Followup-To: Andrew Burgess , gdb-patches@sourceware.org References: <0bd7df35b8c709a72d6f2a0900e60fa12727779e.1666192979.git.aburgess@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/Jmem7v8AogfTOkJ" Content-Disposition: inline In-Reply-To: <0bd7df35b8c709a72d6f2a0900e60fa12727779e.1666192979.git.aburgess@redhat.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --/Jmem7v8AogfTOkJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 19 Oct 2022 16:24, Andrew Burgess via Gdb-patches wrote: > --- a/sim/ppc/emul_netbsd.c > +++ b/sim/ppc/emul_netbsd.c > @@ -888,6 +888,8 @@ do_fstat(os_emul_data *emul, > status = fdbad (fd); > if (status == 0) > status = fstat(fd, &buf); > + else > + memset (&buf, 0, sizeof (buf)); i don't think this is perf critical, so simpler to do: struct statfs buf = {}; -mike --/Jmem7v8AogfTOkJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVRrMACgkQQWM7n+g3 9YF39hAApkGS8MvtCBpX8uefMSKIRvBnc1BOmwBvJ/5DHtwQeiMH/N59DhRF+c1K RuALJnAGxgQf2Sfsk2Nl4bvs91nJgXZflA2F7hP4D8KqOfhX7lQDVs/zg0nj+juv apXpHr5ni3U5t569VjS2A/UDSYIS0/l5owehziycOq+eOH6Yry+js+n7CNRtnLfO /V310b+FY78LMvnbGaG/J3FkoAoGsIsQbe5/mOe2MwT8GrF3GQom0H4/RrcJVFJu MOOIVbF9gamrR0fNoHx1fSBAOukK1tV52RSCFi4LWb51GC+Q1qlMbgyMIN3SwiD5 7x+ooFptzylnOaBxRTsPdu8dWm6nmMeDJHuzm6UsoytOlz2vHFaSW6Qau6b9RJq0 ajhmI9QuaKY02ZgqfgCgGgRlGlXtuXWYQK7TSsbCtWwWxkN3yg0Us5P7saHyC0W1 9mIDQAc6lmASQ31UiygWGG0+/ACBXBgp5LzPtWXkdeVbc7bJrcYb4T1kMeeTtWN6 9pNNHI9DdivSbH6O7W6syE2HpZYNQpFMBF4FKz3PO1xIXDk1kcTXZwC75UbWB5GY KmrjB+vHGmsvBl2r8gnG/jzPlgVhoXpRjWGqlNOwWiyDS0DC69yQ1cJxtcPt5CwT Wu+jQciUxBKWGB7vm7Q4g68Y8AGq9ny4oqtZ8urCfHkRLKuOU1M= =dFTr -----END PGP SIGNATURE----- --/Jmem7v8AogfTOkJ--