From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 53D8D3858D1E for ; Sun, 23 Oct 2022 15:09:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 53D8D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id D98B3341184; Sun, 23 Oct 2022 15:09:55 +0000 (UTC) Date: Sun, 23 Oct 2022 19:40:29 +0545 From: Mike Frysinger To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 05/10] sim/ppc: fix for operator precedence warning from clang Message-ID: Mail-Followup-To: Andrew Burgess , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tzFytL4ixxxvfo/Y" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --tzFytL4ixxxvfo/Y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 19 Oct 2022 16:24, Andrew Burgess via Gdb-patches wrote: > --- a/sim/ppc/altivec.igen > +++ b/sim/ppc/altivec.igen > @@ -231,7 +231,7 @@ void::model-function::ppc_insn_vr_vscr:itable_index i= ndex, model_data *model_ptr > busy_ptr->vscr_busy =3D 1; > =20 > if (out_vmask) > - busy_ptr->nr_writebacks =3D 1 + (PPC_ONE_BIT_SET_P(out_vmask)) ? 1 : = 2; > + busy_ptr->nr_writebacks =3D 1 + ((PPC_ONE_BIT_SET_P(out_vmask)) ? 1 := 2); should drop the paren around PPC_ONE_BIT_SET_P while you're here otherwise lgtm -mike --tzFytL4ixxxvfo/Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVR9EACgkQQWM7n+g3 9YEs0w/7BM1I6Qve7aoCbvsuJT9gkCjMO565IbkbkghTSSjfbtMHA937fu1WxJC+ yp6axkczM0h2p8s0wRGC9o9YM2sdbRHqeZLzfgBTxlnGAoJoYLlPIA5WQ0IYkRHZ OC/Y8wPI2asC5vg/tNnmMwA3TPel9TkJS43nNt+3lQODAibcwjqdxFLp75hS35kl kV7Gf3lF/pzPwGj1cq50ZUzaUxrYeqUOlzvuNwI/UEDLzwW3xKJLMTmcPQ0UzL6V SycQGQ/2klVih+ZV19CIQfrie+FlDV080DYfcc3aE43VDA7b3fpCaBVVkmUfAywe dHDnhuGt877Ti+VwwiiMtAzMWiWdM+/vkfkLnodPZTqrKZEC5r+A/4ZIRQE4pMQm FwL2oofH465t0bac9eT+lzmx6ValRpcuOU+AHMg3Xrz7tzNXWqDJHTndWouN3Leh vUyx2a3Jsuyo0jALhdX60kushoiIgGwZXhlRNNpoHBJjQ4j5BQvHDtdxvlQD3FXR GO25K2C1LdNrfAmTKJ2Hsr12I7WwpGFxC4qq7eZqo21jzdF/TPRkeiO+e79ORogn t4oaP6W4a2I/vsDVPTENLkSw0RifBMjl4FXIouunPw/buUVCtbnQl5LRtLJ4Caed 9KSYDwdSk8BzpLXV/5a+VmxptHrQkrYIB9wf3xah4GlFdcnn+6E= =JpBM -----END PGP SIGNATURE----- --tzFytL4ixxxvfo/Y--